From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B93BDC48BE0 for ; Fri, 11 Jun 2021 14:57:09 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C18D361278 for ; Fri, 11 Jun 2021 14:57:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C18D361278 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2E500803B9; Fri, 11 Jun 2021 16:57:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="M8xZcr7Z"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 09F76803B9; Fri, 11 Jun 2021 16:57:04 +0200 (CEST) Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7AFB5804B9 for ; Fri, 11 Jun 2021 16:57:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=twoerner@gmail.com Received: by mail-qk1-x72a.google.com with SMTP id c124so31216942qkd.8 for ; Fri, 11 Jun 2021 07:57:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=a82GaFyf+c0r3DXXVC7sM7OYIegYG/PfqaVT/fg9Q/0=; b=M8xZcr7ZYz1chxlSa6KKJsB53xNmpvpfQu7ljbmcMI6jChylfAn9cjIl+llRvtL4LC viosVqNntWmN8JZ/J5u4DGiWq9f1k18qCIaHL3t8LolAq5S2BLd2PZgVYLlalcHOQPRO lMLx6xFlmehRNuA7g/hlh+Jy09kOqvZIOljmowdTtf5BNi3Q6FUL5Cj9xT0UhfM0Gjjy ZyZ8YTQycwA5gXqfsb4Q9tEmTpviFXo1/xCR1AmYBErwriXx5/bZoqjW/HT03uaI2a4u 4tyybY4vhusH35G/vF0MsA+fQkwb4B8KcEA7oKFcKxmMo7lbTmjh8AFhvTzxEnlrN+mf HdmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=a82GaFyf+c0r3DXXVC7sM7OYIegYG/PfqaVT/fg9Q/0=; b=BJpAomv3HPAEYDO+0ACVaMjZl6BPCgL6grp41cTQ4svnyr9N2a11+k/xWPaoEB2uyP M2EkgAA4Fqgxm837/tiN2+hizXDgm46ex1JsmCRihD8LVj22UI+8HJBdF+wTRAutl8B6 DpgLrb85NazFTDL6oz3XvMmF6An54PMTsZcHH4RDHZ1MSq8MhvXNdxtke87NSXhwesDr x6paXuoPxhhJmRVFSO1yZ7TGEImrQUQdoI+MsfyuF8O6J3KHpAJEHGd7BW31TllMzia/ arn8TNU60GG5M3kNnekrYpFh2511F2nW4Iot3E+D0ArWWzR9AS+1RhR3A6iAeUvfVgIr VZMg== X-Gm-Message-State: AOAM530UEjBlHVV6dqLFF2qSYGpTJNLPrtQVW6Li/8Dee2EjgI3Tq5fR k/pu3P7+FLMyywKxNGjQFAI= X-Google-Smtp-Source: ABdhPJx3LSexF8DoP9XVggq7VE4A3uxe0B7Z+qfzHeemSepIGGN+IBPFb/yp4wecuH1dA6FYEkyr4A== X-Received: by 2002:a37:ef05:: with SMTP id j5mr4219901qkk.104.1623423418217; Fri, 11 Jun 2021 07:56:58 -0700 (PDT) Received: from localhost (pppoe-209-91-167-254.vianet.ca. [209.91.167.254]) by smtp.gmail.com with ESMTPSA id f24sm4353829qkm.118.2021.06.11.07.56.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jun 2021 07:56:57 -0700 (PDT) Date: Fri, 11 Jun 2021 10:56:55 -0400 From: Trevor Woerner To: Tom Rini Cc: U-Boot Mailing List Subject: Re: [PATCH] scripts/get_maintainer.pl: obey ignore list Message-ID: <20210611145655.GA24653@localhost> References: <20210611033727.882-1-twoerner@gmail.com> <20210611142301.GW9516@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210611142301.GW9516@bill-the-cat> User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On Fri 2021-06-11 @ 10:23:01 AM, Tom Rini wrote: > On Thu, Jun 10, 2021 at 11:37:27PM -0400, Trevor Woerner wrote: > > > If the user creates a .get_maintainer.ignore file, make sure it is consulted > > and obeyed for *all* emails discovered by the script. > > > > Signed-off-by: Trevor Woerner > > --- > > scripts/get_maintainer.pl | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl > > index e3b41616c9..8c0fb8656e 100755 > > --- a/scripts/get_maintainer.pl > > +++ b/scripts/get_maintainer.pl > > @@ -2435,6 +2435,7 @@ sub merge_email { > > > > for (@_) { > > my ($address, $role) = @$_; > > + next if (ignore_email_address($address)); > > if (!$saw{$address}) { > > if ($output_roles) { > > push(@lines, "$address ($role)"); > > This got me to check and see that yes, our copy of get_maintainers.pl is > out of date from Linux. And in fact, a re-sync will let us add a > .get_maintainer.conf file and use upstream a lot more closely as it now > has logic to find all MAINTAINERS files in a tree. > > But this change isn't upstream. Please work with Joe Perches upstream > to get this change accepted and it'll flow down to us and not get > overwritten when I forget it was an intentional change :) Thanks! Thanks for the tip! I ran my patches through the kernel's latest get_maintainer.pl script and it correctly removes email entries that are listed in my ~/.get_maintainer.ignore file without any changes required. Therefore a re-sync would appear to fix the issue I found. I can take a look at the re-sync if you wish? It's unclear to me whether you're looking into the re-sync or not. Best regards, Trevor