public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Fabio Estevam <festevam@denx.de>
Cc: sbabic@denx.de, u-boot@lists.denx.de
Subject: Re: [PATCH 1/3] smegw01: Allow booting the Yocto image by default
Date: Tue, 15 Jun 2021 23:17:41 -0400	[thread overview]
Message-ID: <20210616031741.GO9516@bill-the-cat> (raw)
In-Reply-To: <20210615233840.2340227-1-festevam@denx.de>

[-- Attachment #1: Type: text/plain, Size: 1508 bytes --]

On Tue, Jun 15, 2021 at 08:38:38PM -0300, Fabio Estevam wrote:

> On the Yocto image there is a single partition and the kernel
> and dtb are present in the 'boot' directory.
> 
> Change it accordingly so that the board can boot the Yocto
> image by default.
> 
> Use the generic 'load' command instead, which is able to
> read from an ext4 partition.
> 
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
>  include/configs/smegw01.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/configs/smegw01.h b/include/configs/smegw01.h
> index 50f00136ac46..a92c583c8669 100644
> --- a/include/configs/smegw01.h
> +++ b/include/configs/smegw01.h
> @@ -29,11 +29,11 @@
>  	"bootm_size=0x10000000\0" \
>  	"mmcdev=0\0" \
>  	"mmcpart=1\0" \
> -	"mmcroot=/dev/mmcblk0p2 rootwait rw\0" \
> +	"mmcroot=/dev/mmcblk0p1 rootwait rw\0" \
>  	"mmcargs=setenv bootargs console=${console},${baudrate} " \
>  		"root=${mmcroot}\0" \
> -	"loadimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \
> -	"loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdtfile}\0" \
> +	"loadimage=load mmc ${mmcdev}:${mmcpart} ${loadaddr} boot/${image}\0" \
> +	"loadfdt=load mmc ${mmcdev}:${mmcpart} ${fdt_addr} boot/${fdtfile}\0" \
>  	"mmcboot=echo Booting from mmc ...; " \
>  		"run mmcargs; " \
>  		"if run loadfdt; then " \

Shouldn't this be using the generic distro boot and then generating an
extlinux.conf in OE?  Thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  parent reply	other threads:[~2021-06-16  3:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15 23:38 [PATCH 1/3] smegw01: Allow booting the Yocto image by default Fabio Estevam
2021-06-15 23:38 ` [PATCH 2/3] smegw01: Re-sync the defconfig Fabio Estevam
2021-06-16  3:18   ` Tom Rini
2021-06-15 23:38 ` [PATCH 3/3] smegw01: Select the CMD_UNZIP option Fabio Estevam
2021-07-10 15:53   ` sbabic
2021-07-10 19:35   ` sbabic
2021-06-16  3:17 ` Tom Rini [this message]
2021-07-12 11:19   ` [PATCH 1/3] smegw01: Allow booting the Yocto image by default Stefano Babic
2021-07-10 15:52 ` sbabic
2021-07-10 19:34 ` sbabic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210616031741.GO9516@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=festevam@denx.de \
    --cc=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox