From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E1B3C48BE5 for ; Wed, 16 Jun 2021 17:37:14 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B02E560FE9 for ; Wed, 16 Jun 2021 17:37:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B02E560FE9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9F9EE80D17; Wed, 16 Jun 2021 19:37:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="ui91lOCs"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 018F581D95; Wed, 16 Jun 2021 19:37:10 +0200 (CEST) Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0C79680D17 for ; Wed, 16 Jun 2021 19:37:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72c.google.com with SMTP id g19so237952qkk.2 for ; Wed, 16 Jun 2021 10:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=1+riFFIl7h+j4XP5y+fZnUUQi/cwnDgSmzevAdgTNTs=; b=ui91lOCs8Fc95BNsAcGw7KCiwjEcgOOY9mLpKvOpUZZj2cpRHei9aP/3qzT1ZELorD UWlehh6P9X4pzZVTwsj3oSYv7/uwe+qZlb/mVwuS0m7pq39DBZ/GI6d3OjFSuk0AHvU6 BcN5Svy1NRDlUaqof14JgQdgymcDOgCTSuofA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=1+riFFIl7h+j4XP5y+fZnUUQi/cwnDgSmzevAdgTNTs=; b=omjz7dyVDzwG4P54HKO+kwxBiYQPAMc4n2YX+KmvIQKsKE2bzg4t42c3WIz6aAIby8 knvl2C/xr6YD+i+0npXihQNGTBrOmdHUG0q+4eIyOzsyuTV2UDWjvP2wrYdpSy6l89WP Bc0QWg9CeCdWwgdWTqq11Rlh/Az9oEuAFJJ0i11cFLqQZPX20WQW9MIFlB+LexiUcKR/ KtJ4L0WW+ZGp7ASPH1keeVuG4YzhkTIxP0TwJlSHo5gCZwNlpX+a5EmwRSxbEg1M1iZa H3kWNeCkcQ5Zq4RMjbHrzayWSaKU8i9mPYSWL9dXaqkFOPqIjdLBYURjjXx/aa+9z+o5 ZJ+Q== X-Gm-Message-State: AOAM531qA7LhCZKGkN//mTVE8sFLKfEdgU680kFJylgqvJcjgwcmElDw 3/eEjLlrJZdvW8xvIHnz+gYlmA== X-Google-Smtp-Source: ABdhPJzPqheHvIdfDW0q0L2FVudSvHEN7E+3rYHLeEVPclluaNGKwLOQhp3aYlzdr0bZFlyzD4LqaA== X-Received: by 2002:a05:620a:c8d:: with SMTP id q13mr1270150qki.70.1623865024718; Wed, 16 Jun 2021 10:37:04 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-507d-0469-e510-a4e0.res6.spectrum.com. [2603:6081:7b01:cbda:507d:469:e510:a4e0]) by smtp.gmail.com with ESMTPSA id a134sm2046671qkg.114.2021.06.16.10.37.03 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 16 Jun 2021 10:37:04 -0700 (PDT) Date: Wed, 16 Jun 2021 13:37:02 -0400 From: Tom Rini To: Ivaylo Dimitrov Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , maemo-leste@lists.dyne.org, u-boot@lists.denx.de, Merlijn Wajer Subject: Re: [maemo-leste] [PATCH] arm: Remove nokia_rx51 board Message-ID: <20210616173702.GW9516@bill-the-cat> References: <20210519132748.mgzyukuvfmlx3uch@pali> <20210519155203.GZ17669@bill-the-cat> <20210521144418.GI17669@bill-the-cat> <20210521213645.2y5dawkvr6wfaymy@pali> <20210615123436.GH9516@bill-the-cat> <5848e9c9-4dab-00cc-07dc-ffa57b9417cd@gmail.com> <20210616121008.GR9516@bill-the-cat> <20210616121313.GS9516@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Q6g2ATH7KN2uTPp5" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --Q6g2ATH7KN2uTPp5 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 16, 2021 at 08:25:28PM +0300, Ivaylo Dimitrov wrote: > Hi, >=20 > On 16.06.21 =D0=B3. 15:13 =D1=87., Tom Rini wrote: > > On Wed, Jun 16, 2021 at 08:10:08AM -0400, Tom Rini wrote: > > > On Wed, Jun 16, 2021 at 09:02:16AM +0300, Ivaylo Dimitrov wrote: > > > > Hi, > > > >=20 > > > > On 15.06.21 =D0=B3. 15:34 =D1=87., Tom Rini wrote: > > > > > On Tue, Jun 15, 2021 at 08:40:30AM +0300, Ivaylo Dimitrov wrote: > > > > > > Hi, > > > > > >=20 > > > > > > On 22.05.21 =D0=B3. 0:36 =D1=87., Pali Roh=C3=A1r wrote: > > > > > > > On Friday 21 May 2021 10:44:18 Tom Rini wrote: > > > > > > > > On Wed, May 19, 2021 at 11:52:03AM -0400, Tom Rini wrote: > > > > > > > > > On Wed, May 19, 2021 at 03:27:48PM +0200, Pali Roh=C3=A1r= wrote: > > > > > > > > >=20 > > > > > > > > > > On Tuesday 18 May 2021 21:26:40 Tom Rini wrote: > > > > > > > > > > > This board has not been converted to CONFIG_DM_USB by= the deadline. > > > > > > > > > > > Remove it. > > > > > > > > > >=20 > > > > > > > > > > I'm very disappointed that you want to remove Nokia N90= 0 from U-Boot. > > > > > > > > > >=20 > > > > > > > > > > I was waiting waiting half of year because other develo= pers did not > > > > > > > > > > react to issues which were introduced and neither to pa= tches which I > > > > > > > > > > sent (+ trying to remind open issues). And also I was w= aiting another > > > > > > > > > > half of year until other N900 related patches were merg= ed. So the whole > > > > > > > > > > slowdown was not caused by me, why it is taking so long. > > > > > > > > > >=20 > > > > > > > > > > Now there is still one N900 DM related patch waiting fo= r review. I'm > > > > > > > > > > converting code step by step. > > > > > > > > > >=20 > > > > > > > > > > So the ball is not on my side. > > > > > > > > >=20 > > > > > > > > > So, what patch(es) need to be applied to get DM_USB enabl= ed? Thanks. > > > > > > > >=20 > > > > > > > > I don't see any open patches from you that look related to = enabling > > > > > > > > DM_USB on the platform. If you want to disable USB on the = platform for > > > > > > > > now instead, that's fine too. > > > > > > >=20 > > > > > >=20 > > > > > > I tried to migrate the latest master to DM_USB, but unfortunate= ly the > > > > > > results are pretty much sad - adding OF_CONTROL (which is a pre= requisite to > > > > > > have DM_USB IIUC) and OF_BOARD (so binary to be compiled), adds= ~100k to the > > > > > > size of the u-boot binary, so it becomes 370284 bytes. Given th= at we have > > > > > > less than 256k of storage space for the u-boot, the produced bi= nary cannot > > > > > > be used on n900 the same way current (no DM_USB) binary is used. > > > > > >=20 > > > > > > As I see it, there are not much options left - u-boot on N900 i= s not SPL, so > > > > > > we can't use OF_PLATDATA, which in turn always links libfdt. > > > > > > Also, if I read the code (usb-uclass.c) correctly, enabling DM_= USB requires > > > > > > the board to be converted to DT and this is way bigger change. > > > > > >=20 > > > > > > Please advice on how to proceed. > > > > >=20 > > > > > Please post your WIP patches, thanks. > > > > >=20 > > > >=20 > > > > Sorry, I am not sure I understand what patches you want me to post: > > > >=20 > > > > WDT patch has already been sent couple of months ago - > > > > https://lists.denx.de/pipermail/u-boot/2021-March/443868.html > > > > Do you want it to be rebased and resend? > > > >=20 > > > > DM_USB, I just started writing one and I immediately hit the OF_CON= TROL > > > > requirement. Enabling OF_CONTROL requires a full blown migration to= DT, > > > > which is a huge task and not really equal to "Please update the boa= rd to use > > > > CONFIG_DM_USB...". Without OF_CONTROL, I simply get link failures: > > > >=20 > > > > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueab= i/bin/ld: > > > > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueab= i/bin/ld: > > > > DWARF error: could not find abbrev number 3998 > > > > /tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_child_post_bind': > > > > :(.text+0x5672): undefined reference to > > > > `ofnode_read_u32_default' > > > > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueab= i/bin/ld: > > > > :(.text+0x568c): undefined reference to > > > > `ofnode_read_u32_default' > > > > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueab= i/bin/ld: > > > > /tmp/cc0BOqms.ltrans0.ltrans.o: in function `usb_scan_device': > > > > :(.text+0x6c84): undefined reference to `ofnode_first_s= ubnode' > > > > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueab= i/bin/ld: > > > > :(.text+0x6c96): undefined reference to `ofnode_read_u3= 2' > > > > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueab= i/bin/ld: > > > > :(.text+0x6ca4): undefined reference to `ofnode_next_su= bnode' > > > > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueab= i/bin/ld: > > > > /tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb+= 0x8): > > > > undefined reference to `dm_scan_fdt_dev' > > > > /usr/lib/gcc-cross/arm-linux-gnueabi/8/../../../../arm-linux-gnueab= i/bin/ld: > > > > /tmp/cc0BOqms.ltrans0.ltrans.o:(.u_boot_list_2_uclass_driver_2_usb_= hub+0x8): > > > > undefined reference to `dm_scan_fdt_dev' > > > >=20 > > > > Fixing those requires enabling of OF_CONTROL and this in turn means= the > > > > board must be migrated to DT, unless I am missing something. That's= why my > > > > "please advice..." stance. > > >=20 > > > Please post the patches that bring you to the above link errors, yes, > > > thanks. > >=20 > > To be clearer, finish up a patch that completes the migration but is too > > large to install on the hardware so that others can take a look. >=20 > I am not sure I understand that - a patch that completes the migration to > DM_USB cannot be done ATM as the binary does not link without OF_CONTROL. > And I am not going to enable OF_CONTROL as this means I will have to migr= ate > everything to DT. That's why I enable DM_USB only - see reply to the other > mail. My advise is to provide a linkable but not runnable (or, only runnable in QEMU, the problem is the fixed layout of the actual device flash, right?) patch so that we can figure out how and what needs to be tuned where so that we can see what to do about this platform. --=20 Tom --Q6g2ATH7KN2uTPp5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDKNrsACgkQFHw5/5Y0 tyx2TQv/RYKhP6g8WpTyTPcRGEh7ez7BVgRHrHj+PdpqloyeEdyX25+l5g2Y9CuS jHnx2ChGpWCJwqV3eKzaV4LsszCZ25DOgfo/wqnqskVWJrZbFWRpCaZ9nVhU8QrG gtE4qQ5VaLF3dtzHrFY3y6k6bKX9Lij+yrfAqAkEhGbz2mQG4Iv4LZsdgNyMy+OZ v94PPsQWLtrXTI7lOZvM5xKsuMbZYX3AFCvkQ9DjmoW/XYgs5FaM5ruVydlNK2DV nNYsPdvxk7v1d2SPjgnrPjTDRxmUBBvSTmGBi8BSkAFC4dJZfKebGe/4EAOkOSrg YL25dDsdbQ+phhC3H0Ml5sGyDRZ7z6d4c++sak1zbkNNuDGXpkEKDwMfGyeOJwBo Z3rWFYDwfN/AZbnfv17qokvUQw7BbvNmo7ldEOFUNJ9OCejYNdNNwOyDUoGxkKKS B9hHHVPOKIW+eA1x/HWI2ujjXmpZ4qjEeQNqc4d/Kb13eff2wuHJ0l5FVRZAH/j7 oLG5dsSs =5v3R -----END PGP SIGNATURE----- --Q6g2ATH7KN2uTPp5--