From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C157EC2B9F4 for ; Thu, 17 Jun 2021 19:16:25 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2825B613CB for ; Thu, 17 Jun 2021 19:16:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2825B613CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CCC3A82A1A; Thu, 17 Jun 2021 21:16:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 245B782A1A; Thu, 17 Jun 2021 21:16:20 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 7175782A1A for ; Thu, 17 Jun 2021 21:16:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F0F6B13A1; Thu, 17 Jun 2021 12:16:13 -0700 (PDT) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4C67D3F694; Thu, 17 Jun 2021 12:16:12 -0700 (PDT) Date: Thu, 17 Jun 2021 20:15:59 +0100 From: Andre Przywara To: Yu-Tung Chang Cc: jagan@amarulasolutions.com, hdegoede@redhat.com, kever.yang@rock-cihps.com, patrick.delaunay@foss.st.com, festevam@gmail.com, tharvey@gateworks.com, pbrobinson@gmail.com, hs@denx.de, lokeshvutla@ti.com, u-boot@lists.denx.de Subject: Re: [PATCH v1 1/1] sunxi: h3: Add initial ZeroPi support Message-ID: <20210617201559.39399452@slackpad.fritz.box> In-Reply-To: <20210615032552.1651-2-mtwget@gmail.com> References: <20210615032552.1651-1-mtwget@gmail.com> <20210615032552.1651-2-mtwget@gmail.com> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, 15 Jun 2021 11:25:52 +0800 Yu-Tung Chang wrote: > ZeroPi is a new board of high performance with low cost > designed by FriendlyElec., using the Allwinner H3 SOC. > > ZeroPi features > - Allwinner H3, Quad-core Cortex-A7@1.2GHz > - 256MB/512MB DDR3 RAM > - microsd slot > - 10/100/1000Mbps Ethernet > - Debug Serial Port > - DC 5V/2A power-supply > > Signed-off-by: Yu-Tung Chang Looks alright, thanks for sending this. One nit below. > --- > arch/arm/dts/Makefile | 3 +- > arch/arm/dts/sun8i-h3-zeropi.dts | 48 ++++++++++++++++++++++++++++++++ > board/sunxi/MAINTAINERS | 6 ++++ > configs/zeropi_defconfig | 13 +++++++++ > 4 files changed, 69 insertions(+), 1 deletion(-) > create mode 100644 arch/arm/dts/sun8i-h3-zeropi.dts > create mode 100644 configs/zeropi_defconfig > > diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile > index 096068261d..7c8e253350 100644 > --- a/arch/arm/dts/Makefile > +++ b/arch/arm/dts/Makefile > @@ -607,7 +607,8 @@ dtb-$(CONFIG_MACH_SUN8I_H3) += \ > sun8i-h3-orangepi-plus.dtb \ > sun8i-h3-orangepi-plus2e.dtb \ > sun8i-h3-orangepi-zero-plus2.dtb \ > - sun8i-h3-rervision-dvk.dtb > + sun8i-h3-rervision-dvk.dtb \ > + sun8i-h3-zeropi.dtb > dtb-$(CONFIG_MACH_SUN8I_R40) += \ > sun8i-r40-bananapi-m2-ultra.dtb \ > sun8i-v40-bananapi-m2-berry.dtb > diff --git a/arch/arm/dts/sun8i-h3-zeropi.dts b/arch/arm/dts/sun8i-h3-zeropi.dts > new file mode 100644 > index 0000000000..e36381f11b > --- /dev/null > +++ b/arch/arm/dts/sun8i-h3-zeropi.dts > @@ -0,0 +1,48 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) While I like those SPDX lines more, the Linux kernel copy still(?) uses the more explicit license header. And we aim to stay as close as possible to the kernel DTs, that includes comments as well. So if you resend a v2 which just copies the kernel .dts, I will queue it for the next merge window. Cheers, Andre P.S. For the first version of a single patch "series", just use "[PATCH]" in the subject. There is never a "v1", and also little reason for a "1/1". If you have some comments that would typically go into a cover letter, put them behind the "---" in the top of the email. > +/* > + * Copyright (C) 2021 Yu-Tung Chang > + */ > + > +#include "sun8i-h3-nanopi.dtsi" > + > +/ { > + model = "FriendlyARM ZeroPi"; > + compatible = "friendlyarm,zeropi", "allwinner,sun8i-h3"; > + > + aliases { > + ethernet0 = &emac; > + }; > + > + reg_gmac_3v3: gmac-3v3 { > + compatible = "regulator-fixed"; > + regulator-name = "gmac-3v3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + startup-delay-us = <100000>; > + enable-active-high; > + gpio = <&pio 3 6 GPIO_ACTIVE_HIGH>; /* PD6 */ > + }; > +}; > + > +&external_mdio { > + ext_rgmii_phy: ethernet-phy@7 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + reg = <7>; > + }; > +}; > + > +&emac { > + pinctrl-names = "default"; > + pinctrl-0 = <&emac_rgmii_pins>; > + phy-supply = <®_gmac_3v3>; > + phy-handle = <&ext_rgmii_phy>; > + phy-mode = "rgmii-id"; > + > + allwinner,leds-active-low; > + status = "okay"; > +}; > + > +&usb_otg { > + status = "okay"; > + dr_mode = "host"; > +}; > diff --git a/board/sunxi/MAINTAINERS b/board/sunxi/MAINTAINERS > index 76eba2ad20..4fc26077b2 100644 > --- a/board/sunxi/MAINTAINERS > +++ b/board/sunxi/MAINTAINERS > @@ -529,3 +529,9 @@ YONES TOPTECH BS1078 V2 BOARD > M: Peter Korsgaard > S: Maintained > F: configs/Yones_Toptech_BS1078_V2_defconfig > + > +ZEROPI BOARD > +M: Yu-Tung Chang > +S: Maintained > +F: configs/zeropi_defconfig > +F: arch/arm/dts/sun8i-h3-zeropi.dts > diff --git a/configs/zeropi_defconfig b/configs/zeropi_defconfig > new file mode 100644 > index 0000000000..f921b09892 > --- /dev/null > +++ b/configs/zeropi_defconfig > @@ -0,0 +1,13 @@ > +CONFIG_ARM=y > +CONFIG_ARCH_SUNXI=y > +CONFIG_SPL=y > +CONFIG_MACH_SUN8I_H3=y > +CONFIG_DRAM_CLK=408 > +CONFIG_MACPWR="PD6" > +# CONFIG_VIDEO_DE2 is not set > +CONFIG_DEFAULT_DEVICE_TREE="sun8i-h3-zeropi" > +# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set > +CONFIG_CONSOLE_MUX=y > +CONFIG_SUN8I_EMAC=y > +CONFIG_USB_EHCI_HCD=y > +CONFIG_USB_OHCI_HCD=y