Re: [PATCH] autoboot: fix typos of CONFIG_AUTOBOOT_USE_MENUKEY

Da Xue
2021-07-02T16:22:21Z

Hi Tom,

There is a distinction between the two flags CONFIG_AUTOBOOT_USE_MENUKEY
AND CONFIG_AUTOBOOT_MENUKEY.

config AUTOBOOT_USE_MENUKEY
bool "Allow a specify key to run a menu from the environment"
depends on !AUTOBOOT_KEYED
help
If a specific key is pressed to stop autoboot, then the commands in
the environment variable 'menucmd' are executed before boot starts.

config AUTOBOOT_MENUKEY
int "ASCII value of boot key to show a menu"
default 0
depends on AUTOBOOT_USE_MENUKEY
help
If this key is pressed to stop autoboot, then the commands in the
environment variable 'menucmd' will be executed before boot starts.
For example, 33 means "!" in ASCII, so pressing ! at boot would take
this action.

The modified patch that was merged causes Kconfig to remove both flags. I
will send another patch.

Best,

Da

On Thu, Jun 24, 2021 at 9:16 AM Tom Rini <trini@konsulko.com> wrote:

> On Mon, Jun 21, 2021 at 10:39:19PM -0400, Da Xue wrote:
>
> > replace typo CONFIG_USE_AUTOBOOT_MENUKEY with CONFIG_AUTOBOOT_USE_MENUKEY
> >
> > Signed-off-by: Da Xue <da@libre.computer>
>
> Applied to u-boot/master, thanks!
>
> --
> Tom
>

--

Best,

Da Xue
General Manager
Imprecision Systems LLC

TEL: +1 (856) 562-6108 (WhatsApp)
FAX: +1 856-624-3969