Re: [PATCH] autoboot: fix typos of CONFIG_AUTOBOOT_USE_MENUKEY

Tom Rini
2021-07-02T23:10:51Z

[-- Attachment #1: Type: text/plain, Size: 985 bytes --]

On Fri, Jul 02, 2021 at 12:22:01PM -0400, Da Xue wrote:

> Hi Tom,
>
> There is a distinction between the two flags CONFIG_AUTOBOOT_USE_MENUKEY
> AND CONFIG_AUTOBOOT_MENUKEY.
>
> config AUTOBOOT_USE_MENUKEY
> bool "Allow a specify key to run a menu from the environment"
> depends on !AUTOBOOT_KEYED
> help
> If a specific key is pressed to stop autoboot, then the commands in
> the environment variable 'menucmd' are executed before boot starts.
>
> config AUTOBOOT_MENUKEY
> int "ASCII value of boot key to show a menu"
> default 0
> depends on AUTOBOOT_USE_MENUKEY
> help
> If this key is pressed to stop autoboot, then the commands in the
> environment variable 'menucmd' will be executed before boot starts.
> For example, 33 means "!" in ASCII, so pressing ! at boot would take
> this action.
>
> The modified patch that was merged causes Kconfig to remove both flags. I
> will send another patch.

Ah, thanks for catching that!

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]