From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15E5FC2B9F4 for ; Mon, 28 Jun 2021 13:39:39 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 431F461883 for ; Mon, 28 Jun 2021 13:39:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 431F461883 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BF62282DC1; Mon, 28 Jun 2021 15:39:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Vmo1Y1FO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3AED582DD7; Mon, 28 Jun 2021 15:39:35 +0200 (CEST) Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6DDE282DC1 for ; Mon, 28 Jun 2021 15:39:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2d.google.com with SMTP id f5so9264066qvu.8 for ; Mon, 28 Jun 2021 06:39:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=X/ccQuLkiVbOsv2jlmaDrXkaVXHdi7IzTImu/fuEKUs=; b=Vmo1Y1FOhSpdP+MqbgIB8Fxgs3MLqFM3KJdn9ARtyCs5/wbpBimv75hTquog5FFWxp WOt723vjGrBXfU23r8Kt3SmdaijjLw+A1MKKxQsFCvYLoXMPa011PzQCoXUliJZBw6Xd V/OCkhgku+uVK/Ej/EpqA3rKAyRW+qTbtlLcY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=X/ccQuLkiVbOsv2jlmaDrXkaVXHdi7IzTImu/fuEKUs=; b=Vl6oBeLOKta0794mP5Zonshk4wx6rwLOKUv+eXnlMAeP/HuYaV3vRB+aY2qoxoUetl 3Ncv2FO/2QzUzOBfaj1aiQVkPu5PXhcr9CXIetiBmomXgvTn7A4zP+NERHsBkAd1uf6g V4pG+gUVIUeMmbOCjbh7PmDeCK+tfYZJuPz/p441794ilKaHYfJmVBAQ8gJQkTje01jP 8aIb8dpkTTRbHKtH3zOKHej/LWmvuoo0yVisA/1M1HwQa9ZGu+bxbPiQr4u4dH2OaaqM cFBS3oT96kOi7ZCfxr0j+s5+U8LTtT+mBD+OWfWEkA1rZKAKSDiQ/C0zRaQpQdd1SCYZ It2w== X-Gm-Message-State: AOAM5308A0zRtGXRQGAH5IE9eYExpkvNDbA/VBCZ5rpOuSpxYJUhj3tj vU71R6NNRzySmB9Vj+nf8NkjxA== X-Google-Smtp-Source: ABdhPJx9VQDxPo/ZH0DGfAY+wtFGaFQl4jBTWFYEfzj+E5lnv8dKhT+cj8a+VN5nJG2DmnsdP3lkSQ== X-Received: by 2002:a0c:d602:: with SMTP id c2mr25337059qvj.41.1624887570210; Mon, 28 Jun 2021 06:39:30 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2808-537e-3f88-1d98.res6.spectrum.com. [2603:6081:7b01:cbda:2808:537e:3f88:1d98]) by smtp.gmail.com with ESMTPSA id l2sm10755783qke.10.2021.06.28.06.39.28 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Jun 2021 06:39:29 -0700 (PDT) Date: Mon, 28 Jun 2021 09:39:27 -0400 From: Tom Rini To: Simon Glass Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Marek Vasut , Ivaylo Dimitrov , Lokesh Vutla , Merlijn Wajer , U-Boot Mailing List , Pavel Machek Subject: Re: [PATCH 1/2] DM_USB: allow building without OF_CONTROL Message-ID: <20210628133927.GZ9516@bill-the-cat> References: <7c4024e6-f58e-1f9a-d969-0d0b190c2484@denx.de> <20210620155426.GB9516@bill-the-cat> <19957b67-732a-f53d-4453-d37ce28a92a9@denx.de> <20210625123847.GM9516@bill-the-cat> <20210625130752.uuh4imvgrab6dylq@pali> <20210625161605.2kabnsfeoxgecapp@pali> <20210625165850.nvp64zovs27b62tz@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+CeNbjWahVCCmU74" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --+CeNbjWahVCCmU74 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 27, 2021 at 01:06:12PM -0600, Simon Glass wrote: > Hi Pali, >=20 > On Fri, 25 Jun 2021 at 10:58, Pali Roh=E1r wrote: > > > > On Friday 25 June 2021 10:43:11 Simon Glass wrote: > > > Hi Pali, > > > > > > On Fri, 25 Jun 2021 at 10:16, Pali Roh=E1r wrote: > > > > > > > > On Friday 25 June 2021 10:04:14 Simon Glass wrote: > > > > > But I do wonder about the > > > > > 100KB growth you saw with DT/DM. That seems absolutely enormous t= o me! > > > > > Can you please point me to the git tree for this? I'd like to > > > > > investigate. > > > > > > > > Patches in this series were written by Ivo. I do not know exact det= ails > > > > and numbers. But the fact is that it was required to enable thumb-2= mode > > > > (which has hw bugs on this cpu, see earlier emails; reason why it w= as > > > > disabled). If you want to investigate it, you can try compare u-boot > > > > from master/next and u-boot with applying these patches + disable > > > > thumb-2 mode. Note that we have already enabled LTO. > > > > > > > > > > That's probably a little beyond my level of enthusiasm. But if you are > > > able to push a tree with before/after commits, I will take a look. > > > > Hello Simon! I have already pushed these patches to github due to CI > > testing. So you can easily access them via git fetch/checkout. > > > > Before (this is already in u-boot git): > > $ git checkout a298d4fbcdba1b38e48ea2af0fc5386cab2070da > > > > After1: > > $ git fetch https://github.com/u-boot/u-boot.git refs/pull/83/head > > $ git checkout 1f038c8b45ef0018e52a2a4587eb73170769ac2f > > > > After2: > > =3D use After1 with: > > + disable CONFIG_SYS_THUMB_BUILD > > + enable CONFIG_OF_LIBFDT_OVERLAY > > + enable CONFIG_CMD_FDT > > > > defconfig file is nokia_rx51_defconfig >=20 > OK thanks, I see it. I pushed a tree to u-boot-dm/nokia_rx51 with a > few changes. The growth is about 19KB (without enabling Thumb). Some > more fine-grained control of what get enabled with LIBFDT could be > added to reduce that, perhaps by 5KB. So, was the entirety of the reduction you saw from dropping out EFI_LOADER? Just most of it? Disabling that came up in another part of this thread. And if we just need to disable EFI_LOADER, OF_LIBFDT_OVERLAY and CMD_FDT (and maybe tweak the mask value) in order to not need to do any other changes, yes, that's the right approach. It would be helpful, but not required, to confirm if thumb works or fails on hardware, but I do understand it's a PITA to unbrick these devices. --=20 Tom --+CeNbjWahVCCmU74 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDZ0Q8ACgkQFHw5/5Y0 tyy0pAv/a4SGce9XnGuxg3zachJFliRTZqgEky9X8QksGg382Ag+VvzGSWvfbUf3 iWk2/4luGjS7iJSAep8IH18AGtjh6Xlwfq3xUi8HNb8php237hMkXzt+HR09Wz6R TS0Jt3jKFTRobofDlxNGK2qx32Pgxbyt4E7r78oQLzpaYo1vAbkZ0dgCTn3oBJ0L OMF6NCto0vFH+j+webryC0QWdj0hhppH9LMgZOraTz1MSZvkvOFWLT3NzclKpW1X yxnsYfkXe1h07Pamu4uVDT8qdvmhTSJb0bNIOTEH33dx7mM9MqTkIoDSgmc2yrTG lyiBsrjHi0zKj9Tp26ci4e/YipFNjK0LXaXjnCVkshxbPltsNhdsJKKL6iMPwuEH L2QDWRsMO+IKZSISB4SDlmsGCrp4pcgoEsrqQwyhBI3mP5A58hDynkURcCF+Jpmv Pqh1Kr6JhSuSwlhbdGzOYDiGtyQ38fcgPZatKtOMo0cbbEmxDx+ZlOyYTm6IwPwd O0U5OZf6 =ySMJ -----END PGP SIGNATURE----- --+CeNbjWahVCCmU74--