Re: [PATCH 1/2] DM_USB: allow building without OF_CONTROL

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 3307 bytes --]

On Mon, Jun 28, 2021 at 08:20:31AM -0600, Simon Glass wrote:
> Hi Tom,
> 
> On Mon, 28 Jun 2021 at 07:39, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Sun, Jun 27, 2021 at 01:06:12PM -0600, Simon Glass wrote:
> > > Hi Pali,
> > >
> > > On Fri, 25 Jun 2021 at 10:58, Pali Rohár <pali@kernel.org> wrote:
> > > >
> > > > On Friday 25 June 2021 10:43:11 Simon Glass wrote:
> > > > > Hi Pali,
> > > > >
> > > > > On Fri, 25 Jun 2021 at 10:16, Pali Rohár <pali@kernel.org> wrote:
> > > > > >
> > > > > > On Friday 25 June 2021 10:04:14 Simon Glass wrote:
> > > > > > > But I do wonder about the
> > > > > > > 100KB growth you saw with DT/DM. That seems absolutely enormous to me!
> > > > > > > Can you please point me to the git tree for this? I'd like to
> > > > > > > investigate.
> > > > > >
> > > > > > Patches in this series were written by Ivo. I do not know exact details
> > > > > > and numbers. But the fact is that it was required to enable thumb-2 mode
> > > > > > (which has hw bugs on this cpu, see earlier emails; reason why it was
> > > > > > disabled). If you want to investigate it, you can try compare u-boot
> > > > > > from master/next and u-boot with applying these patches + disable
> > > > > > thumb-2 mode. Note that we have already enabled LTO.
> > > > > >
> > > > >
> > > > > That's probably a little beyond my level of enthusiasm. But if you are
> > > > > able to push a tree with before/after commits, I will take a look.
> > > >
> > > > Hello Simon! I have already pushed these patches to github due to CI
> > > > testing. So you can easily access them via git fetch/checkout.
> > > >
> > > > Before (this is already in u-boot git):
> > > > $ git checkout a298d4fbcdba1b38e48ea2af0fc5386cab2070da
> > > >
> > > > After1:
> > > > $ git fetch https://github.com/u-boot/u-boot.git refs/pull/83/head
> > > > $ git checkout 1f038c8b45ef0018e52a2a4587eb73170769ac2f
> > > >
> > > > After2:
> > > > = use After1 with:
> > > >   + disable CONFIG_SYS_THUMB_BUILD
> > > >   + enable CONFIG_OF_LIBFDT_OVERLAY
> > > >   + enable CONFIG_CMD_FDT
> > > >
> > > > defconfig file is nokia_rx51_defconfig
> > >
> > > OK thanks, I see it. I pushed a tree to u-boot-dm/nokia_rx51 with a
> > > few changes. The growth is about 19KB (without enabling Thumb). Some
> > > more fine-grained control of what get enabled with LIBFDT could be
> > > added to reduce that, perhaps by 5KB.
> >
> > So, was the entirety of the reduction you saw from dropping out
> > EFI_LOADER?  Just most of it?  Disabling that came up in another part of
> > this thread.  And if we just need to disable EFI_LOADER,
> > OF_LIBFDT_OVERLAY and CMD_FDT (and maybe tweak the mask value) in order
> > to not need to do any other changes, yes, that's the right approach.  It
> 
> For me, it dropped the size by about 90KB, although I'm including
> text, rodata and data in that number:
> 
> default
>         arm: (for 1/1 boards) all +129370.0 bss +1136.0 data +7399.0
> rodata +10989.0 text +109846.0
> 
> without ebbr
>        arm: (for 1/1 boards) all +38460.0 bss +1040.0 data +2375.0
> rodata +5333.0 text +29712.0

OK, so does this mean that with the right options disabled, and without
thumb for now, rx51 can just use a DT?  Pali? Ivaylo?

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]