From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B0CEC11F66 for ; Tue, 29 Jun 2021 12:11:35 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 738F061D6E for ; Tue, 29 Jun 2021 12:11:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 738F061D6E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 35E0582EC5; Tue, 29 Jun 2021 14:11:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="kWISRkwy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1C57A82F40; Tue, 29 Jun 2021 14:11:31 +0200 (CEST) Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B6A8782E55 for ; Tue, 29 Jun 2021 14:11:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x735.google.com with SMTP id f6so6389308qka.0 for ; Tue, 29 Jun 2021 05:11:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+vHdIIKVLDSx+XQsQjJLQaAqy3OSHglJRPYO5xbUOLI=; b=kWISRkwyu7/9YJuCYndfeAurmFcM1kj9sez7wXfGWVtcTRhfUBiAH7DECymoMzA7Ts SXiZ7Rx5tCzeU0Hyg+WFqqHiEhPgvNC2llVKDZc9YJABWzzc9q6GBcFOKbmykskKvLls tQznbwFKTm9ovSIFXJJHugg1tHkL7e2HozGuw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+vHdIIKVLDSx+XQsQjJLQaAqy3OSHglJRPYO5xbUOLI=; b=faLNQF9MHHMVxkRxXoeZhG/4QRRR1NfoghgEa4Eg3BpAJHY+fT5d/ofhAcimDd/EOu Rdkpl0NLYetd/npXFDrKoQZa6U/JNbiXXJdiH2SgK01375k3tdyqzZKw3dNEpH4EeqUp 5pNfOuILE+e3KvXd2/Oy9Ukd4q8sgJJB4QGLUBofAX3f9GJMbD+rEsObagUj1JwlenhO yQ89B3erwUSL4fyno2hf0fiiXAd6/cRSbz/UwZUnWkeOceKkZCkDRcMZTwjhsVwx3K1s +LGIJrhMm/fklv0dw4nBytoGpMP7gq1ies7Fpj/SKm0x530va/y3lWPAHtQtLJ/p5qPf rp0w== X-Gm-Message-State: AOAM532YDnRa7d5qyAgrOkmDc5dPg5oqdVO6WcDeizORAlpWiXiBNXI/ r+i94eEMA0RAuhp3tFM/BE7bNg== X-Google-Smtp-Source: ABdhPJxxQX8tM0H+RjJ+qH910+hVI3IWiq4GazWQSCR4Q+Z5Ry4avLTRRkYYUHFmwoPISahLmKSrOg== X-Received: by 2002:a37:2ec1:: with SMTP id u184mr30203211qkh.500.1624968686435; Tue, 29 Jun 2021 05:11:26 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-1dab-ad46-3d7e-2f8f.res6.spectrum.com. [2603:6081:7b01:cbda:1dab:ad46:3d7e:2f8f]) by smtp.gmail.com with ESMTPSA id v15sm11860659qkb.104.2021.06.29.05.11.23 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 Jun 2021 05:11:24 -0700 (PDT) Date: Tue, 29 Jun 2021 08:11:22 -0400 From: Tom Rini To: Andre Przywara Cc: Simon Glass , u-boot@lists.denx.de, Linus Walleij , Liviu Dudau Subject: Re: [PATCH] arm: Add (back) VExpress boards support Message-ID: <20210629121122.GV9516@bill-the-cat> References: <20210629114555.20805-1-andre.przywara@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uA61fODcg/cTFy7b" Content-Disposition: inline In-Reply-To: <20210629114555.20805-1-andre.przywara@arm.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --uA61fODcg/cTFy7b Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 29, 2021 at 12:45:55PM +0100, Andre Przywara wrote: > The v2021.07 merge window saw the removal of the Arm Ltd. Versatile > Express platform, along with their CA5, CA9 and TC2 boards. The trigger > was the missing conversion of the MMC driver. >=20 > Some folks complained about that internally, so bring those boards back, > but better than ever: > - Use DM and OF_CONTROL for all the boards. Use the .dts files from the > latest Linux kernel (5.13) for that. > - Move the board selection choice into the platform's Kconfig. > - Clean up some shared config and common definitions. > - Drop obsolete features like ATAGs support. > - Switch to the DM_ETH version of the SMC911X Ethernet driver. > - Drop MMC support. >=20 > The PL180 MMC driver actually supports DM_MMC, but that requires a > DM_GPIO driver for the card detect GPIO, which we don't have. This > specific GPIO is actually handled via the "sysregs" device, so we would > need a driver for that. QEMU does not emulate this part, also the DT > description is somewhat "special", so this is left for later. >=20 > This version compiles without any warning for all three boards now. > Tested on QEMU. >=20 > Signed-off-by: Andre Przywara > --- > Hi, >=20 > this relies on the SMC911x driver DT changes, as posted here: > https://lists.denx.de/pipermail/u-boot/2021-June/452989.html > I put a version with the changes broken down here: > https://github.com/Andre-ARM/u-boot/commits/tc2-history >=20 > This was tested on QEMU, for vexpress_ca15_tc2_defconfig with: > $ qemu-system-arm -M vexpress-a15,secure=3Don -cpu cortex-a15 -m 1G -smp = 1 \ > -drive file=3Dtramp-tc2.bin,if=3Dpflash,format=3Draw,read-only \ > -device loader,file=3Du-boot.bin,addr=3D0x80800000 -nographic >=20 > Where tramp-tc2.bin is a trampoline replacing the board's firmware: > 00000000 00 00 a0 e3 80 00 48 e3 10 ff 2f e1 > (mov r0, #0; movt r0, #0x8080; bx r0) >=20 > The vexpress_ca9x4_defconfig uses a different memory map, so the runes ar= e: > $ qemu-system-arm -M vexpress-a9 -cpu cortex-a9 -m 1G -smp 1 \ > -drive file=3Dtramp-ca9.bin,if=3Dpflash,format=3Draw,read-only \ > -device loader,file=3Du-boot.bin,addr=3D0x60800000 -nographic >=20 > tramp-ca9.bin: > 00000000 00 00 a0 e3 80 00 46 e3 10 ff 2f e1 > (mov r0, #0; movt r0, #0x6080; bx r0) My big question is how do we run this in CI? Or does it not _need_ that firmware file to really exist? Or is there a pending change to https://gitlab.denx.de/u-boot/u-boot-test-hooks.git to generate / just have exist those magic empty bins? Thanks! --=20 Tom --uA61fODcg/cTFy7b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDbDeMACgkQFHw5/5Y0 tyyeAAv9FOuw9a9Qr7W5sNZDazL/C1Fv70lSoLZEzJn3i+t/+r8Wbog3Ck3AMkGe doInE1NFwGgDz6vxcAKWleJ5Segimc9OAx2QCK1ROes2RLXhpHPFaVlcnONhf0VH QUdQ8Ws6t0p28np6ketaJ3A8N613p0uida02JqFJFZEJCaZnIQXPDoHbq+XY8tyI hQgNEWIzHuMeIAxoUPgXA7NlGXMjtbrWkDZpdxYWsD71SiTCkE6bfG3dvsFT7vkE ca3fYUsg+8NbA64/I5GFGz0p3zdps9mmJfCkJaEb+221xUYJgvcTHZsYlhmyvIn8 H6r+T20kK1l7QIDQSaAluUhglqOg91xh5b/+0j1DjBfTw3BsWOS7iC46w97n4plI D5371H8P1oVcuze79KmwthevlxunLyN9PovVGsx65PosqbO5e0PxKVWdwrljEUHB VdjzaAk/WqarISmo3rDRC7KBiAMYrWe8MIJUSQkJ3gn0RJC8BpOPHcEpB/XqE33/ 6+wsGkPk =4cI1 -----END PGP SIGNATURE----- --uA61fODcg/cTFy7b--