From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35E5DC11F65 for ; Wed, 30 Jun 2021 16:49:55 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F7806146D for ; Wed, 30 Jun 2021 16:49:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F7806146D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BB94282C0B; Wed, 30 Jun 2021 18:49:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Jn/gzaBA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id ACB3A82BEE; Wed, 30 Jun 2021 18:49:49 +0200 (CEST) Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D856C82BEE for ; Wed, 30 Jun 2021 18:49:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x833.google.com with SMTP id g12so1935921qtb.2 for ; Wed, 30 Jun 2021 09:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=56jPhqodd3JeEx4Qs9Et4Hj6YHaBAeCpfVuyUndBCwM=; b=Jn/gzaBAZ2CBP/iXClGupFEWfKV1cQW2cs7zbIH00KTQS9DUtEOVVfLQYGp0shRrAY XMybPtEOOvul4hV9lI81vJ4yBshj0pYWSIU7a7BVHP7zFgEsPVqPeYX4Yi28I4IRTBMI qbk+eXPrRxTD2rVlaheur+c5pMvIKKPMq/FXw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=56jPhqodd3JeEx4Qs9Et4Hj6YHaBAeCpfVuyUndBCwM=; b=STGje6JFUQjMO/9BR0zmCHW8eYC/dsTE+iE5041s4T1RMYJ5nITZf45B8NYKGNavBM RjN8OiNa2wPbQn9Z7ywrtvCHLzXaaq8OHtwGX14u0q8PYAZ5t4YZOuvLuH1fw3NBJ+C6 0OsnLJXgfUSTT/2sftArKEb4yZasAnvvCUPnMWOIvJHQkIRb1nUGzbeAua2DgRgWBrxp hnyOimnNiH+7IlFT2tnNgkMlVIRW95jcIN33mHeRuJ0Z106rG7K9yDTYQFr+XBJU5iyR vPtpEiZqENE24Go3cgN6HGXfM40PWU1bZ8vXE7Ek2fVBbS0MzlT1J/Kec3qGMj6jVV2V 5/4w== X-Gm-Message-State: AOAM531bPcS4U9DfdWK9sQm5HGbO9/fTvBKfGpOl9K6gNajA25cfHU2V Gc2xiXp6rN+spen5Tw3Y+yj9yw== X-Google-Smtp-Source: ABdhPJyT/YrOecRG5G1syCDopc+KT6EDPGgNshacPIhZts8Q2BxAGXitejzDgxHCO+HNN5xJxUG4mQ== X-Received: by 2002:ac8:5517:: with SMTP id j23mr10914120qtq.252.1625071785643; Wed, 30 Jun 2021 09:49:45 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-ed48-3ab5-19c4-9a46.res6.spectrum.com. [2603:6081:7b01:cbda:ed48:3ab5:19c4:9a46]) by smtp.gmail.com with ESMTPSA id 24sm149970qks.128.2021.06.30.09.49.44 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Jun 2021 09:49:45 -0700 (PDT) Date: Wed, 30 Jun 2021 12:49:43 -0400 From: Tom Rini To: Marek Vasut Cc: u-boot@lists.denx.de, Jagan Teki , Patrick Delaunay Subject: Re: [PATCH V2] spi: Update speed/mode on change Message-ID: <20210630164943.GG9516@bill-the-cat> References: <20210610120000.5147-1-marex@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3Fk0Fksofscv5J2e" Content-Disposition: inline In-Reply-To: <20210610120000.5147-1-marex@denx.de> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --3Fk0Fksofscv5J2e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 10, 2021 at 02:00:00PM +0200, Marek Vasut wrote: > The spi_get_bus_and_cs() may be called on the same bus and chipselect > with different frequency or mode. This is valid usecase, but the code > fails to notify the controller of such a configuration change. Call > spi_set_speed_mode() in case bus frequency or bus mode changed to let > the controller update the configuration. >=20 > The problem can easily be triggered using the sspi command: > =3D> sspi 0:0@1000 > =3D> sspi 0:0@2000 > Without this patch, both transfers happen at 1000 Hz. With this patch, > the later transfer happens correctly at 2000 Hz. >=20 > Signed-off-by: Marek Vasut > Cc: Jagan Teki > Cc: Patrick Delaunay Applied to u-boot/master, thanks! --=20 Tom --3Fk0Fksofscv5J2e Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDcoKQACgkQFHw5/5Y0 tyzMCwv+J7oGQIZsqmUEIzeY2ufcDTp9U7MYwmN9OVJUlLWWk5tP4mPwyx/FCuVU t/o9jCxmQzk0bONqWpONbc9TUz/RE03GXB1LVv0AX1h6TxOTCp3A3zAdCSWz84kl ub+nr0nuI1akMeodLx+nT1a0t2QrsaPGQ3fUTsKC8u/M2PIIAzePJdYCAyGfU2WH S1O5rxtSpOL/lUhaKKacEK+LgrUGQlup4KECQAPXZYWm5QmJ8ZD8AxDX+7/vFAiv C+snHIlcye2ysh63eN8oz52+OXkvoQnMlRXpmesDFc4PP5Ar3d9M2aCX1b5gxKmS MA0KtHF3qX0+pUkGPycLjZrVQZTfIJAebsHhoCsIDyxohhKnrkv+fRtte5F2Oi8c 4DHTEu5CIOSLCOy2VEOsMo+XI53dhLxPgUPI/z00G9mmWl28XwGKI95OcQCknLDe Sl7ICl4RQ7AHY2/nYT8xo3MmIvpxuUKjZ0pMuJAZdFDf7WurJjhyDS3pV8ZIL468 FKYXIPms =thyc -----END PGP SIGNATURE----- --3Fk0Fksofscv5J2e--