From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AF95C11F68 for ; Fri, 2 Jul 2021 14:29:00 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7ACA061427 for ; Fri, 2 Jul 2021 14:28:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7ACA061427 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 411DE814A4; Fri, 2 Jul 2021 16:28:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="ck1nFhj0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7E7B881ED0; Fri, 2 Jul 2021 16:28:55 +0200 (CEST) Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0B56B80C70 for ; Fri, 2 Jul 2021 16:28:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2e.google.com with SMTP id j14so4723539qvu.6 for ; Fri, 02 Jul 2021 07:28:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=aJgnt+KsZDV54saEHo6gbVW20rHMROqB3quoGI5mjz4=; b=ck1nFhj0+IzIaUBwYidVcOz2FrugahMXi5vL1mURcUb54SB6w0zE8H+gjKEQX5QntI W6z4crxkZfalO7odWVi98Q4Tp9REmaqWp76HD6yiy/j2nbaHCN4TyjGxPjwOSbZBwafR siV6SLQLr8kOZQ6o75AMuvSjz+4Zef/dSqa8k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=aJgnt+KsZDV54saEHo6gbVW20rHMROqB3quoGI5mjz4=; b=UoUrJxBIN3KcQioshWo15fBrVsIMXdEjMSO0l1tbRjhjRGLhmworL0KGOSd32CiHNQ l9E8XsVB/+fgq7EcFMK9b048RPTHYAlg88fUFyO6oioSxKGCPaH1vTEw1tyz6iKKuHkp ZUdaC/+vNurQxOomRp4k5FCae/zxUoVg26l++oQkIYB6UR92J+F2yH3aRu4fDRDFofAC URUMoAZo8M1o65P/yi+N3ChoJRgnVniSsx/8i+awAP+cGnyKliynkqPA7ul/3x/ISguC BxHFwxKM+qCyHW+vT9vG476jpB3ELicb8U26HutKV3K/33BInQaRaBM/CWEEazXpJ45n qC8Q== X-Gm-Message-State: AOAM5310Fot7aLcMz5O9cNjNuXJZ2ht3wl2m2Po5dsk717ktwvE+DIJw 6YsE2SMNBIUyzNy2cX3wlIxrRw== X-Google-Smtp-Source: ABdhPJx5KFDGL9AW048F0wNf0K3m1+XvXePBKg+gIXvMfUDyRvrxemix/lwrYbNZrIxBXqs3E6bDkQ== X-Received: by 2002:ad4:5386:: with SMTP id i6mr5615696qvv.2.1625236130799; Fri, 02 Jul 2021 07:28:50 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-91af-d604-26f4-428b.res6.spectrum.com. [2603:6081:7b01:cbda:91af:d604:26f4:428b]) by smtp.gmail.com with ESMTPSA id d129sm1409302qkf.136.2021.07.02.07.28.49 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 02 Jul 2021 07:28:50 -0700 (PDT) Date: Fri, 2 Jul 2021 10:28:47 -0400 From: Tom Rini To: Sean Anderson Cc: Rasmus Villemoes , u-boot@lists.denx.de, Marek =?iso-8859-1?Q?Beh=FAn?= , Wolfgang Denk , Simon Glass , Roland Gaudig , Heinrich Schuchardt , Kostas Michalopoulos Subject: Re: [RFC PATCH 03/28] cli: lil: Replace strclone with strdup Message-ID: <20210702142847.GX9516@bill-the-cat> References: <20210701061611.957918-1-seanga2@gmail.com> <20210701061611.957918-4-seanga2@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4W29cFDRvCS/fYYS" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --4W29cFDRvCS/fYYS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 02, 2021 at 09:38:26AM -0400, Sean Anderson wrote: > On 7/2/21 4:36 AM, Rasmus Villemoes wrote: > > On 01/07/2021 08.15, Sean Anderson wrote: > > > Apparently strdup is not portable, so LIL used its own. Use strdup. > >=20 > > You could reduce the churn by just making strclone "#define strclone(x) > > strdup(x)", but I suppose you end up modifying the upstream code so much > > that there's not really anything gained by that. > >=20 > > But that begs the question: What is the long-term plan for this? While > > it does seem to be an improvement compared to hush, will we ever be able > > to incorporate fixes&features from upstream, or will this code end up in > > the same situation as hush? >=20 > Well, since Hush was never updated, I don't believe LIL will be either. > I think reducing the amount of ifdefs makes the code substantially > easier to maintain. My intention is to just use LIL as a starting point > which can be modified as needed to better suit U-Boot. >=20 > The other half of this is that LIL is not particularly actively > developed. I believe the author sees his work as essentially > feature-complete, so I expect no major features which we might like to > backport. Port it and forget it was a problem, not a bug, of our hush implementation. For other things, I'm trying to keep us in sync regularly, but having less luck as some stuff has already gotten well behind and is non-trivial to resync. A digression, but for this thread I think keeping abreast of LIL releases is important. I diff'd 20190821 to 20210502 and it was (as you note in another part of the thread) copyright, license addition and I saw one line of code move around but didn't check if that applied here too or not. A monthly calendar reminder to check the site for new releases (which is what I do for Kconfiglib) should keep us in-sync, especially given the LIL project intentions. --=20 Tom --4W29cFDRvCS/fYYS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDfIpwACgkQFHw5/5Y0 tyxXQAv/dVWnBaYVc7tC/A9IgEj8VDt5XXO5Up37bIpKkpeFuGyQDlMyKCoY8adV ++aMIeMy6uAmq3bblIXcMnwioJ6qlu0qWp6LoUJ4dcWP0yqyhtZMmrzL0AhfcE21 DJ9uGJcCiz9242EzxdRALGWdwRzmLWibRnXalG1FoGs010B/yrHMAogqfbjU1lD5 0mlzZ/L5x3Z8ZJi4kWTb8Quz0V1lndVmjIO8UvH4tp0tjGo0oshOv5qdbsCQKxjD L7WRK4qCN7FM+XnDIeV5SPjliNtquOWoaEia0zl+LLSA4MZUbjbFfZtvwoD3cfJu cuLbNSXz8iq0A6dhuDrfcq0nG1cfror5sVWqvn7RsZmy6GQghLrPVHY2zRE+HyTA JyITyaAhSao5TtY/lmuTVeCJ15FZElK1Z6LIccvTej/mJpMukciDnSAfzKEtG09l 62geJfHEQkcHkFfu6n4Uj701wXpoS5x9+t76ZTJqSZEWT2tmIEzD8uuTh6Me3gFC hJmG/NLJ =0GBI -----END PGP SIGNATURE----- --4W29cFDRvCS/fYYS--