From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D249C07E95 for ; Fri, 2 Jul 2021 23:10:51 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A08D1613DF for ; Fri, 2 Jul 2021 23:10:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A08D1613DF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D16D0829BE; Sat, 3 Jul 2021 01:10:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="nOLg5Nwy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1FD72829B9; Sat, 3 Jul 2021 01:10:47 +0200 (CEST) Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DA6A5829E4 for ; Sat, 3 Jul 2021 01:10:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x729.google.com with SMTP id e14so73828qkl.9 for ; Fri, 02 Jul 2021 16:10:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lV6ceERzKBB304U2QyQdhSnwwfltJYlu1AXyd5s3pDo=; b=nOLg5Nwy8Z7tzP+NHxRHjzX1SbTUNqFHrPTK59uadaxdczQeweyGoXufq3EkqSoJzO H65u4ts9qCPRivzUkLabEzQtwan/DTuuRzwabqnmhf/LNnt8hQ7m84PqofPA49p+AvXi uU9HD0XBMd/N6YLjiiyLzzgzrBXpNdtP2El/I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lV6ceERzKBB304U2QyQdhSnwwfltJYlu1AXyd5s3pDo=; b=MMT/GlLe415S5I/FxpttFO6x8u6J9A2XOxnORHzbiXFyKuS62Pp+0WmKjISYG4yYhm f7TJIGJQ0Z2gzjhnuE7fF8vtA7u4y/kI0pp/0/hMJYpyVn9dxW6GvcwOdny5lXFlDgGQ /2xEHYJ7jvF9M0odbxrSJ9EkReC8q9BYBWZM681m/B4eYDOnHhSsiHE0TtFRGsMXLXO5 h3tLbpAsam3YflpDhTQ268uV1yQE/7BrN3+jn/4O6YwuuhrxLRBkyMYYLQS5Ue7eRn6g GHDI49O/zH0jKMQg9YXdINXbxu8oqZQLL9o18CEDbEx/CkakjiTIbCcCgRVxDRAL48Yb v/HQ== X-Gm-Message-State: AOAM530JgXctIIvGfshDIkcHJwgarcurlbWXuDYbALv+GaPChgUwEsu3 FYYhDK8r8RSCmbtoG+3KligFpA== X-Google-Smtp-Source: ABdhPJz9r7mQsWNVvY9Kl3zl4bkZ2WlMCSzzVIpqz9u32uQ0p5AtF38Oj0RLO/xtuBM/N0AbD1c5jw== X-Received: by 2002:a05:620a:2991:: with SMTP id r17mr2223553qkp.252.1625267442687; Fri, 02 Jul 2021 16:10:42 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-447a-194c-2139-e81a.res6.spectrum.com. [2603:6081:7b01:cbda:447a:194c:2139:e81a]) by smtp.gmail.com with ESMTPSA id u3sm1809441qtg.16.2021.07.02.16.10.41 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 02 Jul 2021 16:10:41 -0700 (PDT) Date: Fri, 2 Jul 2021 19:10:40 -0400 From: Tom Rini To: Da Xue Cc: U-Boot Mailing List , Simon Glass Subject: Re: [PATCH] autoboot: fix typos of CONFIG_AUTOBOOT_USE_MENUKEY Message-ID: <20210702231040.GK9516@bill-the-cat> References: <20210624131601.GF9516@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="u98ZBXZKi4Rt2Eit" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --u98ZBXZKi4Rt2Eit Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 02, 2021 at 12:22:01PM -0400, Da Xue wrote: > Hi Tom, >=20 > There is a distinction between the two flags CONFIG_AUTOBOOT_USE_MENUKEY > AND CONFIG_AUTOBOOT_MENUKEY. >=20 > config AUTOBOOT_USE_MENUKEY > bool "Allow a specify key to run a menu from the environment" > depends on !AUTOBOOT_KEYED > help > If a specific key is pressed to stop autoboot, then the commands in > the environment variable 'menucmd' are executed before boot starts. >=20 > config AUTOBOOT_MENUKEY > int "ASCII value of boot key to show a menu" > default 0 > depends on AUTOBOOT_USE_MENUKEY > help > If this key is pressed to stop autoboot, then the commands in the > environment variable 'menucmd' will be executed before boot starts. > For example, 33 means "!" in ASCII, so pressing ! at boot would take > this action. >=20 > The modified patch that was merged causes Kconfig to remove both flags. I > will send another patch. Ah, thanks for catching that! --=20 Tom --u98ZBXZKi4Rt2Eit Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDfnO8ACgkQFHw5/5Y0 tyzIUwwAswYzuSG7OO7XReJ2l8x8MpLEQTfbdu7Pf+uweiuBOBPoW7ZqFVozf9rn a3fD7S+wlOpZu46yeVaKzo9ikAoWJlCveIpd00AMTTX37e+auv9hENc/UrX2xSmt lcuXd1D0Rgnumy62JtTW6MHf8mhmJRk2wSmM7k2pJ1vmbbVEScdJaO1QjB5Q7fU3 e26r25ibQgDtIov+a7kbVewMmotPXkH9p+Egh1qOIreMF6b0v3ZJY/wYWCRz2DrY /jeDK/8tiCbEUMjU21rlazvvNmqjt+50Rt2hJhH6dlmm6DJ4LLrC+VDfZ+2HgWLX jRbnn1/LXJmboqgQBEfc+NeWzSmUiiL+bpxl9TUjJwQy+sZ5zV4M/aguPfNlP7y4 d6tNlTgftPgcdsdVAgl3pd7r3LWTFAgDrOV2l5H/9tJ+c6/pgISOLXa9etNMxmIV eJ5zKxqBIfcNwVPnvbiyAdWY2+ZBqzCkqyd6kyFaWXWHGXwu1hBoX29vcuih5EJg b/aHGmSr =aiUv -----END PGP SIGNATURE----- --u98ZBXZKi4Rt2Eit--