From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82DF4C07E99 for ; Mon, 5 Jul 2021 18:51:53 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7BCBE6197B for ; Mon, 5 Jul 2021 18:51:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BCBE6197B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 43ADA82BB4; Mon, 5 Jul 2021 20:51:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="pu6Wh/fw"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E97E682BE4; Mon, 5 Jul 2021 20:51:48 +0200 (CEST) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0159782BB2 for ; Mon, 5 Jul 2021 20:51:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72b.google.com with SMTP id b18so6305902qkc.5 for ; Mon, 05 Jul 2021 11:51:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=R1ONoVSVyuj30EYgxhSZzNayL/udbWh6jmngkevap6c=; b=pu6Wh/fwK5o4ZdacXVrXu8On9QXB1F8BwFvfMcezFM4xQ91Zvm6kdxDHuyVk61dy3w 4hjL3TKKLVoFK8qsfw8p9JWjLHbk7AVb7gMkVP05Zrp2yYmc1jkpwB5r2MzF75TOs12B GPRNNO2uzar8ChAe3n0AR/pC3/QtPaOR2M4Jk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=R1ONoVSVyuj30EYgxhSZzNayL/udbWh6jmngkevap6c=; b=icL7tKeEADvuaPCztRS2V8ur+MeRxAQQJ2Tu+sMQDeRb8uub1N/ULD0wX1FnyqBCRz mnuAnk8psVosPtpq2Q60tlzZs7vlupBaeYTGh8sTA4EyAh+an1INn1D0c4rFZ3ybcjKD egUONRgKG+2qfyA6OWNqUuTYmO4hlzK9n4sc6EONK188O+ZytCPhNy7aHgrWCUMAvsJk ag12h/73MmrVR6KFrbtPrVS7mUv0cwtGNUeCIJoad1lGhxB2VI0kS0EfLiz65308qITM ZRGtdxIYxoyROPwspvTtsWdXUAVsN5/zFLofiNRt8EBPb6B8xtIciiffimS0O+JqMd+l VelA== X-Gm-Message-State: AOAM532c9VLzr5/LupgPJD77TbVck5MRoN+1a0W+hEL+8tJt+Jr3dv+H Y/0OnMFYig0ls2JksP08aPw7Rw== X-Google-Smtp-Source: ABdhPJwb7EZkG6lD+zu3wJ6/W56vQNzZz/GZqBYI38+J6L+Ug3WDCtKfZOzizuQ/lClaITL8qza6PA== X-Received: by 2002:a37:5c86:: with SMTP id q128mr15042444qkb.457.1625511104826; Mon, 05 Jul 2021 11:51:44 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-5170-f33c-21eb-73eb.res6.spectrum.com. [2603:6081:7b01:cbda:5170:f33c:21eb:73eb]) by smtp.gmail.com with ESMTPSA id l26sm5693940qkl.44.2021.07.05.11.51.42 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 05 Jul 2021 11:51:43 -0700 (PDT) Date: Mon, 5 Jul 2021 14:51:41 -0400 From: Tom Rini To: Wolfgang Denk Cc: Sean Anderson , Simon Glass , U-Boot Mailing List , Marek =?iso-8859-1?Q?Beh=FAn?= , Roland Gaudig , Heinrich Schuchardt , Kostas Michalopoulos Subject: Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL Message-ID: <20210705185141.GA9516@bill-the-cat> References: <20210701061611.957918-1-seanga2@gmail.com> <20210701061611.957918-6-seanga2@gmail.com> <163753.1625507898@gemini.denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fgv20O/hFsZFZsAg" Content-Disposition: inline In-Reply-To: <163753.1625507898@gemini.denx.de> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --fgv20O/hFsZFZsAg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 05, 2021 at 07:58:18PM +0200, Wolfgang Denk wrote: > Dear Sean, >=20 > In message you wrote: > > > > > Is your intent to create a fork of this in U-Boot?=20 > > > > Yes. I believe some of the major additions I have made (especially "[RFC > > PATCH 21/28] cli: lil: Add a distinct parsing step") would not be > > accepted by upstream. >=20 > Ouch... >=20 > > > Could we not update things upstream, at least as an option, to avoid > > > carrying these patches? > > > > For some of the smaller patches, that may be possible. However, I am not > > a fan of the major amount of ifdefs that Hush has. For something as core > > as a shell, I think we should be free to make changes as we see fit > > without worrying about how it will affect a hypothetical backport. >=20 > I'm afraind I cannot understand your thinking. >=20 > You complain that the existing port of hus has a number of severe > limitations or bugs which have long been fixed upstream, but cannot > be easily fixed in U-Boot because we essentially created an > unmaintained fork - and as a cure, you recommend to do the same > thing again, but this time intentionally and deliberately? >=20 >=20 > If you had not apparently already invested a lot of effort into this > thing I would assume you must be joking... >=20 > To me such an approach is unacceptable. I think I want to try and address this. While with "hush" we have something that's in heavy active development outside of U-Boot, with LIL we have something that's mature and "done". Tracking an active outside development is HARD and requires constant resync. Look at the last few LIL releases. That could be easily re-worked in to our fork if needed. I see that as a positive, not a negative. --=20 Tom --fgv20O/hFsZFZsAg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDjVLkACgkQFHw5/5Y0 tyxOGwv+PaoRu02KQ6ran3IisxxCxYI9RL5AZTpqBQX1WpCRmudOMQrqrrvXJSf1 JEJWoZU17c9GDK5k4vlvgycpwZJvvBqDGe8ETZ+OgCExlXpyA+wkm66htBx7SOCh kCF9axSCfe0ev8Ja7YGxLRhL4tA49r5lZntTjlRdRieljBznIA4CVrSdyMX9xMEW jdjh9C9uz3ktAn10389XbnfoeWfrtbjB1phHvDIrr8iF7N26PqnA1/97jrXmX3We Qgkkzmk6/fWOYDhgCJDgUFaHueRMW9YzfcsfC+XXoQnkBrBR2CzB9tOaZuB0n/6N 7HynLrgUIEcGVPQ3CgthH4BfeZqrxWB3Mu5Z3MaG6MCD8fH52htCK9t6SBNPVBIm o7INb+V/sikoU9SXmynHmkalpL/EMz44Jn6brLeDjeS1XcAM43I3yCkfvD8yuLiA gAmDl0KkbJyZYjcRCsrQ67036/NWxkkSQtG1QPWK8CVcOR3KJegedgd/bgSfm/7q MBt1GTuw =8fPN -----END PGP SIGNATURE----- --fgv20O/hFsZFZsAg--