From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF3E2C07E99 for ; Mon, 5 Jul 2021 21:36:26 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E85E561987 for ; Mon, 5 Jul 2021 21:36:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E85E561987 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A11B882BC7; Mon, 5 Jul 2021 23:36:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="pCOeTHWy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6C8A982BDD; Mon, 5 Jul 2021 23:36:21 +0200 (CEST) Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8399782A29 for ; Mon, 5 Jul 2021 23:36:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82c.google.com with SMTP id h11so10163563qtp.5 for ; Mon, 05 Jul 2021 14:36:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GZDrgz5ofPgI6v0ePADiHaAeX6NhkDHHLg3Bc3yx+uE=; b=pCOeTHWyY07Nm1sLZX/rPgW+mxq6De9aFfUhpCnd/Dqd07BQx9Q2T9P1Jk+uMaNwJ8 7Uszne28uixcK7Y3P6MCKWGd/odd/4HTahxo44EjhzrErUMlZa1gCoHleqMFAMtD9atD tOo4yE3al0JfmGjNVgow6GvSwlHrORTe7RGK8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GZDrgz5ofPgI6v0ePADiHaAeX6NhkDHHLg3Bc3yx+uE=; b=Svpn0FbHjHWa9WCvsiIxEPAPOx1AyWTUPYUiNBCYAJMi12XZy9ySJFp7ROvK95OYiz fuYvuxsP3P1ClgPWO0ayCQDPfLscmbjqaEaz37Z3gz2bQxYegtdlssSVLP6fpcvY8l67 XeuZM+221dImsZHSw4J/miztFrEfc+gxsmHrSZ1o98MRBEF1OoWmzMujgEA0jBXndeRt 9CjHQOshOaDZUgkMgyIvhWr4AeXlsvEl5bTNp9vSyaJ7N7mOly/jPO/igeWYtScdabaT mgCCWu1xwVEWZwH9WGkzKCFZ12GyAT7C8ksv219dClXD+e8olHViffeyldmGA7Ir56AS BDog== X-Gm-Message-State: AOAM532h/3fAwpX0yO6AteJV2lfEvA3eHJtjEfAJRp/6ZgvYsNgDHXVx vJDe0fQebktwdOdIkQsUBGlZOQ== X-Google-Smtp-Source: ABdhPJxJkZKcUdAGS3PJX+htOQP+WU4yQQWLbaRSXNRCPC0NztQMAFsP6IwXCPCZ7lhc4RBiGjhTIw== X-Received: by 2002:ac8:549:: with SMTP id c9mr14400121qth.80.1625520977199; Mon, 05 Jul 2021 14:36:17 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-5170-f33c-21eb-73eb.res6.spectrum.com. [2603:6081:7b01:cbda:5170:f33c:21eb:73eb]) by smtp.gmail.com with ESMTPSA id x14sm2461087qkm.64.2021.07.05.14.36.15 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 05 Jul 2021 14:36:16 -0700 (PDT) Date: Mon, 5 Jul 2021 17:36:14 -0400 From: Tom Rini To: Simon Glass Cc: Wolfgang Denk , Sean Anderson , U-Boot Mailing List , Marek =?iso-8859-1?Q?Beh=FAn?= , Roland Gaudig , Heinrich Schuchardt , Kostas Michalopoulos Subject: Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL Message-ID: <20210705213614.GD9516@bill-the-cat> References: <20210701061611.957918-1-seanga2@gmail.com> <20210701061611.957918-6-seanga2@gmail.com> <163753.1625507898@gemini.denx.de> <20210705185141.GA9516@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9ChjDSKCRzSNgEeu" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --9ChjDSKCRzSNgEeu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 05, 2021 at 03:02:24PM -0600, Simon Glass wrote: > Hi Tom, >=20 > On Mon, 5 Jul 2021 at 12:51, Tom Rini wrote: > > > > On Mon, Jul 05, 2021 at 07:58:18PM +0200, Wolfgang Denk wrote: > > > Dear Sean, > > > > > > In message you wrote: > > > > > > > > > Is your intent to create a fork of this in U-Boot? > > > > > > > > Yes. I believe some of the major additions I have made (especially = "[RFC > > > > PATCH 21/28] cli: lil: Add a distinct parsing step") would not be > > > > accepted by upstream. > > > > > > Ouch... > > > > > > > > Could we not update things upstream, at least as an option, to av= oid > > > > > carrying these patches? > > > > > > > > For some of the smaller patches, that may be possible. However, I a= m not > > > > a fan of the major amount of ifdefs that Hush has. For something as= core > > > > as a shell, I think we should be free to make changes as we see fit > > > > without worrying about how it will affect a hypothetical backport. > > > > > > I'm afraind I cannot understand your thinking. > > > > > > You complain that the existing port of hus has a number of severe > > > limitations or bugs which have long been fixed upstream, but cannot > > > be easily fixed in U-Boot because we essentially created an > > > unmaintained fork - and as a cure, you recommend to do the same > > > thing again, but this time intentionally and deliberately? > > > > > > > > > If you had not apparently already invested a lot of effort into this > > > thing I would assume you must be joking... > > > > > > To me such an approach is unacceptable. > > > > I think I want to try and address this. While with "hush" we have > > something that's in heavy active development outside of U-Boot, with LIL > > we have something that's mature and "done". Tracking an active outside > > development is HARD and requires constant resync. Look at the last few > > LIL releases. That could be easily re-worked in to our fork if needed. > > I see that as a positive, not a negative. >=20 > Yes I wondered about that, since hush has been in busybox, an active > project, all these years. I think this is a good point and perhaps > means that forking it should not be too much of a concern. Still, if > we can send some things upstream, we should. Well, that's part of the problem. If we re-port modern hush, who is going to keep it in sync, and how often? Yes, there will be changes we don't need, but there will be bugfixes we do as well. --=20 Tom --9ChjDSKCRzSNgEeu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDje0QACgkQFHw5/5Y0 tyy1lAv+JRlBdMIWjZk+i56heT6rgToOKb3UwSZk2xY7afW/zmVK3xA8WkUHyf4A rXCc3giqzFECNC3T0VBd7S4AEhnapRsLYDRRdv1piMJ6LocEa4vC3b+ehLDkhFGI CNpZQcRzLpAlPeHU/hYWZh5s/D1QlHdgq0pZmo3iVlabc01GCrZlwsYd+Dy0u3NS wc21+OW3y6HCAy8cPnAwGuJT3apBHxZfVZc5q9FNOZs6QeuoLnUFtXcGqpbuWaf0 sXAiA5pat+2QlPAnsorNvuNa1t/apCpjgJyT3oDB5jyDg0KWitHkjKT5Sf8Mhf61 0ZuFNh4Ji7xJqF4Z/1JV+SbK2SLQkbmpmQwlfhyK0t3FNrXuIvoaqB52hfUSQRE5 vjumzB38oxb79d//1BU1OzY2eFo1fNxLfAmEETlotaoDGJTHYZdG7/l+txoujHtC I5TBh6zMp1BL5XD3DWNa+jtdS9J0n5+Qx/AdBXDU8NuM8J5vRef8KLzAP6j+QjZF tOmGBLQK =C/BF -----END PGP SIGNATURE----- --9ChjDSKCRzSNgEeu--