From: Tom Rini <trini@konsulko.com>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: u-boot@lists.denx.de, Ramon Fried <rfried.dev@gmail.com>
Subject: Re: [PATCH] arm: dts: db410c: Add missing cd-gpios for SD card detection
Date: Tue, 6 Jul 2021 18:50:53 -0400 [thread overview]
Message-ID: <20210706225053.GP9516@bill-the-cat> (raw)
In-Reply-To: <20210627110615.9161-1-stephan@gerhold.net>
[-- Attachment #1: Type: text/plain, Size: 996 bytes --]
On Sun, Jun 27, 2021 at 01:06:15PM +0200, Stephan Gerhold wrote:
> It looks like SD card detection is broken at the moment for DB410c.
> The eMMC is detected correctly, but the SD card is not.
>
> This is probably similar to the issue fixed in commit 850514740358
> ("mmc: msm_sdhci: Use mmc_of_parse for setting host_caps") for eMMC,
> except that the SD card does not have a property like "non-removable"
> that skips the card detection.
>
> The SDHCI on DB410c cannot detect itself if a SD card is inserted,
> so add the necessary cd-gpios to make SD card detection work again.
>
> While at it, fix the #gpio-cells for the soc_gpios to avoid DTC
> warnings - the soc_gpios are actually already used with two cells
> for the gpio-leds so this was just wrong all the time.
>
> Cc: Ramon Fried <rfried.dev@gmail.com>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2021-07-06 22:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-27 11:06 [PATCH] arm: dts: db410c: Add missing cd-gpios for SD card detection Stephan Gerhold
2021-06-27 19:50 ` Ramon Fried
2021-07-06 22:50 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210706225053.GP9516@bill-the-cat \
--to=trini@konsulko.com \
--cc=rfried.dev@gmail.com \
--cc=stephan@gerhold.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox