From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A166C07E95 for ; Wed, 7 Jul 2021 13:58:45 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C097261C73 for ; Wed, 7 Jul 2021 13:58:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C097261C73 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5D87882E0E; Wed, 7 Jul 2021 15:58:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="bcVZR6rq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AB1EA82E1D; Wed, 7 Jul 2021 15:58:40 +0200 (CEST) Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B327D82B30 for ; Wed, 7 Jul 2021 15:58:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72f.google.com with SMTP id q16so1974960qke.10 for ; Wed, 07 Jul 2021 06:58:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=v4rc2jivXUjBR3tNpPJThJAaeQ5rB4XN6tU0Vy0Lcbw=; b=bcVZR6rq0afrS2H00o/hHvH/7xTDlFvQh6+rS3nB6bI9UKBkvgWumBxnGiaq5sulDd Oj32lmFaU7XI8ixsXV8RkCI78PxOKw7vu5l525476NS22nj4OtFF0Vl0TAGDdoGTCGbv yLaeWGOjj78nwDjbENWPwIOaJJg12nTbt/bzQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=v4rc2jivXUjBR3tNpPJThJAaeQ5rB4XN6tU0Vy0Lcbw=; b=ij31s3bD9VwjxXE33EeR7gJnqgF5mjPxEtvE0oZ3zj9XlFWFIsBnNjNx5cZGmiTUvF LlDmno6q48KIaOnlRX9PRtO5S/T2uTTI01PSE8aWMZyrl10I4GmUmf3LMXa17iG5Q0AH pY9BbAil134pHYsvOrOsfV//wkyDnNhd4YK9TN0kcMbnKZkVmmtsVlfm3BZlEqGr1y0O G9p27/Jhqv7Q8KFffUCNIXXx0adsOQMf8vOWW16K/krnIbkfr/YTLVRGJaC/eq3MIl/d 1XHPCucItbP4mUCozTQ+IFAtgFUBp9bzCnJRs5/RmhF7JwYLBGAQ5EJgPw2488a2cIHK XGPg== X-Gm-Message-State: AOAM532oQ5E/IguO/dOSv8CrKypXpPUwuKnXLIdBlzaxNjPBNSUkyexg bj4eH0aura6y6U/CwMjY1QwkUA== X-Google-Smtp-Source: ABdhPJyB9KC8UZevH+Sx98y9vB4UxxmaPdSUazxsZTy8qVbjNhFrtC7ZZWIl6JrzQLmpdsRvrWpbAQ== X-Received: by 2002:a05:620a:5bb:: with SMTP id q27mr2342738qkq.253.1625666316593; Wed, 07 Jul 2021 06:58:36 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-5120-5dda-66b4-5098.res6.spectrum.com. [2603:6081:7b01:cbda:5120:5dda:66b4:5098]) by smtp.gmail.com with ESMTPSA id x14sm4252380qtv.17.2021.07.07.06.58.35 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 07 Jul 2021 06:58:36 -0700 (PDT) Date: Wed, 7 Jul 2021 09:58:34 -0400 From: Tom Rini To: Wolfgang Denk Cc: Sean Anderson , Simon Glass , U-Boot Mailing List , Marek =?iso-8859-1?Q?Beh=FAn?= , Roland Gaudig , Heinrich Schuchardt , Kostas Michalopoulos Subject: Re: [RFC PATCH 05/28] cli: lil: Rename some functions to be more like TCL Message-ID: <20210707135834.GV9516@bill-the-cat> References: <20210701061611.957918-1-seanga2@gmail.com> <20210701061611.957918-6-seanga2@gmail.com> <163753.1625507898@gemini.denx.de> <20210705185141.GA9516@bill-the-cat> <192285.1625557976@gemini.denx.de> <20210706153327.GS9516@bill-the-cat> <49463.1625645773@gemini.denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XQgEk5/GahrkJ03J" Content-Disposition: inline In-Reply-To: <49463.1625645773@gemini.denx.de> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --XQgEk5/GahrkJ03J Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 07, 2021 at 10:16:13AM +0200, Wolfgang Denk wrote: > Dear Tom, >=20 > In message <20210706153327.GS9516@bill-the-cat> you wrote: > >=20 > > > Mature? And still without consequent error checking? And done, > > > i. e. this will never be fixed? > > > > Intentional design by upstream, and then for the actual problem part > > (error checking, test suite), Sean is saying he'll fix it, and has > > started on it. >=20 > Seriously - any piece of software that omits error checking > intentionally be design should be indented six feet downward and > covered with dirt. We should not even consider looking at it. >=20 > > OK, snark aside, I'm very serious here, any "we'll just import ..." > > needs to have a plan to keep it up to date, or be easy enough to do such > > that I can set a monthly reminder to check for and do the update. Every > > area where we don't do this is a set of problems waiting to get worse, > > as we can see with the hush shell right now as it's one of the oldest > > things we stopped syncing with. >=20 > Which exact _new_ problems do we see with hush right now? I can > only see old ones, that have been known (and worked around) for > nearly two decades. >=20 > The limitations and bugs have all been there since the beginning - > the limitations actually being intentional due to the typical > resource situation at that time. There's all of the new features that've been suggested for our current hush, many by Sean, for which the reply has been "our hush is old, it should be updated!". And you didn't address my point, taking code from another project requires dedicated maintenance to keep it up to date and we do have a lot of in-tree examples right now of where that lack of dedicated maintenance is a problem. > > But I > > really think we want a shell environment that is not actively adding new > > features is a good thing, for the default. Just how much stuff should > > we be doing or need to be doing before we hand things over to the OS? >=20 > You are shooting yourself in the knee here. >=20 > If you think out CLI should not be adding new features, then we > should just stick with our ancient hush and neither update it nor > replace it with something else that adds not only new features, but > breaks backward compatibility, hard. Honestly, adding new features to the CLI (which is NOT the same as adding new commands, or enhancing existing commands) is very low on my priority list. We need to get the Kconfig migration done. We need to get DM migration done (which will help with the Kconfig one by showing hardware no one cares for anymore, and reducing symbols). We need to make adding new hardware easier. We need to get DTS files in-sync more often. There are very important developer use cases for a more flexible CLI interpreter. But the main use case is still "boot the (redundant) OS ASAP". So, what is my priority on this series right here? Well, a developer has posted a series. They believe it's useful and addressing a long-standing problem. They want feedback. I'm trying to provide feedback as it's to a general area of the codebase. --=20 Tom --XQgEk5/GahrkJ03J Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDlswkACgkQFHw5/5Y0 tyxqkwv+IMduAiYzeX0O3bIvnrAqXElCZPmunJopN/S8X6XpTfntH95qzX9PAPZz 7D2Ns32PzfcIKyz0LjXfPolxnBgFoVBdSb/NxmqLaLQQWQIhy11EfcJlFO6ESC+5 7HT8LGMrbMaq8WBX4hYB4k1zx7zXXG/OwgkKwmcv3dv/rMpuGbVz5qVsR74XC63a W18EOIjQYFgmjUlhKjF2OWVjLaWQLYRdp6rJtRQdWxxfHq/ByQNTOqdmAJ5GhNUm J5fpN3ZsUWTz/DTT2K0vnYgAR71wTYAKZ0cTyXvfcisP1Zh7mBfwdXWUv9HNWy9V BSo0RPaQsTYs7YMeYI92EBrT03KHLMt0OEhhdslIjf7QHwLf+ZztRuiNR/PQXxzU 7hk7ymyA29h0vnJH+RXDzGcR2RAtswIFUNVmILPmRDSPeTPlTzRa5qSbEUK1+mfQ yHzTZqraWYrH09IgTWigEzksz15xybkH6oq3BrQ+84ondLyBPYGdh2kpScMlN+rO DJiRWNo2 =VfjD -----END PGP SIGNATURE----- --XQgEk5/GahrkJ03J--