From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C021C07E96 for ; Thu, 8 Jul 2021 11:03:24 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 104DD61949 for ; Thu, 8 Jul 2021 11:03:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 104DD61949 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0140682E98; Thu, 8 Jul 2021 13:03:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=suse.com header.i=@suse.com header.b="A6trjBt7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1AEDE82F0C; Thu, 8 Jul 2021 10:23:15 +0200 (CEST) Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2E5ED82ED4 for ; Thu, 8 Jul 2021 10:23:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=mchang@suse.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1625732591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AXzspJDSZCFRgrPPknvRDzcVAWatbAEdrseq2gis6lc=; b=A6trjBt7pl6pZobpWHbhoI0+ygXZ7lyiswUt8aFq3kKtKZ5bD4UQOg9AtlTARtlfjiZwwS 5mNaH8f3eiMOPwQiL7eRE/G9D62+ncQz6PMZAeaMmAQL9I2eh0EM0uixTUVVNwriFz5mjc XlKKLn9LsUth1FShAuFyGIALgGXVDMw= Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01lp2056.outbound.protection.outlook.com [104.47.2.56]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-29-foR6FfM0OcO2WIEhov8XlQ-1; Thu, 08 Jul 2021 10:23:10 +0200 X-MC-Unique: foR6FfM0OcO2WIEhov8XlQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LqnxIIAFTrg0YStDW6cw3SMq1m3oww9Z8BdVE0DyZX2NzAKiWJ8qJED/rJRRV7vFutW1tiTyfC+Lim+tZrezgbTTNeEZwJtF8kRgteIK0xCvvInSOgZdBGF5Cx0A6DAmf+PHxZEyXBaCkBrPl41hQ+Za2hEwo+143T6GFfCr6ykIO7hRzGH/H0dmaGCTA+e20tMWTRhJQkVV/6alWF0AFhVClKdcG52iA6jT2Z/7cvoOFVypzJy8nvXKKc+QjAANEGTAuyALVDOx0XimM9QhohpoZm/CzGYXDmzNrE+mXaDNTX+z1Zjc5NyecPdse3glFUEGeeflVGeqzmZ4iZ66/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yDBEjpSd7V7iaOoYSWHnN8+G4IlvnkRIrZpEaR6jouE=; b=O+skvXlgkA/pgDSbTL2Xx0o/s3o7OajGfp5Zo0DEpS1Y5rKUPN32AQQEtJLY8K5uENfYlEZ2QJCi4O2Xa3xWZ25UTnQQJCz128LuMudoOPWWb5jpntDcTt1GGRVTOGP9JGc7fIUpGIX5Uw/p0ANT3HW6rneuNBCIpGaDtlWTrgZn7sGM+61mQL1TbvPCcl0aKa7MPJpwtFIsOhs4dlApyWR4k+G2aLUGDZotmYy5j9G2z9cNmHiJkALko71JFnpqWLpjG3Yi9vA4EzsQ8UjuV7elXPIiHe3JpIKhqcVdN/rCNDYOBbSd8WaDSwAEI3937i76TumhYzZA0iB/h8GCrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8648.eurprd04.prod.outlook.com (2603:10a6:10:2df::21) by DU2PR04MB8951.eurprd04.prod.outlook.com (2603:10a6:10:2e2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.22; Thu, 8 Jul 2021 08:23:10 +0000 Received: from DU2PR04MB8648.eurprd04.prod.outlook.com ([fe80::245b:a7da:fcc:25a1]) by DU2PR04MB8648.eurprd04.prod.outlook.com ([fe80::245b:a7da:fcc:25a1%4]) with mapi id 15.20.4287.035; Thu, 8 Jul 2021 08:23:10 +0000 From: Michael Chang To: u-boot@lists.denx.de, Alexander Graf , Heinrich Schuchardt CC: Matthias Brugger Subject: [PATCH] Disable timer check in file loading Date: Thu, 8 Jul 2021 16:22:50 +0800 Message-ID: <20210708082250.11833-1-mchang@suse.com> X-Mailer: git-send-email 2.26.2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-ClientProxiedBy: HK2PR02CA0196.apcprd02.prod.outlook.com (2603:1096:201:21::32) To DU2PR04MB8648.eurprd04.prod.outlook.com (2603:10a6:10:2df::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost (36.226.47.79) by HK2PR02CA0196.apcprd02.prod.outlook.com (2603:1096:201:21::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.20 via Frontend Transport; Thu, 8 Jul 2021 08:23:09 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ad373bf6-7388-466b-f9f0-08d941e99efb X-MS-TrafficTypeDiagnostic: DU2PR04MB8951: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bbiV6LU1szPsANSPbLy9RTY8ZOLiaY3aSsLdNkL2rdC7aFIlF4vnhHYnqWXAgFwPEaHJqVBRXtbARf8NI04FYqiZPz4WED/Yjtrxv+V58v6h01bqj+MnvZWoa8XhvCWlSZrmMCgWXNMvWEHBbdLROQcpULzUrPPQBr1iJwn+HjzSlQAuYeETiQHJN7Ge4+3y1jBuRJjKAEKP8D+i+13kd5v1h6As6ZouqAdk9GnLM1d9UwFeVkXW69TcCmjZuLApX7g1ygIvpWrlbPrX6dbPbxJaKZWkW2sUCMKOfC/4P7dhptSsgyDzvddXYdZeDsHtKxpdYPLUYcozyWOWFv/kbpAQqEwRV2ZkqlJ+dYnLPAwHliYjgyd5cSVBgdrQRa2LZz8cGTOEpCu4kkMvfqrpwuFf34Bech96wVvDUJB8BaoZS8aU3p49PoPZgu2MnY/3UZV8iC+92vOZ6Y91Ez8NglVZ2ebU6CS198mQzQX0QTAUiS+aqOwdX3G4TW/XeUIpj7dG/lbtqn1frqeGAA+kYeInpFWHGaMFM+Q/stDjJIcAvZjAtJEUjMyAr0XSyoiQeJuq+v5A2FabdNGsWsMGJbX9KEAUTa9rSafwXfhmux0FI3j5hYAWofnRMTNIFZm4bogbrBoaNNA5dOWcZB385oCh/RnYjMt1Fe525TJSIxcbvHEaCTXSWvvj2/8LFR6XXbSBxicee+CeRPM90H0aKRLBm+aoEis2H8GtSX1jEps= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU2PR04MB8648.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(366004)(376002)(39840400004)(396003)(136003)(6496006)(6666004)(66946007)(186003)(36756003)(26005)(38100700002)(956004)(2906002)(2616005)(8676002)(4326008)(66476007)(66556008)(83380400001)(8936002)(316002)(110136005)(86362001)(5660300002)(6486002)(478600001)(1076003)(966005)(107886003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+Wez0fPWgovWkU8iUnpFVAjxI6l9LVf2hXeL+MQVPNiKwaQ8z9d/St2Lo3Tu?= =?us-ascii?Q?L25ZeuI/exbEcvru89DDkNOMnADcgN+ZH7moEKevdeqXD4OO5vYZi+8Mm62d?= =?us-ascii?Q?wOA3oTbUd5N9v1zIe05UYSGcNq2oEHGXiiRqQV5Zkuv4B8QO5rK3jxlspoCF?= =?us-ascii?Q?XlmFeFlPALMq2/2Ina9JCxW12z41/zKQ8342WIrGL+oMkSE2JZiLTnjM25+7?= =?us-ascii?Q?kDbpQ6wDUF50JswpGENSMAje1hfaC004JbGphxpLfYu4w8zul2ESoYSz+uUG?= =?us-ascii?Q?xoFwudTZEdYUFDrOQwW0zIah/ncll5+jGcP4/kEWNdupX4+dRbEOT5F/FOZx?= =?us-ascii?Q?gSvb9enGrk2+BVj1xTVzCmOx4ycUVr61rUuxjxqedTg+7hsn2GNiJzxpTaHC?= =?us-ascii?Q?L9ldZt6kYJ4wfdFX7xDu77ff37+D9jKwq0sXKiVq96wwdVsqdwsT0G1A4Im3?= =?us-ascii?Q?v8kG4U+Yp+3urm6K307AVoTwcaUKQq659GGDSqOnUIV+4uQgqklEmSegmk7r?= =?us-ascii?Q?NQLAv7NrpnXF1Lui3wd8VHn88BFTiUrmidmskoB3HhzFfcUwSZr0Z+72atFU?= =?us-ascii?Q?ZEHvlMOU2y8wz99EO4lg/QtsdOpk5OJEvXXK53FLDo4QHwXNpHfMvYM68MsP?= =?us-ascii?Q?8JdTIUFa8I7VZMa9oqWDr3I0yHpzZx5D09xnoSsMtG6dRYg3Q4RZvB5lNglU?= =?us-ascii?Q?JnykxitcOGD0RmwzWcruNFjzjymYlSYRsz4yyvJcs10dk/VvbykEmFP+furA?= =?us-ascii?Q?ZYHUVm6aiftGEahTaBdHD++l3aUiUGEKnrKm1jdhuiPwFbHVjpHQkV+I+njl?= =?us-ascii?Q?/4HFr5zpU73Vt96vcXeoM3m223dJhCon4jyuO7dunloUgdsWZfQWJLIRATQd?= =?us-ascii?Q?Ivdr8mezhqU9+WF29ly6rOTUVgMZWZLft7j3H1w7ZjWa+faclL0dGxHXCOsK?= =?us-ascii?Q?i56steike4U2atR1vRFXxxfbCu8TqT4dQmfRjKq6xsK5K203gMC8qQg34Dde?= =?us-ascii?Q?6AFsfqi5uC0/kAcHPmEvjdIuwWS187DM4B7OcMqS49vheihDomsnq4QgLG6m?= =?us-ascii?Q?JyBy4mAnjJTff4vft3df+cuVL2DDSeSGV1j+lYF7o/kRfX+L7vIiqXkzCGii?= =?us-ascii?Q?/Jfs4G9cq6N/2n8Mf8lUcjevayLYT8Q6mPxEZadtaxcADnLsLCtcSYa+wsVR?= =?us-ascii?Q?+jsMDTYsnAWmdEl7746K4IWgC9YlAsAZCp/Te0mxoi2/0thT17tqXXfYbNyM?= =?us-ascii?Q?H3WCOHG373A5FZyGv8ikGSoDXEFvofKerG4p3ueXs1DTScT098RaPmRT/mSu?= =?us-ascii?Q?eFUHT9R4+MlnXNkKrWAoOBtV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad373bf6-7388-466b-f9f0-08d941e99efb X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8648.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2021 08:23:10.1050 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bTkI/c1uvza+XmhLrAb3wCT0y9wk4UdXL3psb38V1zWlaSqcIngLnq5p9njb/QUm X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8951 X-Mailman-Approved-At: Thu, 08 Jul 2021 13:03:20 +0200 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean The u-boot efi console service registers a timer to poll the keyboard input in every 50ns. In the efi block io service, this timer is evaluated on each block read, and since the timer interval is much less than the time needed to reading out a block (32kB) from the disk, the keyboard polling is therefore in the wake of each block read. Unfortunately USB keyboard spends too much time in polling. In my test usb_kbd_poll_for_event costs 40ms in usb_kbd_testc() to test if a character is in the queue. In combination with the number of blocks to be read from the disk, the extra amound of time delayed could be around 30 seconds to load linux and initrd. For that matters, the timer check is disabled in file loading to speed it up. The consequence would be losing the keystroke during the time file is loading, but that is acceptable IMHO. Downstream bug reference: https://bugzilla.suse.com/show_bug.cgi?id=3D1171222 Signed-off-by: Michael Chang --- lib/efi_loader/efi_disk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/efi_loader/efi_disk.c b/lib/efi_loader/efi_disk.c index 307d5d759b..d090110b06 100644 --- a/lib/efi_loader/efi_disk.c +++ b/lib/efi_loader/efi_disk.c @@ -15,6 +15,7 @@ #include #include #include +#include =20 struct efi_system_partition efi_system_partition; =20 @@ -103,8 +104,7 @@ static efi_status_t efi_disk_rw_blocks(struct efi_block= _io *this, else n =3D blk_dwrite(desc, lba, blocks, buffer); =20 - /* We don't do interrupts, so check for timers cooperatively */ - efi_timer_check(); + WATCHDOG_RESET(); =20 EFI_PRINT("n=3D%lx blocks=3D%x\n", n, blocks); =20 --=20 2.26.2