Re: [PATCH 3/6] dts: synquacer: Add partition information to the spi-nor

["Marek Behún" <marek.behun@nic.cz>]

On Fri,  9 Jul 2021 19:50:27 +0900
Masami Hiramatsu <masami.hiramatsu@linaro.org> wrote:

> Add partition information to the spi-nor flash.
> This is required for accessing NOR flash via mtdparts.
> 
> Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>
> ---
>  .../dts/synquacer-sc2a11-developerbox-u-boot.dtsi  |   42
> ++++++++++++++++++++ 1 file changed, 42 insertions(+)
> 
> diff --git a/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi
> b/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi index
> 2f13a42235..245ebcda01 100644 ---
> a/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi +++
> b/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi @@ -31,6
> +31,48 @@ spi-max-frequency = <31250000>;
>  			spi-rx-bus-width = <0x1>;
>  			spi-tx-bus-width = <0x1>;
> +
> +			partitions {
> +				compatible = "fixed-partitions";
> +				#address-cells = <1>;
> +				#size-cells = <1>;
> +
> +				partition@0 {
> +					label = "BootStrap-BL1";
> +					reg = <0x0 0x70000>;
> +					read-only;
> +				};
> +				partition@70000 {
> +					label = "Flash-Writer";
> +					reg = <0x70000 0x90000>;
> +					read-only;
> +				};
> +				partition@100000 {
> +					label = "SCP-BL2";
> +					reg = <0x100000 0x80000>;
> +					read-only;
> +				};
> +				partition@180000 {
> +					label = "FIP-TFA";
> +					reg = <0x180000 0x78000>;
> +				};
> +				partition@1f8000 {
> +					label = "Stage2Tables";
> +					reg = <0x1f8000 0x8000>;
> +				};
> +				partition@200000 {
> +					label = "U-Boot";
> +					reg = <0x200000 0x100000>;
> +				};
> +				partition@300000 {
> +					label = "UBoot-Env";
> +					reg = <0x300000 0x100000>;
> +				};
> +				partition@500000 {
> +					label = "Ex-OPTEE";
> +					reg = <0x500000 0x200000>;
> +				};
> +			};
>  		};
>  	};
>  
> 

Just a style hint: the individual partition nodes should be IMO
separated by an additional newline character, i.e.:

				partition@0 {
					label = "BootStrap-BL1";
					reg = <0x0 0x70000>;
					read-only;
				};

				partition@70000 {
					label = "Flash-Writer";
					reg = <0x70000 0x90000>;
					read-only;
				};

				partition@100000 {
					label = "SCP-BL2";
					reg = <0x100000 0x80000>;
					read-only;
				};

Other than that:

Reviewed-by: Marek Behún <marek.behun@nic.cz>

Btw, did you test this? Does this work correctly with mtd command?