From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D736C07E99 for ; Fri, 9 Jul 2021 10:54:40 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5813613D1 for ; Fri, 9 Jul 2021 10:54:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5813613D1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nic.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EBC8E8328E; Fri, 9 Jul 2021 12:54:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=nic.cz header.i=@nic.cz header.b="QBVizY47"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id ABDB1832A1; Fri, 9 Jul 2021 12:54:36 +0200 (CEST) Received: from mail.nic.cz (lists.nic.cz [IPv6:2001:1488:800:400::400]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2100583276 for ; Fri, 9 Jul 2021 12:54:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.behun@nic.cz Received: from dellmb (unknown [IPv6:2001:1488:fffe:6:8747:7254:5571:3010]) by mail.nic.cz (Postfix) with ESMTPSA id BFF581426D5; Fri, 9 Jul 2021 12:54:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1625828072; bh=xjA/c9WAvItec5FDVZ9vRvRAj9S0rFSxujrvwIOyLNY=; h=Date:From:To; b=QBVizY47cYIUFOtTbDwh6nzn6N9D8OlFF2QmbdOZ8PcE6ztJu/gpFD/iRGFgqzAGg dwleda/hUkZpkqsd1+n7+uX6r2+P4docGjAJxlbHyX7qSpHC5yEKTW3OHv3lJVK1ob 8M5rm0S7IZZQ7vcprBzjhgGc0NKbdIwMlbn5/3lE= Date: Fri, 9 Jul 2021 12:54:32 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Masami Hiramatsu Cc: Simon Glass , Tom Rini , Heinrich Schuchardt , Jassi Brar , Ilias Apalodimas , Masahisa Kojima , Takahiro Akashi , u-boot@lists.denx.de Subject: Re: [PATCH 3/6] dts: synquacer: Add partition information to the spi-nor Message-ID: <20210709125432.3bec117f@dellmb> In-Reply-To: <162582782712.112250.6553338507843531908.stgit@localhost> References: <162582779750.112250.1804638357524349747.stgit@localhost> <162582782712.112250.6553338507843531908.stgit@localhost> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Fri, 9 Jul 2021 19:50:27 +0900 Masami Hiramatsu wrote: > Add partition information to the spi-nor flash. > This is required for accessing NOR flash via mtdparts. >=20 > Signed-off-by: Masami Hiramatsu > --- > .../dts/synquacer-sc2a11-developerbox-u-boot.dtsi | 42 > ++++++++++++++++++++ 1 file changed, 42 insertions(+) >=20 > diff --git a/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi > b/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi index > 2f13a42235..245ebcda01 100644 --- > a/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi +++ > b/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi @@ -31,6 > +31,48 @@ spi-max-frequency =3D <31250000>; > spi-rx-bus-width =3D <0x1>; > spi-tx-bus-width =3D <0x1>; > + > + partitions { > + compatible =3D "fixed-partitions"; > + #address-cells =3D <1>; > + #size-cells =3D <1>; > + > + partition@0 { > + label =3D "BootStrap-BL1"; > + reg =3D <0x0 0x70000>; > + read-only; > + }; > + partition@70000 { > + label =3D "Flash-Writer"; > + reg =3D <0x70000 0x90000>; > + read-only; > + }; > + partition@100000 { > + label =3D "SCP-BL2"; > + reg =3D <0x100000 0x80000>; > + read-only; > + }; > + partition@180000 { > + label =3D "FIP-TFA"; > + reg =3D <0x180000 0x78000>; > + }; > + partition@1f8000 { > + label =3D "Stage2Tables"; > + reg =3D <0x1f8000 0x8000>; > + }; > + partition@200000 { > + label =3D "U-Boot"; > + reg =3D <0x200000 0x100000>; > + }; > + partition@300000 { > + label =3D "UBoot-Env"; > + reg =3D <0x300000 0x100000>; > + }; > + partition@500000 { > + label =3D "Ex-OPTEE"; > + reg =3D <0x500000 0x200000>; > + }; > + }; > }; > }; > =20 >=20 Just a style hint: the individual partition nodes should be IMO separated by an additional newline character, i.e.: partition@0 { label =3D "BootStrap-BL1"; reg =3D <0x0 0x70000>; read-only; }; partition@70000 { label =3D "Flash-Writer"; reg =3D <0x70000 0x90000>; read-only; }; partition@100000 { label =3D "SCP-BL2"; reg =3D <0x100000 0x80000>; read-only; }; Other than that: Reviewed-by: Marek Beh=C3=BAn Btw, did you test this? Does this work correctly with mtd command?