public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Marek Behún" <marek.behun@nic.cz>
To: u-boot@lists.denx.de, Stefan Roese <sr@denx.de>
Cc: "Tom Rini" <trini@konsulko.com>, "Marek Vasut" <marex@denx.de>,
	"Jagan Teki" <jagan@amarulasolutions.com>,
	"Patrick Delaunay" <patrick.delaunay@foss.st.com>,
	"Pali Rohár" <pali@kernel.org>
Subject: Re: [PATCH u-boot-mvebu 1/2] arm: mvebu: turris_omnia: force 40 MHz speed on SPI NOR
Date: Fri, 9 Jul 2021 17:00:09 +0200	[thread overview]
Message-ID: <20210709170009.0154f192@dellmb> (raw)
In-Reply-To: <20210709145614.7529-1-marek.behun@nic.cz>

On Fri,  9 Jul 2021 16:56:13 +0200
Marek Behún <marek.behun@nic.cz> wrote:

> Commit e2e95e5e2542 ("spi: Update speed/mode on change") changed the
> boot time on Turris Omnia from ~2.3s to over 8s, due to SPL loading
> main U-Boot from SPI NOR at 1 MHz instead of 40 MHz.
> 
> This is because the SPL code passes the CONFIG_SF_DEFAULT_SPEED option
> to spi_flash_probe(), and with the above commit spi_flash_probe()
> starts prefering this parameter instead of the one specified in
> device-tree.
> 
> The proper solution here would probably be to fix the SF subsystem to
> prefer the frequency specified in the device-tree, if it is present,
> but I am not sure what else will be affected on other boards with
> such a change. So until then we need a more simple fix.
> 
> Since the CONFIG_SF_DEFAULT_SPEED option is used by the code, put the
> correct value there for Turris Omnia. Also put the correct value to
> CONFIG_SF_DEFAULT_MODE and use 40 MHz when reading environment.

BTW this change is currently needed even if the other series (making
use of BootROM code to load main U-Boot instead of SPL doing it) is
accepted: commit e2e95e5e2542 also changed the behavior of the
  sf read / sf update
command - it is slower since it operates at 1 MHz now instead of 40 MHz
as specified in the device-tree.

Marek

  parent reply	other threads:[~2021-07-09 15:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-09 14:56 [PATCH u-boot-mvebu 1/2] arm: mvebu: turris_omnia: force 40 MHz speed on SPI NOR Marek Behún
2021-07-09 14:56 ` [PATCH u-boot-mvebu 2/2] arm: mvebu: turris_{omnia, mox}: enable MTD command Marek Behún
2021-07-15  8:12   ` [PATCH u-boot-mvebu 2/2] arm: mvebu: turris_{omnia,mox}: " Stefan Roese
2021-07-09 15:00 ` Marek Behún [this message]
2021-07-09 16:21   ` [PATCH u-boot-mvebu 1/2] arm: mvebu: turris_omnia: force 40 MHz speed on SPI NOR Tom Rini
2021-07-15  8:12 ` Stefan Roese
2021-07-15 10:32 ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210709170009.0154f192@dellmb \
    --to=marek.behun@nic.cz \
    --cc=jagan@amarulasolutions.com \
    --cc=marex@denx.de \
    --cc=pali@kernel.org \
    --cc=patrick.delaunay@foss.st.com \
    --cc=sr@denx.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox