* [PATCH u-boot-mvebu] arm: mvebu: armada-3720: remove unused config option
@ 2021-07-09 15:27 Marek Behún
2021-07-09 15:31 ` Pali Rohár
2021-07-09 15:31 ` Marek Behún
0 siblings, 2 replies; 3+ messages in thread
From: Marek Behún @ 2021-07-09 15:27 UTC (permalink / raw)
To: Stefan Roese, u-boot; +Cc: Marek Behún, Pali Rohár
The config option CONFIG_DEBUG_UART_CLOCK is not used by Armada 3720's
serial driver (it wasn't even before the recent update of that driver).
Remove it.
Signed-off-by: Marek Behún <marek.behun@nic.cz>
Cc: Stefan Roese <sr@denx.de>
Cc: Pali Rohár <pali@kernel.org>
---
configs/mvebu_db-88f3720_defconfig | 1 -
configs/mvebu_espressobin-88f3720_defconfig | 1 -
configs/turris_mox_defconfig | 1 -
configs/uDPU_defconfig | 1 -
4 files changed, 4 deletions(-)
diff --git a/configs/mvebu_db-88f3720_defconfig b/configs/mvebu_db-88f3720_defconfig
index c9935da102..ff4668e837 100644
--- a/configs/mvebu_db-88f3720_defconfig
+++ b/configs/mvebu_db-88f3720_defconfig
@@ -11,7 +11,6 @@ CONFIG_ENV_SECT_SIZE=0x10000
CONFIG_DM_GPIO=y
CONFIG_DEFAULT_DEVICE_TREE="armada-3720-db"
CONFIG_DEBUG_UART_BASE=0xd0012000
-CONFIG_DEBUG_UART_CLOCK=25804800
CONFIG_DEBUG_UART=y
CONFIG_AHCI=y
CONFIG_DISTRO_DEFAULTS=y
diff --git a/configs/mvebu_espressobin-88f3720_defconfig b/configs/mvebu_espressobin-88f3720_defconfig
index 157a4b7cb2..dc199cfe50 100644
--- a/configs/mvebu_espressobin-88f3720_defconfig
+++ b/configs/mvebu_espressobin-88f3720_defconfig
@@ -11,7 +11,6 @@ CONFIG_ENV_SECT_SIZE=0x10000
CONFIG_DM_GPIO=y
CONFIG_DEFAULT_DEVICE_TREE="armada-3720-espressobin"
CONFIG_DEBUG_UART_BASE=0xd0012000
-CONFIG_DEBUG_UART_CLOCK=25804800
CONFIG_DEBUG_UART=y
CONFIG_AHCI=y
CONFIG_DISTRO_DEFAULTS=y
diff --git a/configs/turris_mox_defconfig b/configs/turris_mox_defconfig
index 2c6f4938db..b3458acb98 100644
--- a/configs/turris_mox_defconfig
+++ b/configs/turris_mox_defconfig
@@ -11,7 +11,6 @@ CONFIG_ENV_SECT_SIZE=0x10000
CONFIG_DM_GPIO=y
CONFIG_DEFAULT_DEVICE_TREE="armada-3720-turris-mox"
CONFIG_DEBUG_UART_BASE=0xd0012000
-CONFIG_DEBUG_UART_CLOCK=25804800
CONFIG_DEBUG_UART=y
CONFIG_OF_BOARD_FIXUP=y
CONFIG_DISTRO_DEFAULTS=y
diff --git a/configs/uDPU_defconfig b/configs/uDPU_defconfig
index cdf6b2274c..649248d74d 100644
--- a/configs/uDPU_defconfig
+++ b/configs/uDPU_defconfig
@@ -10,7 +10,6 @@ CONFIG_ENV_SECT_SIZE=0x10000
CONFIG_DM_GPIO=y
CONFIG_DEFAULT_DEVICE_TREE="armada-3720-uDPU"
CONFIG_DEBUG_UART_BASE=0xd0012000
-CONFIG_DEBUG_UART_CLOCK=25804800
CONFIG_DEBUG_UART=y
CONFIG_AHCI=y
CONFIG_DISTRO_DEFAULTS=y
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH u-boot-mvebu] arm: mvebu: armada-3720: remove unused config option
2021-07-09 15:27 [PATCH u-boot-mvebu] arm: mvebu: armada-3720: remove unused config option Marek Behún
@ 2021-07-09 15:31 ` Pali Rohár
2021-07-09 15:31 ` Marek Behún
1 sibling, 0 replies; 3+ messages in thread
From: Pali Rohár @ 2021-07-09 15:31 UTC (permalink / raw)
To: Marek Behún; +Cc: Stefan Roese, u-boot
On Friday 09 July 2021 17:27:02 Marek Behún wrote:
> The config option CONFIG_DEBUG_UART_CLOCK is not used by Armada 3720's
> serial driver (it wasn't even before the recent update of that driver).
>
> Remove it.
>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Pali Rohár <pali@kernel.org>
Reviewed-by: Pali Rohár <pali@kernel.org>
> ---
> configs/mvebu_db-88f3720_defconfig | 1 -
> configs/mvebu_espressobin-88f3720_defconfig | 1 -
> configs/turris_mox_defconfig | 1 -
> configs/uDPU_defconfig | 1 -
> 4 files changed, 4 deletions(-)
>
> diff --git a/configs/mvebu_db-88f3720_defconfig b/configs/mvebu_db-88f3720_defconfig
> index c9935da102..ff4668e837 100644
> --- a/configs/mvebu_db-88f3720_defconfig
> +++ b/configs/mvebu_db-88f3720_defconfig
> @@ -11,7 +11,6 @@ CONFIG_ENV_SECT_SIZE=0x10000
> CONFIG_DM_GPIO=y
> CONFIG_DEFAULT_DEVICE_TREE="armada-3720-db"
> CONFIG_DEBUG_UART_BASE=0xd0012000
> -CONFIG_DEBUG_UART_CLOCK=25804800
This value was even incorrect as base clock is 25 MHz (not 25.8048 MHz).
So it fine that unused and wrong value is going to be removed.
> CONFIG_DEBUG_UART=y
> CONFIG_AHCI=y
> CONFIG_DISTRO_DEFAULTS=y
> diff --git a/configs/mvebu_espressobin-88f3720_defconfig b/configs/mvebu_espressobin-88f3720_defconfig
> index 157a4b7cb2..dc199cfe50 100644
> --- a/configs/mvebu_espressobin-88f3720_defconfig
> +++ b/configs/mvebu_espressobin-88f3720_defconfig
> @@ -11,7 +11,6 @@ CONFIG_ENV_SECT_SIZE=0x10000
> CONFIG_DM_GPIO=y
> CONFIG_DEFAULT_DEVICE_TREE="armada-3720-espressobin"
> CONFIG_DEBUG_UART_BASE=0xd0012000
> -CONFIG_DEBUG_UART_CLOCK=25804800
> CONFIG_DEBUG_UART=y
> CONFIG_AHCI=y
> CONFIG_DISTRO_DEFAULTS=y
> diff --git a/configs/turris_mox_defconfig b/configs/turris_mox_defconfig
> index 2c6f4938db..b3458acb98 100644
> --- a/configs/turris_mox_defconfig
> +++ b/configs/turris_mox_defconfig
> @@ -11,7 +11,6 @@ CONFIG_ENV_SECT_SIZE=0x10000
> CONFIG_DM_GPIO=y
> CONFIG_DEFAULT_DEVICE_TREE="armada-3720-turris-mox"
> CONFIG_DEBUG_UART_BASE=0xd0012000
> -CONFIG_DEBUG_UART_CLOCK=25804800
> CONFIG_DEBUG_UART=y
> CONFIG_OF_BOARD_FIXUP=y
> CONFIG_DISTRO_DEFAULTS=y
> diff --git a/configs/uDPU_defconfig b/configs/uDPU_defconfig
> index cdf6b2274c..649248d74d 100644
> --- a/configs/uDPU_defconfig
> +++ b/configs/uDPU_defconfig
> @@ -10,7 +10,6 @@ CONFIG_ENV_SECT_SIZE=0x10000
> CONFIG_DM_GPIO=y
> CONFIG_DEFAULT_DEVICE_TREE="armada-3720-uDPU"
> CONFIG_DEBUG_UART_BASE=0xd0012000
> -CONFIG_DEBUG_UART_CLOCK=25804800
> CONFIG_DEBUG_UART=y
> CONFIG_AHCI=y
> CONFIG_DISTRO_DEFAULTS=y
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH u-boot-mvebu] arm: mvebu: armada-3720: remove unused config option
2021-07-09 15:27 [PATCH u-boot-mvebu] arm: mvebu: armada-3720: remove unused config option Marek Behún
2021-07-09 15:31 ` Pali Rohár
@ 2021-07-09 15:31 ` Marek Behún
1 sibling, 0 replies; 3+ messages in thread
From: Marek Behún @ 2021-07-09 15:31 UTC (permalink / raw)
To: Stefan Roese, u-boot; +Cc: Pali Rohár
Please ignore this. It seems that the option is needed, because it does
not have a default. A different way to solve this is needed. Will post
another patch.
Marek
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-09 15:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-09 15:27 [PATCH u-boot-mvebu] arm: mvebu: armada-3720: remove unused config option Marek Behún
2021-07-09 15:31 ` Pali Rohár
2021-07-09 15:31 ` Marek Behún
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox