From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04B12C07E95 for ; Sat, 10 Jul 2021 19:37:11 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 74761610EA for ; Sat, 10 Jul 2021 19:37:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74761610EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C85CE83331; Sat, 10 Jul 2021 21:35:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1625945729; bh=RyLiL8H9Te7VfF83NvIOZJq3Up+nQoFt157MqaONS7o=; h=From:To:Subject:In-reply-to:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From; b=Xu4Fy171mpWVb89q8slOIqSFmeyFPFTKzdDCfprsk93lHVnrT0uVezONoF7U/sVqC r6jSZajlB1jYUvkw85u2BGFDJUAKvItCEYrlZWxyMJRf+EzlmH5PxUFmvBUS8sN1HN Nb1ignhdN7vCNFc2cMf63tehLBPSsEwFgRqH5YoDxgGlyWGBN6ywcyFT378W9wSPEE O6J+zy0ymfXppgZSLwuwnl2LfAu3fHqf+Wslzkgi5RXZREhC41OuuEXxkFgA3bNmT8 EymfhKEPk2IKevN8rE0f8EHwxbgNUbJIccrCWiGYi2xVXtw+xQUSxc2SF8QOcyOX17 rc+z+cQv0Qbeg== Received: by phobos.denx.de (Postfix, from userid 109) id 1572D8331F; Sat, 10 Jul 2021 21:35:20 +0200 (CEST) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 626E283329 for ; Sat, 10 Jul 2021 21:35:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sbabic@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4GMgGs0yxlz1qyJj; Sat, 10 Jul 2021 21:35:17 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4GMgGs0pJkz1qwZV; Sat, 10 Jul 2021 21:35:17 +0200 (CEST) X-Amavis-Alert: BAD HEADER SECTION, Missing required header field: "Date" Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id OA0algI8ROIr; Sat, 10 Jul 2021 21:35:16 +0200 (CEST) Received: from papero (host-88-217-136-221.customer.m-online.net [88.217.136.221]) by mail.mnet-online.de (Postfix) with ESMTP; Sat, 10 Jul 2021 21:35:16 +0200 (CEST) From: sbabic@denx.de X-Patchwork-Submitter: Tim Harvey X-Patchwork-Id: 1499128 X-Patchwork-Delegate: sbabic@denx.de To: Tim Harvey ,u-boot@lists.denx.de Subject: [PATCH 2/9] net: fec: use device sequence vs index when fetching fec In-reply-to: <20210630235010.27536-3-tharvey@gateworks.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Message-Id: <20210710193520.1572D8331F@phobos.denx.de> Date: Sat, 10 Jul 2021 21:35:20 +0200 (CEST) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean > When using uclass_get_device* to get the FEC device we need to use > device sequence instead of index into UCLASS_ETH. In systems where for > example a I2C based DSA switch exists it will probe before the FEC > master and its ports will be registered first and have the first > indexes yet the FEC's sequence comes from the device-tree alias. > Take for example the imx8mm-venice-gw7901 board which has an i2c based > DSA switch: > u-boot=> net list > eth1 : lan1 00:0d:8d:aa:00:2f > eth2 : lan2 00:0d:8d:aa:00:30 > eth3 : lan3 00:0d:8d:aa:00:31 > eth4 : lan4 00:0d:8d:aa:00:32 > eth0 : ethernet@30be0000 00:0d:8d:aa:00:2e active > Thus in this case uclass_get_device(UCLASS_ETH, 0, &dev) returns lan1 > which is wrong but uclass_get_device_seq(UCLASS_ETH, 0, &dev) returns > ethernet@30be000 which is correct. > Signed-off-by: Tim Harvey > Reviewed-by: Ramon Fried Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de =====================================================================