Re: [PATCH v3 2/9] arm: dts: imx8mp: Add common u-boot dtsi

Simon Glass
2021-07-12T19:44:13Z

Hi Tim,

On Mon, 12 Jul 2021 at 10:42, Tim Harvey <tharvey@gateworks.com> wrote:
>
> On Sat, Jul 10, 2021 at 5:23 AM Heiko Schocher <hs@denx.de> wrote:
> >
> > Hello Tim,
> >
> > On 09.07.21 16:47, Tim Harvey wrote:
> > > On Wed, Jul 7, 2021 at 5:58 AM Teresa Remmet <t.remmet@phytec.de> wrote:
> > >>
> > >> Factor out the common node settings for dm-spl and dm-pre-reloc
> > >> and move them to imx8mp-u-boot.dtsi
> > >>
> > >> Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> > >> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> > >> Reviewed-by: Heiko Schocher <hs@denx.de>
> > >> ---
> > >> Changes in v3:
> > >> - Moved binman nodes to common imx8mp-u-boot.dtsi
> > >> Changes in v2:
> > >> - none
> > >>
> > >> arch/arm/dts/imx8mp-evk-u-boot.dtsi | 143 +----------------
> > >> .../imx8mp-phyboard-pollux-rdk-u-boot.dtsi | 39 +----
> > >> arch/arm/dts/imx8mp-u-boot.dtsi | 149 ++++++++++++++++++
> > >> 3 files changed, 153 insertions(+), 178 deletions(-)
> > >> create mode 100644 arch/arm/dts/imx8mp-u-boot.dtsi
> > >>
> <snip>
> > >>
> > >
> > > Teresa,
> > >
> > > I've noticed many of the imx8m boards migrating to using binman for
> > > image packaging.
> > >
> > > Doesn't this change from having a single flash.bin encompasing the SPL
> > > and U-Boot proper to having split files? I noticed that happened with
> > > imx8mm_evk for example when it switched to binman.
> >
> > Yes, but you can easy generate there a single image again.
> >
> > > What are the benefits to using binman?
> >
> > Beside the pros from binmal in general, I see the benefit in special
> > for imx8mp, that you can get all infos you need for signing the image
> > from within the image. No need to save some log output from U-Boot
> > build and parse this output ...
> >
>
> (+cc Simon)
>
> Heiko,
>
> And what are the pros from binman in general? I've read over
> tools/binman/binman.rst so I'm assuming you mean what is described
> there as benefits.
>
> How do you get all the details needed for signing the image from binman?
>
> If I make imx8mm_evk_defconfig which produces via binman flash.bin and
> u-boot.itb I get the following:
>
> $ ./tools/binman/binman ls -i flash.bin
> binman: Cannot find FDT map in image
> $ ./tools/binman/binman ls -i u-boot.itb
> binman: Cannot find FDT map in image

As the message says, you need an 'fdtmap' in the image:

fdtmap {
}:

>
> I would very much like to understand how to use binman to get the
> various offsets needed for signing an IMX image for use with HAB.

You should be able to add signing support to binman for your use case.
See for example how vblock.py works.

Regards,
Simon