From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C261C07E96 for ; Sun, 11 Jul 2021 22:29:47 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE8E160FE6 for ; Sun, 11 Jul 2021 22:29:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE8E160FE6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8CF2782C53; Mon, 12 Jul 2021 00:29:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 4614182C5F; Mon, 12 Jul 2021 00:29:42 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 1129382C3F for ; Mon, 12 Jul 2021 00:29:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4260C6D; Sun, 11 Jul 2021 15:29:38 -0700 (PDT) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9AAA03F766; Sun, 11 Jul 2021 15:29:37 -0700 (PDT) Date: Sun, 11 Jul 2021 23:29:06 +0100 From: Andre Przywara To: Peter Hoyes Cc: u-boot@lists.denx.de, Joe Hershberger , Ramon Fried Subject: Re: [PATCH] net: Use phys_addr_t for SMC net device addresses Message-ID: <20210711232906.1745967f@slackpad.fritz.box> In-Reply-To: <20210709095206.659825-1-peter.hoyes@arm.com> References: <20210709095206.659825-1-peter.hoyes@arm.com> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Fri, 9 Jul 2021 10:52:06 +0100 Peter Hoyes wrote: > From: Peter Hoyes > > Use same type as eth_device->iobase and support addresses greater > than INT_MAX. Indeed, a signed(!) int is really a poor choice for a base address. > Signed-off-by: Peter Hoyes Reviewed-by: Andre Przywara Cheers, Andre > --- > drivers/net/smc91111.c | 2 +- > drivers/net/smc911x.c | 2 +- > include/netdev.h | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/smc91111.c b/drivers/net/smc91111.c > index ec4e8e928c..61d7f3df69 100644 > --- a/drivers/net/smc91111.c > +++ b/drivers/net/smc91111.c > @@ -1269,7 +1269,7 @@ static void print_packet( byte * buf, int length ) > } > #endif > > -int smc91111_initialize(u8 dev_num, int base_addr) > +int smc91111_initialize(u8 dev_num, phys_addr_t base_addr) > { > struct smc91111_priv *priv; > struct eth_device *dev; > diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c > index 3afebee440..8f420261fa 100644 > --- a/drivers/net/smc911x.c > +++ b/drivers/net/smc911x.c > @@ -478,7 +478,7 @@ static int smc911x_recv(struct eth_device *dev) > return ret; > } > > -int smc911x_initialize(u8 dev_num, int base_addr) > +int smc911x_initialize(u8 dev_num, phys_addr_t base_addr) > { > struct smc911x_priv *priv; > int ret; > diff --git a/include/netdev.h b/include/netdev.h > index b960c42106..00a0993a83 100644 > --- a/include/netdev.h > +++ b/include/netdev.h > @@ -70,8 +70,8 @@ int rtl8169_initialize(struct bd_info *bis); > int scc_initialize(struct bd_info *bis); > int sh_eth_initialize(struct bd_info *bis); > int skge_initialize(struct bd_info *bis); > -int smc91111_initialize(u8 dev_num, int base_addr); > -int smc911x_initialize(u8 dev_num, int base_addr); > +int smc91111_initialize(u8 dev_num, phys_addr_t base_addr); > +int smc911x_initialize(u8 dev_num, phys_addr_t base_addr); > int uec_standard_init(struct bd_info *bis); > int uli526x_initialize(struct bd_info *bis); > int armada100_fec_register(unsigned long base_addr);