[PATCH] board: sifive: remove the command for setting serial number

[PATCH] board: sifive: remove the command for setting serial number

[Zong Li]

We wouldn't like to allow user to change the serial number, so remove
the command for changing serial number in EEPROM.

Signed-off-by: Zong Li <zong.li@sifive.com>
Suggested-by: David Abdurachmanov <david.abdurachmanov@sifive.com>
---
 .../unmatched/hifive-platform-i2c-eeprom.c    | 23 +------------------
 1 file changed, 1 insertion(+), 22 deletions(-)

diff --git a/board/sifive/unmatched/hifive-platform-i2c-eeprom.c b/board/sifive/unmatched/hifive-platform-i2c-eeprom.c
index a2151f15e0..ad2f3155d0 100644
--- a/board/sifive/unmatched/hifive-platform-i2c-eeprom.c
+++ b/board/sifive/unmatched/hifive-platform-i2c-eeprom.c
@@ -401,24 +401,6 @@ static void set_product_id(char *string)
 	update_crc();
 }
 
-/**
- * set_serial_number() - set the PCB serial number in the in-memory copy
- *
- * Set the board serial number in the in-memory EEPROM copy from the supplied
- * string argument, and update the CRC.
- */
-static void set_serial_number(char *string)
-{
-	if (strlen(string) > SERIAL_NUMBER_BYTES) {
-		printf("Serial number must not be greater than 16 bytes\n");
-		return;
-	}
-
-	memset(e.serial, 0, sizeof(e.serial));
-	strncpy((char *)e.serial, string, sizeof(e.serial));
-	update_crc();
-}
-
 /**
  * init_local_copy() - initialize the in-memory EEPROM copy
  *
@@ -468,10 +450,7 @@ int do_mac(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
 		return 0;
 	}
 
-	if (!strcmp(cmd, "serial_number")) {
-		set_serial_number(argv[2]);
-		return 0;
-	} else if (!strcmp(cmd, "manuf_test_status")) {
+	if (!strcmp(cmd, "manuf_test_status")) {
 		set_manuf_test_status(argv[2]);
 		return 0;
 	} else if (!strcmp(cmd, "mac_address")) {
-- 
2.31.1

Re: [PATCH] board: sifive: remove the command for setting serial number

[Leo Liang]

On Fri, Jul 09, 2021 at 04:26:35PM +0800, Zong Li wrote:
> We wouldn't like to allow user to change the serial number, so remove
> the command for changing serial number in EEPROM.
> 
> Signed-off-by: Zong Li <zong.li@sifive.com>
> Suggested-by: David Abdurachmanov <david.abdurachmanov@sifive.com>
> ---
>  .../unmatched/hifive-platform-i2c-eeprom.c    | 23 +------------------
>  1 file changed, 1 insertion(+), 22 deletions(-)

Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>