From: Tom Rini <trini@konsulko.com>
To: Marek Behun <marek.behun@nic.cz>
Cc: Jagan Teki <jagan@amarulasolutions.com>, u-boot@lists.denx.de
Subject: Re: non-DM SPI_FLASH removal?
Date: Mon, 12 Jul 2021 10:25:59 -0400 [thread overview]
Message-ID: <20210712142559.GS9516@bill-the-cat> (raw)
In-Reply-To: <20210712161510.5b92bc6f@thinkpad>
[-- Attachment #1: Type: text/plain, Size: 1312 bytes --]
On Mon, Jul 12, 2021 at 04:15:10PM +0200, Marek Behun wrote:
> On Mon, 12 Jul 2021 10:10:14 -0400
> Tom Rini <trini@konsulko.com> wrote:
>
> > On Mon, Jul 12, 2021 at 04:01:13PM +0200, Marek Behun wrote:
> >
> > > Tom,
> > >
> > > there are 16 boards left with CONFIG_SPI_FLASH
> > > (git grep CONFIG_SPI_FLASH=y)
> > > and Makefile says this was supposed to be deprecated in v2019.07.
> > >
> > > Are we going to remove them so that we can simplify the SPI subsystem?
> >
> > The warning is on CONFIG_SPI_FLASH without CONFIG_DM_SPI_FLASH and of
> > course outside of SPL. When I asked Jagan about this off-list last
> > month or so, he said everything had been migrated, and I couldn't make
> > any boards fail by making the migration warning in the makefile be an
> > error. I think that means that if you have SPI subsystem cleanups you
> > want to do / post, please do so, thanks!
> >
>
> None of the boards from
> git grep CONFIG_SPI_FLASH=y
> have CONFIG_DM_SPI_FLASH defined. These boards are not migrated.
Well, hunh. I guess I messed up my "find all of the boards that need
removing, for DM_SPI_FLASH" test. I see that warning popping up when I
build it locally, right now. Time to fire off a removal series then,
thanks for bringing this up!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-07-12 14:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 14:01 non-DM SPI_FLASH removal? Marek Behun
2021-07-12 14:10 ` Tom Rini
2021-07-12 14:15 ` Marek Behun
2021-07-12 14:25 ` Tom Rini [this message]
2021-07-12 14:11 ` Marek Behun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210712142559.GS9516@bill-the-cat \
--to=trini@konsulko.com \
--cc=jagan@amarulasolutions.com \
--cc=marek.behun@nic.cz \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox