Re: [PATCH 1/2] board: stemmy: Parse atags to get available memory

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]

On Wed, Jul 07, 2021 at 12:58:54PM +0200, Stephan Gerhold wrote:

> At the moment the "stemmy" board attempts to detect the RAM size with
> a simple memory test (get_ram_size()). Unfortunately, this does not work
> correctly for devices with 768 MiB RAM (e.g. Samsung Galaxy Ace 2
> (GT-I8160), "codina"). Reading/writing memory after the 768 MiB RAM
> succeeds but actually overwrites some earlier parts of the memory.
> 
> For U-Boot this does not result in any major problems, but on Linux
> this will eventually lead to strange crashes because of the memory
> corruption.
> 
> Since the "stemmy" U-Boot port is designed to be chainloaded from
> the original Samsung bootloader, the most reliable way to get the
> available amount of RAM is to look at the ATAGS passed by the Samsung
> bootloader. Fortunately, the header used to generate ATAGS in U-Boot
> (asm/setup.h) can also be easily used to parse them.
> 
> Also clarify and simplify stemmy.h a bit to make it more clear where
> some of the magic values in there are actually coming from.
> 
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]