From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_RED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CA14C636CA for ; Thu, 15 Jul 2021 22:24:33 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A854613C0 for ; Thu, 15 Jul 2021 22:24:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A854613C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 77F02829FC; Fri, 16 Jul 2021 00:24:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 31BBB82A29; Fri, 16 Jul 2021 00:24:27 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 5F2B380214 for ; Fri, 16 Jul 2021 00:24:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5B0DE31B; Thu, 15 Jul 2021 15:24:22 -0700 (PDT) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 846623F694; Thu, 15 Jul 2021 15:24:21 -0700 (PDT) Date: Thu, 15 Jul 2021 23:23:50 +0100 From: Andre Przywara To: Ivan Uvarov Cc: u-boot@lists.denx.de, Chen-Yu Tsai , Jagan Teki Subject: Re: [PATCH 1/2] arm: allwinner: r40: add pinmux settings for MMC3 and UARTs 2,4,5&7 Message-ID: <20210715232350.33ec3adc@slackpad.fritz.box> In-Reply-To: <20210715101900.992249-2-i.uvarov@cognitivepilot.com> References: <20210715101900.992249-1-i.uvarov@cognitivepilot.com> <20210715101900.992249-2-i.uvarov@cognitivepilot.com> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, 15 Jul 2021 13:18:59 +0300 Ivan Uvarov wrote: Hi Ivan, > The Forlinx OKA40i-C devboard makes use of UARTs 0,2,3,4,5 and 7 of the R40 > SoC, of which UART 0 is connected to an RS232 converter, UART 5 routed to > an RS485 converter, and the rest broken out directly via labeled headers. > The board also contains a micro-SD slot connected to SDC3. > > This patch adds settings to R40's pinmux node for those UARTs that were not > already mapped, which would allow us to make use of all available UARTs and > the micro-SD slot on this board in a further patch. > > The patch also adds the /omit-if-no-ref/ keyword to the existing nodes for > UART0 and UART3 for consistency. Please keep exactly to the files as committed to Linux. Just copy the file from v5.14-rc1 over, as you did before, on the last r40.dtsi update - and adjust the subject accordingly (update .dtsi ...). You can then mention what thing brings and why briefly in the commit message. > Signed-off-by: Ivan Uvarov > > 1 file changed, 43 insertions(+) Not sure where this line comes from, that's typically not part of the patch (but created by git on-the-fly, if needed). Cheers, Andre > > diff --git a/arch/arm/dts/sun8i-r40.dtsi b/arch/arm/dts/sun8i-r40.dtsi > index d5ad3b9efd..51031a0e59 100644 > --- a/arch/arm/dts/sun8i-r40.dtsi > +++ b/arch/arm/dts/sun8i-r40.dtsi > @@ -357,6 +357,8 @@ > clock-names = "ahb", "mmc"; > resets = <&ccu RST_BUS_MMC3>; > reset-names = "ahb"; > + pinctrl-0 = <&mmc3_pins>; > + pinctrl-names = "default"; > interrupts = ; > status = "disabled"; > #address-cells = <1>; > @@ -601,6 +603,14 @@ > bias-pull-up; > }; > > + mmc3_pins: mmc3-pins { > + pins = "PI4", "PI5", "PI6", > + "PI7", "PI8", "PI9"; > + function = "mmc3"; > + drive-strength = <30>; > + bias-pull-up; > + }; > + > /omit-if-no-ref/ > spi0_pc_pins: spi0-pc-pins { > pins = "PC0", "PC1", "PC2"; > @@ -631,20 +641,53 @@ > function = "spi1"; > }; > > + /omit-if-no-ref/ > uart0_pb_pins: uart0-pb-pins { > pins = "PB22", "PB23"; > function = "uart0"; > }; > > + /omit-if-no-ref/ > + uart2_pi_pins: uart2-pi-pins { > + pins = "PI18", "PI19"; > + function = "uart2"; > + }; > + > + /omit-if-no-ref/ > + uart2_rts_cts_pi_pins: uart2-rts-cts-pi-pins{ > + pins = "PI16", "PI17"; > + function = "uart2"; > + }; > + > + /omit-if-no-ref/ > uart3_pg_pins: uart3-pg-pins { > pins = "PG6", "PG7"; > function = "uart3"; > }; > > + /omit-if-no-ref/ > uart3_rts_cts_pg_pins: uart3-rts-cts-pg-pins { > pins = "PG8", "PG9"; > function = "uart3"; > }; > + > + /omit-if-no-ref/ > + uart4_pg_pins: uart4-pg-pins { > + pins = "PG10", "PG11"; > + function = "uart4"; > + }; > + > + /omit-if-no-ref/ > + uart5_ph_pins: uart5-ph-pins { > + pins = "PH6", "PH7"; > + function = "uart5"; > + }; > + > + /omit-if-no-ref/ > + uart7_pi_pins: uart7-pi-pins { > + pins = "PI20", "PI21"; > + function = "uart7"; > + }; > }; > > wdt: watchdog@1c20c90 {