From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8832C07E95 for ; Fri, 16 Jul 2021 15:53:06 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18D2B613F8 for ; Fri, 16 Jul 2021 15:53:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18D2B613F8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7BC2482F2D; Fri, 16 Jul 2021 17:52:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="NcrSC/0M"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DFAEE82C87; Fri, 16 Jul 2021 17:52:05 +0200 (CEST) Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 59AF382C47 for ; Fri, 16 Jul 2021 17:51:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82c.google.com with SMTP id r17so7413582qtp.5 for ; Fri, 16 Jul 2021 08:51:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=HOQKLcHWDVo7FeAw/10f32jBmAvR9hswvhrRDOHAidY=; b=NcrSC/0MbgiKGqY/FVWFgkmvU28ME52Cqt3Cxuu1hZfkXiNKO0gZTsHsCWyTsFe7TA FZvRs4QK67XsbnMKG4CR48kta4Pe742mMWwczPxL15uFAeRX+bkvmxiQSz+7vS9NPjp1 FjKZwV4bI2MYn6+kE27gKgpH+XPGwHZ1JUPMc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HOQKLcHWDVo7FeAw/10f32jBmAvR9hswvhrRDOHAidY=; b=XNtS7eFGddMocUOpMfx9A03N12+jHm/O1dZWLYlZnoSDeqydZMHAkbq77lhdEOoJj9 WNuObG92GdJb3MFI7EvimLcTP70Vrha7Wlom6iGjzXHG0+Nn41Qq93SGBDTZsB/mTUL7 NMlI52zIsuay5ppXoUKxIzbrmvjdOzlgMQbEG+eXrTRToG6xrBGYg5iZZGGkjqG7KU7e GIA/BD1Dk+XH6t9z6BXbyDsTouamtabMthOklRK1A6iYfpS9CY5u5V5yRGm85mlCq2ZH 0+6h01hxm0OLXza0tQy/VuMFS9YUsPg5CbUPlTZSZob5U0CScGPGs7UN63tmkUCjr+Kp h5yA== X-Gm-Message-State: AOAM531HOXkDB8Ra+MFTw7MYhLm4a73fDW+bOkpkGck1egF5chTGGmoB 8AljFtcfboXOUqELvwAr4Nzzqw== X-Google-Smtp-Source: ABdhPJzC5uG49ERjiMNmpbZX1x54joRZSqkY/E4MC4eryzRmiyN1QQwWx1c+JwLkFoEazrQPz3R6ng== X-Received: by 2002:ac8:7f03:: with SMTP id f3mr1260703qtk.370.1626450717178; Fri, 16 Jul 2021 08:51:57 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-a8ce-b25c-3933-5c80.res6.spectrum.com. [2603:6081:7b01:cbda:a8ce:b25c:3933:5c80]) by smtp.gmail.com with ESMTPSA id j27sm4048745qkl.76.2021.07.16.08.51.56 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Jul 2021 08:51:56 -0700 (PDT) Date: Fri, 16 Jul 2021 11:51:54 -0400 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Stefan Reinauer Subject: Re: [PATCH v2 11/16] cbfs: Check offset range when reading a file Message-ID: <20210716155154.GP9379@bill-the-cat> References: <20210513193923.v2.1.I85633a7354c5b2ad5c55257607280392d069d70c@changeid> <20210514014011.2832707-9-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NDuspjMMC1Ui5ypn" Content-Disposition: inline In-Reply-To: <20210514014011.2832707-9-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --NDuspjMMC1Ui5ypn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, May 13, 2021 at 07:39:27PM -0600, Simon Glass wrote: > Add a check that the offset is within the allowed range. >=20 > Signed-off-by: Simon Glass > Reported-by: Coverity (CID: 331155) Applied to u-boot/master, thanks! --=20 Tom --NDuspjMMC1Ui5ypn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDxqxoACgkQFHw5/5Y0 tyyytQwAtyFmQmM1ODBB6ARqFtlAYh2XjMIgRL5d0sagEgEG8jF7l1tHOX6Jtv5W Vec8MqlhosmPGeJvlGkOLtCCRsu+42Klod0KtXIrgN3b0q/MZrLRyRLOX1sheqJt kBb8e4J+EtI2pbdE4kG4SmSqitrE0XmJR1t6DwLCHXLw3DMF8uQA6SxQwQQUCSTD TQ4cZ6O74INyl2upeYf4MHLg7sXH3iXxpqCLiSH17vUaA02wOdqK3KRX1w3pcRC7 UkRS/A3x+r6x8gsE3MWJB4JH/PwSfMKxEZ5OHIHUpGidDBFDPvQIvDBc6Wdkwe+J YHtHNKD5IbVdeAkrKzR5cTNRvdzzJZIqptdAdh7SSwNzJ3XjBxMBh5f7rv3A34lM derCt6OMi4YldzB2uOlWin/UpHl7HKc9VUaUww/c/MagAeZBcOGcDE2mFKj7R8W3 9PB54hXSWl8qQpe38tSa+TukEnVgzEfTlOPXzdnVx7bNM2DDL48mU9fZaPzCdl8m eeMfmC8M =C7OJ -----END PGP SIGNATURE----- --NDuspjMMC1Ui5ypn--