From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: sughosh.ganu@linaro.org, u-boot@lists.denx.de, agraf@csgraf.de
Subject: Re: [PATCH] efi_loader: capsule: remove unused guid
Date: Tue, 20 Jul 2021 11:05:33 +0900 [thread overview]
Message-ID: <20210720020533.GA77259@laputa> (raw)
In-Reply-To: <7433cde8-6560-daa8-1641-891b5c1400aa@gmx.de>
On Tue, May 18, 2021 at 10:32:28PM +0200, Heinrich Schuchardt wrote:
> On 5/10/21 10:20 AM, AKASHI Takahiro wrote:
> > EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID is never used.
> > Just remove it.
> >
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > ---
> > lib/efi_loader/efi_capsule.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/lib/efi_loader/efi_capsule.c b/lib/efi_loader/efi_capsule.c
> > index 84ddaf50d13f..b0dffd3ac9ce 100644
> > --- a/lib/efi_loader/efi_capsule.c
> > +++ b/lib/efi_loader/efi_capsule.c
> > @@ -208,9 +208,6 @@ skip:
> >
> > #if defined(CONFIG_EFI_CAPSULE_AUTHENTICATE)
> >
> > -const efi_guid_t efi_guid_capsule_root_cert_guid =
> > - EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID;
> > -
>
> I see multiple usages in origin/master. What am I missing?
What I intended to do is to "remove efi_guid_capsule_root_cert_guid,"
not EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID.
I will update the commit message.
-Takahiro Akashi
> $ git grep -n -B1 EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID
> include/efi_api.h-228-
> include/efi_api.h:229:#define EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID \
> --
> lib/efi_loader/efi_capsule.c-22-static const efi_guid_t
> efi_guid_firmware_management_capsule_id =
> lib/efi_loader/efi_capsule.c:23:
> EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID;
> --
> lib/efi_loader/efi_capsule.c-208-const efi_guid_t
> efi_guid_capsule_root_cert_guid =
> lib/efi_loader/efi_capsule.c:209:
> EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID;
> --
> tools/mkeficapsule.c-43-
> tools/mkeficapsule.c:44:efi_guid_t efi_guid_fm_capsule =
> EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID;
>
> Best regards
>
> Heinrich
>
> > #if defined(CONFIG_EFI_PKEY_DTB_EMBED)
> > int efi_get_public_key_data(void **pkey, efi_uintn_t *pkey_len)
> > {
> >
>
prev parent reply other threads:[~2021-07-20 2:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 8:20 [PATCH] efi_loader: capsule: remove unused guid AKASHI Takahiro
2021-05-18 20:32 ` Heinrich Schuchardt
2021-07-20 2:05 ` AKASHI Takahiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720020533.GA77259@laputa \
--to=takahiro.akashi@linaro.org \
--cc=agraf@csgraf.de \
--cc=sughosh.ganu@linaro.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox