From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47A83C07E95 for ; Tue, 20 Jul 2021 02:06:05 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55A94610D0 for ; Tue, 20 Jul 2021 02:06:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55A94610D0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6203C81BC0; Tue, 20 Jul 2021 04:06:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="IT/FEhEm"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C773281BDA; Tue, 20 Jul 2021 04:05:59 +0200 (CEST) Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D208B81280 for ; Tue, 20 Jul 2021 04:05:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pg1-x52c.google.com with SMTP id r21so2937654pgv.13 for ; Mon, 19 Jul 2021 19:05:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=7H9mzeQWR9TtRfQcxwjJRhy2OJMB4FgbzJMRG07/860=; b=IT/FEhEmaMyCCobRlWPZzaarXWuEgRPxrXwHPG4wzFYMqq45d0F9lqM6daqZ8W5lJB fg+K2RKmew2dM10O6LPGVgSW6TZ0a26c6vk9aFavySipXDuTiJt1biRgbbVoW6hadfHH ZOYZixgvNY+UQrQPkDhz0EGF/see/Y9UwHoRpWB2yItTUeZhJndprKba8JN+IRcqY2m1 sgiei7cSz5C9npckweCD5xVrslQpA5K1IiRnPgjLbI8zGxcc7Btc4ANFGLh8t6/7wfMQ 95M56/KZeZqrMMSF1m+5kfQS8uISfuKJIHEZhaOPQtXZeeKqn3FDuLqQ9OYF1Av1LAQf KeJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=7H9mzeQWR9TtRfQcxwjJRhy2OJMB4FgbzJMRG07/860=; b=WTklVQTVeqJv2/rQkBujg3JX62wVjAYRm7vmJVoPl4OsJq9tiBVn0lRs/5QFa8BaRr KcL/wA4x9jiokmXH2fCm+QPGVn0JQMFlk2TcfLvkuBn0U8X+Jdsqp82wA/9K+e2AHV+e /trmENAEFdIqI6dd8DOeAqUa2QOYuzDpaLJBOYzNNEzbKLUxLE+444nMjPk4ZaffGWBJ dAkpQDpEKAJLtNKDuiJx82FfdtVT2aIvK7IL/wUIGVBTbFGY4t3IcOu1fezySHtPPNSi SUmqDIkrZ5aS7CGfzu4kxRP+HxzPajJ+BM26v3WI1zXxkur1V3z+eZNckpHYodSypgco ADnw== X-Gm-Message-State: AOAM532MR7W1KtLohERmas/WJq8FCRYLyGp6adBjL2Ccf/ytM8qqerCY g1d63c3YykHU/WR05uI+n7p64g== X-Google-Smtp-Source: ABdhPJzTrIt1Xekw88B7lP1bAsQJoWQYmgAaEDH2z+QFiyJ62qP8rPbzCIa1XBa2VQObn1FDV4Bg0Q== X-Received: by 2002:aa7:80d3:0:b029:347:820c:fbf with SMTP id a19-20020aa780d30000b0290347820c0fbfmr8916425pfn.73.1626746754944; Mon, 19 Jul 2021 19:05:54 -0700 (PDT) Received: from laputa (p784a236a.tkyea130.ap.so-net.ne.jp. [120.74.35.106]) by smtp.gmail.com with ESMTPSA id m19sm21592189pfa.135.2021.07.19.19.05.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jul 2021 19:05:54 -0700 (PDT) Date: Tue, 20 Jul 2021 11:05:33 +0900 From: AKASHI Takahiro To: Heinrich Schuchardt Cc: sughosh.ganu@linaro.org, u-boot@lists.denx.de, agraf@csgraf.de Subject: Re: [PATCH] efi_loader: capsule: remove unused guid Message-ID: <20210720020533.GA77259@laputa> Mail-Followup-To: AKASHI Takahiro , Heinrich Schuchardt , sughosh.ganu@linaro.org, u-boot@lists.denx.de, agraf@csgraf.de References: <20210510082006.44049-1-takahiro.akashi@linaro.org> <7433cde8-6560-daa8-1641-891b5c1400aa@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7433cde8-6560-daa8-1641-891b5c1400aa@gmx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, May 18, 2021 at 10:32:28PM +0200, Heinrich Schuchardt wrote: > On 5/10/21 10:20 AM, AKASHI Takahiro wrote: > > EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID is never used. > > Just remove it. > > > > Signed-off-by: AKASHI Takahiro > > --- > > lib/efi_loader/efi_capsule.c | 3 --- > > 1 file changed, 3 deletions(-) > > > > diff --git a/lib/efi_loader/efi_capsule.c b/lib/efi_loader/efi_capsule.c > > index 84ddaf50d13f..b0dffd3ac9ce 100644 > > --- a/lib/efi_loader/efi_capsule.c > > +++ b/lib/efi_loader/efi_capsule.c > > @@ -208,9 +208,6 @@ skip: > > > > #if defined(CONFIG_EFI_CAPSULE_AUTHENTICATE) > > > > -const efi_guid_t efi_guid_capsule_root_cert_guid = > > - EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID; > > - > > I see multiple usages in origin/master. What am I missing? What I intended to do is to "remove efi_guid_capsule_root_cert_guid," not EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID. I will update the commit message. -Takahiro Akashi > $ git grep -n -B1 EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID > include/efi_api.h-228- > include/efi_api.h:229:#define EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID \ > -- > lib/efi_loader/efi_capsule.c-22-static const efi_guid_t > efi_guid_firmware_management_capsule_id = > lib/efi_loader/efi_capsule.c:23: > EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID; > -- > lib/efi_loader/efi_capsule.c-208-const efi_guid_t > efi_guid_capsule_root_cert_guid = > lib/efi_loader/efi_capsule.c:209: > EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID; > -- > tools/mkeficapsule.c-43- > tools/mkeficapsule.c:44:efi_guid_t efi_guid_fm_capsule = > EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID; > > Best regards > > Heinrich > > > #if defined(CONFIG_EFI_PKEY_DTB_EMBED) > > int efi_get_public_key_data(void **pkey, efi_uintn_t *pkey_len) > > { > > >