* [PATCH] efi_loader: capsule: remove unused guid
@ 2021-05-10 8:20 AKASHI Takahiro
2021-05-18 20:32 ` Heinrich Schuchardt
0 siblings, 1 reply; 3+ messages in thread
From: AKASHI Takahiro @ 2021-05-10 8:20 UTC (permalink / raw)
To: u-boot
EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID is never used.
Just remove it.
Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
---
lib/efi_loader/efi_capsule.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/efi_loader/efi_capsule.c b/lib/efi_loader/efi_capsule.c
index 84ddaf50d13f..b0dffd3ac9ce 100644
--- a/lib/efi_loader/efi_capsule.c
+++ b/lib/efi_loader/efi_capsule.c
@@ -208,9 +208,6 @@ skip:
#if defined(CONFIG_EFI_CAPSULE_AUTHENTICATE)
-const efi_guid_t efi_guid_capsule_root_cert_guid =
- EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID;
-
#if defined(CONFIG_EFI_PKEY_DTB_EMBED)
int efi_get_public_key_data(void **pkey, efi_uintn_t *pkey_len)
{
--
2.31.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] efi_loader: capsule: remove unused guid
2021-05-10 8:20 [PATCH] efi_loader: capsule: remove unused guid AKASHI Takahiro
@ 2021-05-18 20:32 ` Heinrich Schuchardt
2021-07-20 2:05 ` AKASHI Takahiro
0 siblings, 1 reply; 3+ messages in thread
From: Heinrich Schuchardt @ 2021-05-18 20:32 UTC (permalink / raw)
To: u-boot
On 5/10/21 10:20 AM, AKASHI Takahiro wrote:
> EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID is never used.
> Just remove it.
>
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
> lib/efi_loader/efi_capsule.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/lib/efi_loader/efi_capsule.c b/lib/efi_loader/efi_capsule.c
> index 84ddaf50d13f..b0dffd3ac9ce 100644
> --- a/lib/efi_loader/efi_capsule.c
> +++ b/lib/efi_loader/efi_capsule.c
> @@ -208,9 +208,6 @@ skip:
>
> #if defined(CONFIG_EFI_CAPSULE_AUTHENTICATE)
>
> -const efi_guid_t efi_guid_capsule_root_cert_guid =
> - EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID;
> -
I see multiple usages in origin/master. What am I missing?
$ git grep -n -B1 EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID
include/efi_api.h-228-
include/efi_api.h:229:#define EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID \
--
lib/efi_loader/efi_capsule.c-22-static const efi_guid_t
efi_guid_firmware_management_capsule_id =
lib/efi_loader/efi_capsule.c:23:
EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID;
--
lib/efi_loader/efi_capsule.c-208-const efi_guid_t
efi_guid_capsule_root_cert_guid =
lib/efi_loader/efi_capsule.c:209:
EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID;
--
tools/mkeficapsule.c-43-
tools/mkeficapsule.c:44:efi_guid_t efi_guid_fm_capsule =
EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID;
Best regards
Heinrich
> #if defined(CONFIG_EFI_PKEY_DTB_EMBED)
> int efi_get_public_key_data(void **pkey, efi_uintn_t *pkey_len)
> {
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] efi_loader: capsule: remove unused guid
2021-05-18 20:32 ` Heinrich Schuchardt
@ 2021-07-20 2:05 ` AKASHI Takahiro
0 siblings, 0 replies; 3+ messages in thread
From: AKASHI Takahiro @ 2021-07-20 2:05 UTC (permalink / raw)
To: Heinrich Schuchardt; +Cc: sughosh.ganu, u-boot, agraf
On Tue, May 18, 2021 at 10:32:28PM +0200, Heinrich Schuchardt wrote:
> On 5/10/21 10:20 AM, AKASHI Takahiro wrote:
> > EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID is never used.
> > Just remove it.
> >
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > ---
> > lib/efi_loader/efi_capsule.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/lib/efi_loader/efi_capsule.c b/lib/efi_loader/efi_capsule.c
> > index 84ddaf50d13f..b0dffd3ac9ce 100644
> > --- a/lib/efi_loader/efi_capsule.c
> > +++ b/lib/efi_loader/efi_capsule.c
> > @@ -208,9 +208,6 @@ skip:
> >
> > #if defined(CONFIG_EFI_CAPSULE_AUTHENTICATE)
> >
> > -const efi_guid_t efi_guid_capsule_root_cert_guid =
> > - EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID;
> > -
>
> I see multiple usages in origin/master. What am I missing?
What I intended to do is to "remove efi_guid_capsule_root_cert_guid,"
not EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID.
I will update the commit message.
-Takahiro Akashi
> $ git grep -n -B1 EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID
> include/efi_api.h-228-
> include/efi_api.h:229:#define EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID \
> --
> lib/efi_loader/efi_capsule.c-22-static const efi_guid_t
> efi_guid_firmware_management_capsule_id =
> lib/efi_loader/efi_capsule.c:23:
> EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID;
> --
> lib/efi_loader/efi_capsule.c-208-const efi_guid_t
> efi_guid_capsule_root_cert_guid =
> lib/efi_loader/efi_capsule.c:209:
> EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID;
> --
> tools/mkeficapsule.c-43-
> tools/mkeficapsule.c:44:efi_guid_t efi_guid_fm_capsule =
> EFI_FIRMWARE_MANAGEMENT_CAPSULE_ID_GUID;
>
> Best regards
>
> Heinrich
>
> > #if defined(CONFIG_EFI_PKEY_DTB_EMBED)
> > int efi_get_public_key_data(void **pkey, efi_uintn_t *pkey_len)
> > {
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-20 2:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-10 8:20 [PATCH] efi_loader: capsule: remove unused guid AKASHI Takahiro
2021-05-18 20:32 ` Heinrich Schuchardt
2021-07-20 2:05 ` AKASHI Takahiro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox