From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83507C07E95 for ; Tue, 20 Jul 2021 02:42:39 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 805DB6113C for ; Tue, 20 Jul 2021 02:42:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 805DB6113C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C5C7481BC8; Tue, 20 Jul 2021 04:42:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="DEpqejZf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D5C0E81BC8; Tue, 20 Jul 2021 04:42:33 +0200 (CEST) Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9422681280 for ; Tue, 20 Jul 2021 04:42:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pf1-x430.google.com with SMTP id d9so7179318pfv.4 for ; Mon, 19 Jul 2021 19:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=P2XyYQ+frSh5ybSRrWXC2tXQNe1FYeZNkaKcdAwAs30=; b=DEpqejZfoOWFyK3E3CilGraCuRtoSosQ7Y+IzJVGaciJcehVHWoIwhrCv6wC89AZq2 r21kcoV4Jide2Z1PNTyBWXtSNjSj7A12E62sKkcFXDUxC/+eKNdVa+A9S1YwlgXOsV54 9RAYcBCos1bltVHzCmt+zNQCYRp9veVFe2ZzwRF+wLvQgwrTBZoJD8XIbGqKsRYspRuW 51HguTRL24rP7aZ5dYkWD+Gfw1/Ju3QhaIYj/yFWY+pmV/PbR+NZSVPbWj4SS1nf+1n7 xQ5UeNaOmWZHkOteVmSL+SpnA5OuQfhI3ZLyElR/MYIHmWiH7M1sPhauW3m/lot29AQI j3aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=P2XyYQ+frSh5ybSRrWXC2tXQNe1FYeZNkaKcdAwAs30=; b=lQy9TaHDtHLFrsZfsruhojDVAJQTu8h6brBhX6FGKYGLNlgIKAgcKMpymghhwZvlOI c3oV75FsLJjKQMO2xdhT6NNZ8Fr5iZzQMo4NaMQ0LQcw02l8DHGyM1j3ndfeIZPKyTpM fyohxjSWtOGBvsfoKnwZ9cVt7rcNH5/KFA18bWL+1ptOKcy7wWmeVjNoSOAsOEz/KCE8 T3/NRgCWhc3TPuGOdpZJrpg8qnw0HPq7SBTHI+R3NYmPmHZQKFi07xzuGAtNroGhHIrV /BytiZmV1g2mTSr172+HzhWnphVTKMyrgXCh0b9FxIKGowNa28RFxy67vNJCLYCf4kS0 uIFA== X-Gm-Message-State: AOAM5324F260xhjTNTywzZSupllthJmSTwXNJgdLJL6dq0TxIVHFkWw1 qmMIzxUfmSLicPQrRWv8DAwUxw== X-Google-Smtp-Source: ABdhPJxlmfyzljEmaWcnSEiFk5T48BbP5sECX5Jwi22a3IBO3gu4UgTsgl/kOrrtLavD0Rzz776BJw== X-Received: by 2002:a63:1a12:: with SMTP id a18mr28226941pga.269.1626748948615; Mon, 19 Jul 2021 19:42:28 -0700 (PDT) Received: from laputa (p784a236a.tkyea130.ap.so-net.ne.jp. [120.74.35.106]) by smtp.gmail.com with ESMTPSA id a35sm8953595pgm.66.2021.07.19.19.42.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jul 2021 19:42:28 -0700 (PDT) Date: Tue, 20 Jul 2021 11:42:16 +0900 From: AKASHI Takahiro To: Heinrich Schuchardt Cc: u-boot@lists.denx.de, Alexander Graf , Sughosh Ganu Subject: Re: [PATCH] test/py: efi_capsule: aligned with efidebug syntax changes Message-ID: <20210720024216.GE77259@laputa> Mail-Followup-To: AKASHI Takahiro , Heinrich Schuchardt , u-boot@lists.denx.de, Alexander Graf , Sughosh Ganu References: <20210510082133.44225-1-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, May 20, 2021 at 05:14:36AM +0200, Heinrich Schuchardt wrote: > On 5/10/21 10:21 AM, AKASHI Takahiro wrote: > > In the subject: %s/aligned/align/ I think that the passive usage is grammatically correct here, but I can fix it if you like. > > After the commit c70f44817d46 ("efi_loader: simplify 'printenv -e'"), > > "-all" option is no longer necessary. > > Just remove them in the test script. > > 'env print -e -all Capsule0000' leads to an error CMD_RET_USAGE. > > Capsule0000 does not necessarily exist. Shouldn't we print CapsuleLast > and CapsuleMax and check their value instead? > > Shouldn't we restrict the output to EFI_CAPSULE_REPORT_GUID to be sure > that the GUID of these variables is correct? No. The whole aim of executing "env print -e" (or whatever else command) was to invoke efi_init_obj_list(), hence efi_launch_capsules(). We don't have to care whether it fails or not. In fact, this test case still works correctly even with "--all". So this patch is just a cleanup. I will repost it. -Takahiro Akashi > Best regards > > Heinrich > > > > > Fixes: c70f44817d46 ("efi_loader: simplify 'printenv -e'") > > Signed-off-by: AKASHI Takahiro > > --- > > test/py/tests/test_efi_capsule/test_capsule_firmware.py | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/test/py/tests/test_efi_capsule/test_capsule_firmware.py b/test/py/tests/test_efi_capsule/test_capsule_firmware.py > > index 4697ca6f1c5c..9eeaae27d626 100644 > > --- a/test/py/tests/test_efi_capsule/test_capsule_firmware.py > > +++ b/test/py/tests/test_efi_capsule/test_capsule_firmware.py > > @@ -85,7 +85,7 @@ class TestEfiCapsuleFirmwareFit(object): > > > > # need to run uefi command to initiate capsule handling > > output = u_boot_console.run_command( > > - 'env print -e -all Capsule0000') > > + 'env print -e Capsule0000') > > > > output = u_boot_console.run_command_list([ > > 'host bind 0 %s' % disk_img, > > @@ -160,7 +160,7 @@ class TestEfiCapsuleFirmwareFit(object): > > > > # need to run uefi command to initiate capsule handling > > output = u_boot_console.run_command( > > - 'env print -e -all Capsule0000') > > + 'env print -e Capsule0000') > > > > output = u_boot_console.run_command_list([ > > 'host bind 0 %s' % disk_img, > > @@ -227,7 +227,7 @@ class TestEfiCapsuleFirmwareFit(object): > > > > # need to run uefi command to initiate capsule handling > > output = u_boot_console.run_command( > > - 'env print -e -all Capsule0000') > > + 'env print -e Capsule0000') > > > > output = u_boot_console.run_command_list(['efidebug capsule esrt']) > > > > >