From: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
To: <u-boot@lists.denx.de>
Cc: <ryan_chen@aspeedtech.com>
Subject: [PATCH] reset: ast2600: Fix missing reference operator
Date: Tue, 20 Jul 2021 15:01:36 +0800 [thread overview]
Message-ID: <20210720070136.2387-1-chiawei_wang@aspeedtech.com> (raw)
Fix missing reference operator '&' to correctly get
HW register addresses for writel().
Signed-off-by: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
---
drivers/reset/reset-ast2600.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/reset/reset-ast2600.c b/drivers/reset/reset-ast2600.c
index f64adaf74e..195ddd18e0 100644
--- a/drivers/reset/reset-ast2600.c
+++ b/drivers/reset/reset-ast2600.c
@@ -41,9 +41,9 @@ static int ast2600_reset_assert(struct reset_ctl *reset_ctl)
debug("%s: reset_ctl->id: %lu\n", __func__, reset_ctl->id);
if (reset_ctl->id < 32)
- writel(BIT(reset_ctl->id), scu->modrst_ctrl1);
+ writel(BIT(reset_ctl->id), &scu->modrst_ctrl1);
else
- writel(BIT(reset_ctl->id - 32), scu->modrst_ctrl2);
+ writel(BIT(reset_ctl->id - 32), &scu->modrst_ctrl2);
return 0;
}
@@ -56,9 +56,9 @@ static int ast2600_reset_deassert(struct reset_ctl *reset_ctl)
debug("%s: reset_ctl->id: %lu\n", __func__, reset_ctl->id);
if (reset_ctl->id < 32)
- writel(BIT(reset_ctl->id), scu->modrst_clr1);
+ writel(BIT(reset_ctl->id), &scu->modrst_clr1);
else
- writel(BIT(reset_ctl->id - 32), scu->modrst_clr2);
+ writel(BIT(reset_ctl->id - 32), &scu->modrst_clr2);
return 0;
}
--
2.17.1
next reply other threads:[~2021-07-20 7:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 7:01 Chia-Wei Wang [this message]
2021-07-24 20:41 ` [PATCH] reset: ast2600: Fix missing reference operator Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210720070136.2387-1-chiawei_wang@aspeedtech.com \
--to=chiawei_wang@aspeedtech.com \
--cc=ryan_chen@aspeedtech.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox