From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1D29C07E95 for ; Tue, 20 Jul 2021 08:20:08 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 05DB86101B for ; Tue, 20 Jul 2021 08:20:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05DB86101B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sancloud.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1463082937; Tue, 20 Jul 2021 10:20:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sancloud.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=sancloud.onmicrosoft.com header.i=@sancloud.onmicrosoft.com header.b="J64epGdO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6131C82970; Tue, 20 Jul 2021 10:20:03 +0200 (CEST) Received: from GBR01-CWL-obe.outbound.protection.outlook.com (mail-cwlgbr01on0711.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe14::711]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 04F7381280 for ; Tue, 20 Jul 2021 10:20:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sancloud.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=paul.barker@sancloud.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e2xc00LxnrIXgpGUG6Sjw42JloJ005QsIyI3KxjyNs7XAZMmetW3pZeC9QpBHv6fV662wndq/nvouGp7xVaOKzjW3i6mU5CuiAoG9wYChJ8AX6ycVZpB+U9NViQ9ooyvBFwT+47iq/eVVzkJq49OH9Ufox6WhnDLx/As193Ogu97XCE4XrnNCB3mKTdGYhSfAidsg1Actvd3lEIGioRWb+b9n1QEhujwaOyx6j7QWJ6vs4d3jK6bqbBB4hZfgou7LLqUq9tEVm/sPwdClMp4N+0W9OOp6n0OHvswxPnbRtvuOy2AWijvQaxi+QK+V9uek23QO+5n8Y08pS1QrrMKPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nQzHgaznVJV4/XqUdutWjqOsjiOz6O65fi0hCbxRTFo=; b=B/ZEkEgeq26tWOGHOfU854R7rcKYx47VZf0jHIoE5Mof3QlKSPwlS/WYxGdVN3bG66uv6jqzjdNQaX+sbyzJKrRUu0hgfQJkF00YEW8qSJim2C5T9R5h7dh+fcXCLWoHQPh2Cwb97Y4k7w1KwetjeN4OLWnLZIi2MVgsEeYtnjMYRgMfSK2tENZVf8oaLWDZM/k2xZXRPitaf0NOqx4hWdmbLQBgL/2QSxsMOsChK/AJf3Wbrn9rySf1reGVGJ2dL2zomijMSi7zQT8I/cuvbpmh3kmRpFbyBOTrgkGdLoiIGRPgr4wcLgJkMfLeqjNzDaal28IEdenfmUJYwN9UQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sancloud.com; dmarc=pass action=none header.from=sancloud.com; dkim=pass header.d=sancloud.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sancloud.onmicrosoft.com; s=selector2-sancloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nQzHgaznVJV4/XqUdutWjqOsjiOz6O65fi0hCbxRTFo=; b=J64epGdOsmGhEpd6vC+FAQdpxHlpZEaGRkuOSI/QPE8caxTbU2nsqQ8Qyv5ozRRTBKnS+oD72CUxvIbXkvG1ZdRG2Ffk0k8XUe2HBkJL2YOpU6Wzn4jDmngtu0mubYAVMNQoITG1rf3E9ZrFqcf3A15zmUZCiENvL+Tz8bP/fR8= Authentication-Results: ti.com; dkim=none (message not signed) header.d=none;ti.com; dmarc=none action=none header.from=sancloud.com; Received: from CWLP123MB2241.GBRP123.PROD.OUTLOOK.COM (2603:10a6:401:61::19) by CWLP123MB3522.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:6f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21; Tue, 20 Jul 2021 08:19:57 +0000 Received: from CWLP123MB2241.GBRP123.PROD.OUTLOOK.COM ([fe80::dc2:e929:76be:a8b0]) by CWLP123MB2241.GBRP123.PROD.OUTLOOK.COM ([fe80::dc2:e929:76be:a8b0%7]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 08:19:57 +0000 Date: Tue, 20 Jul 2021 09:19:46 +0100 From: Paul Barker To: Lokesh Vutla Cc: Tom Rini , Peter Robinson , Subject: Re: [PATCH v2 5/5] configs: am335x_evm: Fix BeagleBone Green DTB selection Message-ID: <20210720091946.1d4e94f7.paul.barker@sancloud.com> In-Reply-To: References: <20210712201412.13306-1-paul.barker@sancloud.com> <20210712201412.13306-6-paul.barker@sancloud.com> Organization: SanCloud Ltd X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-suse-linux-gnu) Content-Type: multipart/signed; boundary="Sig_//bc=WNZk2/MwZbKoJnTmhHL"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-ClientProxiedBy: LO2P265CA0022.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::34) To CWLP123MB2241.GBRP123.PROD.OUTLOOK.COM (2603:10a6:401:61::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from owl.home.b5net.uk (80.7.160.81) by LO2P265CA0022.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.23 via Frontend Transport; Tue, 20 Jul 2021 08:19:57 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5ce7efa3-68cd-408d-4f97-08d94b572914 X-MS-TrafficTypeDiagnostic: CWLP123MB3522: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IMaxG8kmz0hjT/LgPfg26TPYcDi9pLxFla7OYxBhVeLFrUnHsFpb9cS9HRMakR5kKVTdi7PqcoYYBz7ZIevkfYnIoUP2M+M88k5NFo74glVgt8ccSsp1475Ka0VNDrndserT9ZTSOc0yRT1jDOcCFWJYnh5fXvYQjx1jXHn7AafRYUk7Ew5jkHFObSsCJjcE9AFp920PGKF8tR+PXiqCcq/FzKSZEOBlQfYwIvGq3mrVXk1kwdyP0B6kKQJxskOf7U/4bIdKpq1c6cmKBfLjO+V9XsLHKBhkJoDZuHZX5uRZXo9Q/RL7A5vhcLyuVbTCNxwmZQokH8FXFKLYncv6uGtXYfXeuzE/FK5GBsKx7e6tjYlCFB/0ZbxtCccQT4cVzo/+hKUMlsSpc8dX25RQ3FfPyI28oEwoTWjGvF1c8Io/bmZtYw5N6/SSz3Eq4LluFx58C2JsvmMo8rL0uG8Iml1fOII2HpJnq5JvzIswRjCN+FI220VYSVIq10F9Swx7uBrTvGes+/UING0DlAELVRGZk4OuYeGhYob1ilIoT0FLWb3ujt2K6zP9dvsaq9cZ/Vp2YbTkcrfMv03Y/sevp4RTLt2KchQSVGbsYo70JrqVPuO+uaUnBXD/EMNbPdg9P+E1PU2GUECSAHOP1kkWPtpdWH/J5CFgVStWF5MYJLKS6zh3JzmTxwYHkfazFrhIOxVHFg9KS9xQBKee5yL4Zg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CWLP123MB2241.GBRP123.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(396003)(376002)(39830400003)(346002)(366004)(136003)(478600001)(2906002)(83380400001)(4326008)(38350700002)(53546011)(5660300002)(44832011)(38100700002)(1076003)(186003)(2616005)(956004)(316002)(26005)(54906003)(36756003)(6486002)(6666004)(6512007)(66476007)(86362001)(6916009)(66946007)(8676002)(36916002)(6506007)(52116002)(8936002)(103116003)(66556008); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nwTznRjt4NlwuZfuHAJdHF0rQp1P17wlZnRmvMpAql+7pdqw/LM/fyZjgSSh?= =?us-ascii?Q?Rxx/BlbXzmuo0/QoD3e30iZIZtzTz5ZE/DbCTjSTZQ/5dvYymlhcntjmVoUP?= =?us-ascii?Q?8o89A5IsosDOJgTyGv0z8TzyTy/BeJOoJcfZH9hCBqIXrUV9D04mZxo0xITO?= =?us-ascii?Q?irU0WuWrbePE/U21KNjiSqgsnmW8hKGEKrNCi/qGqKbvbDBG0oN63bnOi9/b?= =?us-ascii?Q?2wli64DzWTz+wQSI4JDJCSPovoDPmzs4fzSHnPn3ztUqr79nd9i3LM3hhCoz?= =?us-ascii?Q?cxyDAg9rr02ZQDVMV6RKVIb42tYLaAgzPUxIf8Y6JA7YHm+Iwe4ig6cp+A6Z?= =?us-ascii?Q?5PlbDaOrfid7hX8EKtjeOLPecuuRdiGRJcqT9i/Zr2mu3sOkXh8kw/V/iIfv?= =?us-ascii?Q?3j2nCtLyh6zoQc4muzQ5Cp8J4UjDkbFSEH7asz33FJB2h5qXIIxAZBLcKlVs?= =?us-ascii?Q?7WS4vfkPp47RssKGhNZ6z26lmMoMv1Pi2HMoolJ++D+X9zuTxgNgt62D7rur?= =?us-ascii?Q?cf8vVp5qyqty7qYR5FILeYxH7i8AqbX492vXXxEl3v6SFjPnLdv3mO5kUUUc?= =?us-ascii?Q?znmXodzyQTRHiKFZ0MN88qlEZCgPmnxPrSI5tRfLtO3tJ5JnYQOitPFgRl5h?= =?us-ascii?Q?HaI9UZX9rLUP3VygkEiPTmyddqya4NC/U3G5qUaNdmJmyqPts0LPfdTPAirV?= =?us-ascii?Q?eym7iG8NWRISE+dD252H2v9VHM+004gx0JVtPeF0xaF2XOWpRC8X6zyyihsv?= =?us-ascii?Q?xKrMJhjebf5PX3LdWwDbddR6clxpEGxVNQJUG38jqdXFWYvFh9d2ydgJmsM9?= =?us-ascii?Q?3VwwOWwYd9uMSxCxo/ka0/LE/P7K+pOuRRolFqAvYn/1BvkMY5BU+Ijm57rK?= =?us-ascii?Q?P7NP7KkGWixefTssGLtuvSiQZ5ZCF4QWKbvZVOzxzCaOVyudMscT2pbclMnw?= =?us-ascii?Q?uoE9RHZi5CEj8k1Rm02diYnIuD+cXANuLXL1faG/MxvENzOLxDtURcEv1InF?= =?us-ascii?Q?HJ9QlDM0+kgkEg9U8lLb7O73w9QCqHub0DXXV7ZnDtteIHOH4xswiMtuEkTL?= =?us-ascii?Q?bM8vP1yrei52tXxQoGSz3LfUDvHv98AssS3WsVS4Hxhsk3Z98QsUCgITczKb?= =?us-ascii?Q?jMVSGjIhaBB3/ldXnpta0WjR/H8fIUhTfBkdEQWs3TO/0l058/qj7n0t4DdP?= =?us-ascii?Q?r334mi+XcKdtgOdH6qEUt8FFpbC+h5fxnm15sQMIyX2QGbF5VaoSfjmI3+DB?= =?us-ascii?Q?T8rTewo/L4i+seJ68FpsG1jxgeJcaIlWsNi2NN34kfs/EXOcbx9cnC1soZ5c?= =?us-ascii?Q?H7vIhnfjx0I9jOKZFhP/8fjq?= X-OriginatorOrg: sancloud.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ce7efa3-68cd-408d-4f97-08d94b572914 X-MS-Exchange-CrossTenant-AuthSource: CWLP123MB2241.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2021 08:19:57.3880 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 840be37c-244a-450e-9bcc-2064862de1f4 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3EOi2jTEDqIQaK7Z2AB9d/31BGrVx7S65eXG9Hn7CDbs2THJ7EvLBcr+gxovS3WNGHKuH6SWdlo8/I6mFAoBNKCihcl5K1pKOEVhljBrXgs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP123MB3522 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --Sig_//bc=WNZk2/MwZbKoJnTmhHL Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 13 Jul 2021 11:59:06 +0530 Lokesh Vutla wrote: > On 13/07/21 1:44 am, Paul Barker wrote: > > The function board_is_bone_lt() returns true for the BeagleBone Green, > > the BeagleBone Enhanced and the BeagleBone Black. Therefore when > > selecting which devicetree to use we must ensure that the more specific > > functions board_is_bbg1() and board_is_bben() are checked first > > otherwise all three devices would end up using the am335x-boneblack > > devicetree. This can be achieved by placing the relevant devicetree > > names (am335x-sancloud-bbe and am335x-bonegreen) before am335x-boneblack > > in CONFIG_OF_LIST. =20 >=20 > Such restrictions should be handled inside board_fit_config_name_match() = and > hiden from user configuration. Can you update the board_fit_config_name_m= atch() > instead of updating defconfig? Hi Lokesh, Apologies for the late reply, I lost most of last week due to illness. I first attempted to fix this by changing the order of things in `board_fit_config_name_match` but it had no effect. Looking at `fit_find_config_node` in `common/common_fit.c`, we loop through the list of dtbs and check each one in turn for a match. So to move am335x-bonegreen ahead of am335x-boneblack we need to change the order in which the dtbs are checked in `fit_find_config_node`. The simplest way I could find to do that is to change the order of the names in CONFIG_OF_LIST. Thanks, --=20 Paul Barker Principal Software Engineer SanCloud Ltd --Sig_//bc=WNZk2/MwZbKoJnTmhHL Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQS7m7rT1+CktY3YG1PYN3IfEvob6gUCYPaHIgAKCRDYN3IfEvob 6lYNAPwOg0zgKa3MkD2KncLPQY6bTDhvULslLdO8pV3/wha6XAD/dE6529+oTLIb BrN5l4OphoRAwtVBL8Dd7MOXDE8xyAU= =ekAu -----END PGP SIGNATURE----- --Sig_//bc=WNZk2/MwZbKoJnTmhHL--