From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEEF1C07E9B for ; Wed, 21 Jul 2021 06:40:31 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B35F961029 for ; Wed, 21 Jul 2021 06:40:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B35F961029 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sancloud.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B6FBD80FBE; Wed, 21 Jul 2021 08:40:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sancloud.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=sancloud.onmicrosoft.com header.i=@sancloud.onmicrosoft.com header.b="RRRWkI/p"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5A19881664; Wed, 21 Jul 2021 08:40:27 +0200 (CEST) Received: from GBR01-LO2-obe.outbound.protection.outlook.com (mail-lo2gbr01on071e.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe15::71e]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8B42280214 for ; Wed, 21 Jul 2021 08:40:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sancloud.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=paul.barker@sancloud.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FVc+m3FxhymNUNQBPEhJYF3oc9OSdtn56+304V4qD2D20rd+WWmv49OUjpe1ji35Gr8BG1cuTU4ypTVbJ/p7kRJAgrvbdHzO8rMpUwBY06F8fRzHEM+yeVLfbehwKmtlQ1JolIspFS8+GDqZCOp934pfh8JqFDYxXSAjqeD5nhqAFgV84GexIlO1lhZpujg6M4hDrqs64E0dNJ//g8OcwR3ITNekCFNXnjzeF1n4R2g7iBjElK8wz6eZK7eSCArjKcpovJ8OIRzDfFSioZXSdk86qAFQQ1z/1BG/QChZTmojJP9JgwjZDDRYwo496TCQAzTxhAfETk+iQno7npKOhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9SeGlbxwHRiF0zyGQ3LJgdcxGntBbUTMN/F8LK87K9A=; b=bKxJjYPX08vTS7yX4VvhWNI0B26Otol99P8+hIOi+GT85CKWYy1wVVaQD4K+fM2OJnMlvT06rD+jae3P13klVdNWp2N6XA1zEB85G3LkwFAdiUrKKpN+wAszMnvW9IDXImnoDEQqkfPsbv6B4b5817B3640eyi1BMpxqo/ZimUDR6ApuEPqlimq2IMmXRPcWsJabtD46BW/H0Q1fRTJd9JtKhjtBMvNzW3dOjnHdHlPGjhNUAmL2s7fftY4gXWIIfwGIL/O9bUkFGTuC3c/EtO/3X9M31aHBVMV9phLkviuTyN5lWRYHZnLDjNJisxOjSnIulgE1O43LYcArZ20a+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sancloud.com; dmarc=pass action=none header.from=sancloud.com; dkim=pass header.d=sancloud.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sancloud.onmicrosoft.com; s=selector2-sancloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9SeGlbxwHRiF0zyGQ3LJgdcxGntBbUTMN/F8LK87K9A=; b=RRRWkI/pYFSbdUZf+sWDIcM0LKOvYYuGDLe8E6mnHUHOtXOEDYvj1vKeSrDTbFZrqPtz2Hk3hVEPKKXgOjeuvx5KKONLd8c9J313X85W+I7NzsYwbRan2nEqHyx6MLoimpRmKKVv4gE/W3Omwmo05PbSqxrfOql5IgDVuntWykE= Authentication-Results: ti.com; dkim=none (message not signed) header.d=none;ti.com; dmarc=none action=none header.from=sancloud.com; Received: from CWLP123MB2241.GBRP123.PROD.OUTLOOK.COM (2603:10a6:401:61::19) by CWXP123MB4295.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:e5::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.23; Wed, 21 Jul 2021 06:40:23 +0000 Received: from CWLP123MB2241.GBRP123.PROD.OUTLOOK.COM ([fe80::dc2:e929:76be:a8b0]) by CWLP123MB2241.GBRP123.PROD.OUTLOOK.COM ([fe80::dc2:e929:76be:a8b0%7]) with mapi id 15.20.4331.034; Wed, 21 Jul 2021 06:40:23 +0000 Date: Wed, 21 Jul 2021 07:40:06 +0100 From: Paul Barker To: Lokesh Vutla Cc: Tom Rini , Peter Robinson , Subject: Re: [PATCH v2 5/5] configs: am335x_evm: Fix BeagleBone Green DTB selection Message-ID: <20210721074006.6c96999d.paul.barker@sancloud.com> In-Reply-To: <17e3ec01-dd6a-e79e-4afe-900ddb56d3f9@ti.com> References: <20210712201412.13306-1-paul.barker@sancloud.com> <20210712201412.13306-6-paul.barker@sancloud.com> <20210720091946.1d4e94f7.paul.barker@sancloud.com> <17e3ec01-dd6a-e79e-4afe-900ddb56d3f9@ti.com> Organization: SanCloud Ltd X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-suse-linux-gnu) Content-Type: multipart/signed; boundary="Sig_/5qT3Lt8m5=33jHXe+8EIj.b"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-ClientProxiedBy: LO4P123CA0218.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::7) To CWLP123MB2241.GBRP123.PROD.OUTLOOK.COM (2603:10a6:401:61::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from owl.home.b5net.uk (80.7.160.81) by LO4P123CA0218.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.21 via Frontend Transport; Wed, 21 Jul 2021 06:40:22 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dd1570dd-ba3d-4d7c-3138-08d94c126a85 X-MS-TrafficTypeDiagnostic: CWXP123MB4295: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QheuR6a+gBBuT8Ymbo9H2N1jhzZhUKzF/Ooi55N8W8GnccksXqgBAgAwyw5+Njv7/WPGlTtYAH1sielGPLJqsDGVmveykD5T0hNmdDyXQWgmd9IcynJBJC5UhzdWhu1+BGXuNQLr/aBaZdixKQlCdjTQPVtire+jsiVU48sCf7RPTfIxHBl5VBhSCUwLlXlZJRLZCFMRQUyJn4kEacHdgRj+IiUGTgZvN7vjDKCI3GdKfrh3niU7b8tCIbE0BBBXJ3jU+8irfYPkSDIlMV6l3UqlhPjYBqZkMOr3tRgHGsiAoXM4v6r43sHnObXDNARY5PiIFNrbfSDzYtaN+njbn3djNFa0ViU4KCQBCQthfMVx0RPkNta2ZvNGMZsyYWjd+bieYCnvRfZN+XKcvCwpoAl8DiDMFeVTt28uJIC0DQt3Inww1ewNuCPOGd/9ysC4E96gBWAGgvngzBXZ4staahJRMrHwr5MDJMed+BHo9WEQ/P097swCmAOGHNhyksHoElhnx+fx7WFPhB7iYBKuyszVC7usWq8GzHpq75OhDKKwpzscerSWhIEiIUPt/dOWHzUZu3Eezvy6b/Gzv4DT9QgpXDv4BlRt8xrSBxN50VbVcxiYf9OU8cAayUq2PrUQSlT4pA0DAJJFT8Cmba4WFQkrUqrqSYfVFIIRmlGXkFDHAiKJP68exIMTNVyJcMQ74nZuxtKS9CaydhLeb0qPcw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CWLP123MB2241.GBRP123.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(39830400003)(136003)(366004)(376002)(396003)(346002)(8936002)(186003)(316002)(52116002)(8676002)(86362001)(5660300002)(6486002)(54906003)(6916009)(36756003)(44832011)(38350700002)(26005)(2906002)(83380400001)(103116003)(38100700002)(4326008)(36916002)(956004)(2616005)(66946007)(66556008)(1076003)(6666004)(66476007)(6506007)(478600001)(53546011)(6512007); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ej1nC91hgD99J+eh1CYr9ip2vydcPHYA2EPbFQ6DIMJWRsi1LOEA9/qjlRmr?= =?us-ascii?Q?GNKqNjBUv4NCIZWejhIo+FF7ZNUV9eLFSDfD2JrRo7wkFBPiq7MtNPsEYczt?= =?us-ascii?Q?jcmSATUckIDEpfw3AkmCu7cac+5uEoQaJkmuTYto3LEyypbRDskm8GmQNeJi?= =?us-ascii?Q?wULsJH1bVGrUhq2rLSXQbjubTAy1bc+tc0kXtTrUNWzGXacLE4iXYPILU3F7?= =?us-ascii?Q?liKHvRn+JXChdY1wIP0+w3n8gmPC8v0wxkH2R2SayIV/y/kfVRX8SncABMDW?= =?us-ascii?Q?ftU7t5Cp/KyhAVSUrkGWxYw4DAFKRCgTW1rCfZVSTmN0c9FLBHh+wcClzpKf?= =?us-ascii?Q?Ljsc+/hbfP8lo/18JURSXhfkAcLM4qLkIS0rOCRb2buc49vYpH348ExrcYMB?= =?us-ascii?Q?DewuXxmjtxFufG8KWzJ178Fp74BYiiateMjeWFmscLBooo10guHmm3qZEfq9?= =?us-ascii?Q?Q6neQ5hIiINiIoY2Y4Uwn1ta40snGFINY35ZuluqWRlS3jZsWak9yakrFFMZ?= =?us-ascii?Q?65KfPb1+ciuBAqCCHrVD9GODzuDqq522q8uHt9FPdTeBhAjUAgviIDk6ZHRv?= =?us-ascii?Q?GpkFE5yICQtzdctwpSX3P7d5fDi6ozDFGum1yChGjoDdt7MuD3y/omSrSOOv?= =?us-ascii?Q?eM+9Wrk3IOKOI+LAw6w0vmC6egscIo/H0bGm+gha+5t6o9gduh9BrjpA7Zj4?= =?us-ascii?Q?BcqXzEZX+sOwF6dc9BFuOVyLT/gNuk8kiutQcxsnr1EjWZvx60ODHtgqJaUm?= =?us-ascii?Q?h1SW6HaTvLxN/wxBQ5rmFX2ZPW/6E5xSBh/4BRS9nvS9RhcM4FG4m8VuPpLU?= =?us-ascii?Q?nZzsObKWis+Ze8KP++plCnjz7o357RFlph7zZBrXCzNhTIiMGViS2M43zDJT?= =?us-ascii?Q?ubgmvfZOhwsfD9qbIJo7Cx4hRUGnR8r3z2pxPT5YjVrQQStqlHiI3qYDIFtk?= =?us-ascii?Q?Ab5lYscFEkKa7BoysuhzRE+CPWl4CYdzQYIKF3TK7FtsHlmo632g3FzpObe7?= =?us-ascii?Q?i5Ru1rWKLdqplAG8vSxiVyfmF9akwbyePlbOLgTFYsaC3I3DNxGnLywOyOMv?= =?us-ascii?Q?dufIsbOC65jti4mNqINMpCCyZZbfXobDhyqQUEDgOald/0CP1fVcyrprVdCg?= =?us-ascii?Q?e6CVinaJ0HHIwCxCQ5OgtY3X4ibM4X6ecrCNWVPcjyEbUkFuyvT6dpmd1aVE?= =?us-ascii?Q?+5/7tn2MON8QIXFNo3ELhtogvZmXAh2SUoJrixbe6m0xh6v2hB28wZzHdi5q?= =?us-ascii?Q?5aLp31wiLTUeYTigQWqw+BMJ251SLy2eMNk67UN78V0bLeihoO8dH7LGn/3r?= =?us-ascii?Q?ThOmP1z3TmlDGTSQBlRX8+MQ?= X-OriginatorOrg: sancloud.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd1570dd-ba3d-4d7c-3138-08d94c126a85 X-MS-Exchange-CrossTenant-AuthSource: CWLP123MB2241.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2021 06:40:23.0781 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 840be37c-244a-450e-9bcc-2064862de1f4 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QwE1g/aB+cqyzVZk2h9kOk3ewP2njqpVp6U2ZKHPKoALluBpLi8tOaFf551xm8ag945OQm9S7tL9ctJW/lrmSmzxod6gRhCZxwmCSy/BMO8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWXP123MB4295 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --Sig_/5qT3Lt8m5=33jHXe+8EIj.b Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 21 Jul 2021 11:29:04 +0530 Lokesh Vutla wrote: > On 20/07/21 1:49 pm, Paul Barker wrote: > > On Tue, 13 Jul 2021 11:59:06 +0530 > > Lokesh Vutla wrote: > > =20 > >> On 13/07/21 1:44 am, Paul Barker wrote: =20 > >>> The function board_is_bone_lt() returns true for the BeagleBone Green, > >>> the BeagleBone Enhanced and the BeagleBone Black. Therefore when > >>> selecting which devicetree to use we must ensure that the more specif= ic > >>> functions board_is_bbg1() and board_is_bben() are checked first > >>> otherwise all three devices would end up using the am335x-boneblack > >>> devicetree. This can be achieved by placing the relevant devicetree > >>> names (am335x-sancloud-bbe and am335x-bonegreen) before am335x-bonebl= ack > >>> in CONFIG_OF_LIST. =20 > >> > >> Such restrictions should be handled inside board_fit_config_name_match= () and > >> hiden from user configuration. Can you update the board_fit_config_nam= e_match() > >> instead of updating defconfig? =20 > >=20 > > Hi Lokesh, > >=20 > > Apologies for the late reply, I lost most of last week due to illness. > >=20 > > I first attempted to fix this by changing the order of things in > > `board_fit_config_name_match` but it had no effect. Looking at > > `fit_find_config_node` in `common/common_fit.c`, we loop through the > > list of dtbs and check each one in turn for a match. So to move > > am335x-bonegreen ahead of am335x-boneblack we need to change the order > > in which the dtbs are checked in `fit_find_config_node`. The simplest > > way I could find to do that is to change the order of the names in > > CONFIG_OF_LIST. =20 >=20 > ahh..ok got it. But still such constraints in config file is most likely = will > not be maintained in future when someone touching the config. Because not > everyone knows this. >=20 > Is it possible to create a new macro which is true only for bbb and use it > instead in board_fit_config_name_match? I'm happy to have a look for an alternative solution like that. The patch here is a quick fix though that can be applied as-is. Perhaps we should apply this and also look for an alternative implementation of `board_is_bone_lt`. If you want to leave this patch out for now, can we move ahead and merge the other patches in this series? Thanks, --=20 Paul Barker Principal Software Engineer SanCloud Ltd --Sig_/5qT3Lt8m5=33jHXe+8EIj.b Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQS7m7rT1+CktY3YG1PYN3IfEvob6gUCYPfBRgAKCRDYN3IfEvob 6jXgAP9a5/plgPsvkzmj4XfSkfopgidjgKNIqG5twJITgi2i4AEA+Wf1Httqq/HK kOT5dQmuNjKqEJejdxYvzhCX6zdEkgw= =egDQ -----END PGP SIGNATURE----- --Sig_/5qT3Lt8m5=33jHXe+8EIj.b--