From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5488FC6377D for ; Thu, 22 Jul 2021 17:02:59 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8937C613B7 for ; Thu, 22 Jul 2021 17:02:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8937C613B7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D2FF982A01; Thu, 22 Jul 2021 19:02:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="D+FqKopt"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2490E82BEE; Thu, 22 Jul 2021 19:02:55 +0200 (CEST) Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 271FE829D4 for ; Thu, 22 Jul 2021 19:02:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x733.google.com with SMTP id t185so6078376qkd.3 for ; Thu, 22 Jul 2021 10:02:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=VU/ZhA19q7HQqSf8dLbEj87OSJZ7RdoN1BsX+rOfo/Y=; b=D+FqKoptTczksMlBzotFHYCbKM5bD0pagxkOZRZM4Ct6lf3/BWJn/KEh3cxGm/JMre IeNDlFjODPRTixKYSZLJD1RUSMZHaBXkdYYrJ3hXNIOXK5I6I73bLleI1Cwi6kT6LI8p ipJIvI1J2yiDXb3+YsItUiYONucjS+4v0sTF4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VU/ZhA19q7HQqSf8dLbEj87OSJZ7RdoN1BsX+rOfo/Y=; b=bW7lImWjrTNldh9i8e5+HQKOsCroYLRE3uTF5G1PipeHNeZyBDTTOqM/p0wJmVr51e w6jpSNhri0DQRA/s+iR+jIYz1i++RoMXrwDsBj61Z5YDRHSfEqaS831IDlq5g6KtvD0j /oKpQ+G5HYpHH5BSk9bqjBNsVd7IRw9qHzW50NrnJcJYnsiTwyaGeicUqACA4VKRqSU4 IpAWM+s4+21DrXuzGTYJ/yta36/ixf0CcXJTOnwzosw0mAkGbD42esX65KzA5iuYHJdf GAtuE/c6fQd3QzUayzJPj8a+XpXepA9myDMBjYseD8n/gAnojE8cL3wdVBLTZCyMnTqT 9+bQ== X-Gm-Message-State: AOAM532xcAz+ia/QkCOS6qxbfu9YQ9TNx6WIp4ePa1C10qepZsVqJ25T ezYk6b4AG8UlDluy0vxFQjy/dQ== X-Google-Smtp-Source: ABdhPJyHGtb2oE6fUQHof9cRqer6Vypr0OkXdKoLGP+ZcqZ1p96YEI20493YmizgEGveevm5IgFAlg== X-Received: by 2002:a05:620a:4543:: with SMTP id u3mr665647qkp.326.1626973370964; Thu, 22 Jul 2021 10:02:50 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-5560-078f-fb66-41c1.res6.spectrum.com. [2603:6081:7b01:cbda:5560:78f:fb66:41c1]) by smtp.gmail.com with ESMTPSA id m17sm9524238qtu.34.2021.07.22.10.02.49 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 22 Jul 2021 10:02:50 -0700 (PDT) Date: Thu, 22 Jul 2021 13:02:48 -0400 From: Tom Rini To: Michael Walle Cc: Zhiqiang Hou , Heinrich Schuchardt , u-boot@lists.denx.de, priyanka.jain@nxp.com Subject: Re: [PATCH] configs: layerscape: Disable the EFI_LOADER feature Message-ID: <20210722170248.GA9379@bill-the-cat> References: <20210722062559.21188-1-Zhiqiang.Hou@nxp.com> <20210722152622.GY9379@bill-the-cat> <20890af388806b4bead24e9a10532305@walle.cc> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yPo1CW2ZXioZPB28" Content-Disposition: inline In-Reply-To: <20890af388806b4bead24e9a10532305@walle.cc> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --yPo1CW2ZXioZPB28 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 22, 2021 at 07:00:31PM +0200, Michael Walle wrote: > Am 2021-07-22 17:26, schrieb Tom Rini: > > On Thu, Jul 22, 2021 at 02:25:59PM +0800, Zhiqiang Hou wrote: > >=20 > > > From: Hou Zhiqiang > > >=20 > > > The feature BOOTENV_SHARED_EFI is not supported on layerscape > > > boards, it didn't result kernel boot crash previously since > > > there isn't the efi/boot/"BOOTEFI_NAME" and it skip calling of > > > 'boot_efi_binary'. > > >=20 > > > But since the commit f3866909e350 ("distro_bootcmd: call EFI > > > bootmgr even without having /EFI/boot"), it will cause kernel > > > boot crash as there isn't a valid fdt_addr and it finially uses > > > the device tree blob of U-Boot and further cause errors. > > >=20 > > > As this feature is enabled by default for armv7 and armv8, so > > > disable it explicitly to avoid calling the 'scan_dev_for_efi'. > >=20 > > I'm not thrilled with this. Why isn't the solution to get and keep in > > sync the device trees, so that the tree U-Boot has is valid for the > > kernel? I'm also open to discussing f3866909e350 more. But I'm really > > opposed to disabling EFI_LOADER on modern platforms as that will make > > adoption of U-Boot in device harder I feel. >=20 > I don't know whats going on with the NXP boards, but the sl28 > is a layerscape board it is working pretty well with EFI boot. >=20 > So why don't you fix the root cause instead of disabling this > feature? Having thought a bit more on this, if the U-Boot run-time DTB causes the kernel to fail that would seem to be a rather big failing on the whole "DTB is ABI" thing, would it not? I'm not saying that's not what's happening, rather I'm noting that it's not supposed to happen and old DTB + new kernel should work. --=20 Tom --yPo1CW2ZXioZPB28 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmD5pLQACgkQFHw5/5Y0 tyyakwv/ZwwSZHFDHcJ9GDlXYSDAzcO8CfvnN/m+DgQtOArOLRZPwrv6gKvzaTVK rfp7YKVXxcxoEkuznD2isRyvFuvCXeJp5rGUuc7FUHt/Br+bQfLtUulSJ+40GyQI FeEf47fuGLIFiA9uFLywwITfc0F9WIJB8fGhxPDHjnj8uz/V2dJXJDbKZUlaZ8ow uMOUwPjwMqgm4FjqsNVjcsi7gB2ORAaupqua+XcpYtCoSPPvP0TP93ynykjS51v2 9ihrEEKoQrbwa579yYd/AM4ZFMx0/Wkcazj5wZiXHxccALPSE+wIuxKDPAkv3qgM 6rVQ9SlSiSvfaZsCsA787xBieDR0w4d3GejfnNRnz9nWiZx67upNGCUHK1gp+zzH V8OrUjsVWMJUymV+w4Uhu9xnKJk5wrC2PuahGNuWRL2BVF2OKBeZK2ctv0EPTj5z GjvuP/UkH5apCDK/PNeWXc0noDIufUP1sInH56I/XnOnjQpRsNkQVWTk+JkggKwd WsDqmF1+ =TX75 -----END PGP SIGNATURE----- --yPo1CW2ZXioZPB28--