Re: [PATCH 6/8] configs: toradex: add default rootpath

Marek Vasut
2021-07-22T16:07:56Z

On 7/22/21 5:49 PM, Oleksandr Suvorov wrote:

[...]

> diff --git a/include/configs/apalis-imx8.h b/include/configs/apalis-imx8.h
> index b04a03f76d..5a90e03edb 100644
> --- a/include/configs/apalis-imx8.h
> +++ b/include/configs/apalis-imx8.h
> @@ -24,6 +24,7 @@
> #define CONFIG_IPADDR 192.168.10.2
> #define CONFIG_NETMASK 255.255.255.0
> #define CONFIG_SERVERIP 192.168.10.1
> +#define CONFIG_ROOTPATH "/srv/nfs"

Rather, all this should be removed, since all these IP addresses and
root path settings are invalid for most places where the system will be
used. The user should define their own. It is not recommended to hard
code this in board config.