Re: [PATCH 1/8] board: colibri_vf: synchronize/improve memory options

Tom Rini
2021-07-22T17:41:01Z

[-- Attachment #1: Type: text/plain, Size: 1556 bytes --]

On Thu, Jul 22, 2021 at 06:49:36PM +0300, Oleksandr Suvorov wrote:

> From: Stefan Agner <stefan.agner@toradex.com>
>
> Synchronize initramfs related configuration options and improve
> memory layout. The memory layout with an offset of 16MiB allows
> to boot bigger kernels. With AUTO_ZRELADDR, which is pretty much
> the standard nowadays, the kernel relacates itself to PC masked
> with 0xf8000000 plus a text offset of 0x8000 (hence 0x80008000 for
> Vybrid). With a 16MiB offset from the start of memory and a 16MiB
> distance to the device-tree, we allow kernel up to ~16MiB.
>
> Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
> ---
>
> include/configs/colibri_vf.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/configs/colibri_vf.h b/include/configs/colibri_vf.h
> index 5bd440f1db..7fb54a442e 100644
> --- a/include/configs/colibri_vf.h
> +++ b/include/configs/colibri_vf.h
> @@ -47,6 +47,8 @@
> #define MEM_LAYOUT_ENV_SETTINGS \
> "bootm_size=0x10000000\0" \
> "fdt_addr_r=0x82000000\0" \
> + "fdt_high=0xfffffff0\0" \
> + "initrd_high=0xfffffff0\0" \
> "kernel_addr_r=0x81000000\0" \
> "pxefile_addr_r=0x87100000\0" \
> "ramdisk_addr_r=0x82100000\0" \

NAK. You cannot disable device tree relocation by default. You're
already setting bootm_size, which is good. I don't like disabling
initrd, but that's at least an easier to debug problem, and also much
more performance sensitive.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]