Re: [PATCH 6/8] configs: toradex: add default rootpath

Oleksandr Suvorov
2021-07-22T18:29:57Z

On Thu, Jul 22, 2021 at 9:18 PM Marek Vasut <marex@denx.de> wrote:
>
> On 7/22/21 8:10 PM, Oleksandr Suvorov wrote:
> > On Thu, Jul 22, 2021 at 9:06 PM Marek Vasut <marex@denx.de> wrote:
> >>
> >> On 7/22/21 6:32 PM, Oleksandr Suvorov wrote:
> >>> Hello Marek,
> >>>
> >>> On Thu, Jul 22, 2021 at 7:08 PM Marek Vasut <marex@denx.de> wrote:
> >>>>
> >>>> On 7/22/21 5:49 PM, Oleksandr Suvorov wrote:
> >>>>
> >>>> [...]
> >>>>
> >>>>> diff --git a/include/configs/apalis-imx8.h b/include/configs/apalis-imx8.h
> >>>>> index b04a03f76d..5a90e03edb 100644
> >>>>> --- a/include/configs/apalis-imx8.h
> >>>>> +++ b/include/configs/apalis-imx8.h
> >>>>> @@ -24,6 +24,7 @@
> >>>>> #define CONFIG_IPADDR 192.168.10.2
> >>>>> #define CONFIG_NETMASK 255.255.255.0
> >>>>> #define CONFIG_SERVERIP 192.168.10.1
> >>>>> +#define CONFIG_ROOTPATH "/srv/nfs"
> >>>>
> >>>> Rather, all this should be removed, since all these IP addresses and
> >>>> root path settings are invalid for most places where the system will be
> >>>> used. The user should define their own. It is not recommended to hard
> >>>> code this in board config.
> >>>
> >>> Is it acceptable to move this stuff to Toradex Kconfigs as default values?
> >>
> >> The general recommendation is to not set such default values at all,
> >> just let the user configure what they need.
> >
> > Thanks for your feedback! I'll remove this patch from the next version
> > of the patchset.
>
> You likely also want to remove all those CONFIG_IPADDR and co.

Yes, thanks, probably by the next release :)