From: Tom Rini <trini@konsulko.com>
To: Stephan Gerhold <stephan@gerhold.net>
Cc: u-boot@lists.denx.de,
Nicolas Dechesne <nicolas.dechesne@linaro.org>,
Ramon Fried <rfried.dev@gmail.com>
Subject: Re: [PATCH 2/3] board: dragonboard410c: Fix fastboot
Date: Sat, 24 Jul 2021 16:40:49 -0400 [thread overview]
Message-ID: <20210724204049.GY9379@bill-the-cat> (raw)
In-Reply-To: <20210714085626.5961-3-stephan@gerhold.net>
[-- Attachment #1: Type: text/plain, Size: 1066 bytes --]
On Wed, Jul 14, 2021 at 10:56:25AM +0200, Stephan Gerhold wrote:
> At the moment pressing the volume down key does not actually launch
> fastboot. This is because setting "bootdelay" to "-1" actually
> disables autoboot and drops to the U-Boot console. It does not execute
> the "bootcmd".
>
> The correct value for "bootdelay" here would be "-2", which disables
> the delay and key checking and would immediately execute the "bootcmd".
>
> However, even better in this case is using "preboot" to trigger Fastboot.
> The advantage is that running "fastboot continue" will actually continue
> the autoboot process instead of ending up in the U-Boot shell.
>
> Also make sure to unset "preboot" again immediately in case the user
> saves the environment after triggering fastboot.
>
> Cc: Ramon Fried <rfried.dev@gmail.com>
> Fixes: aa043ee91a47 ("db410c: automatically launch fastboot")
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-07-24 20:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 8:56 [PATCH 0/3] board: dragonboard410c: Fix some minor issues Stephan Gerhold
2021-07-14 8:56 ` [PATCH 1/3] board: dragonboard410c: Fix PHYS_SDRAM_1_SIZE Stephan Gerhold
2021-07-14 20:37 ` Ramon Fried
2021-07-24 20:40 ` Tom Rini
2021-07-14 8:56 ` [PATCH 2/3] board: dragonboard410c: Fix fastboot Stephan Gerhold
2021-07-14 20:36 ` Ramon Fried
2021-07-24 20:40 ` Tom Rini [this message]
2021-07-14 8:56 ` [PATCH 3/3] serial: serial_msm: Delay initialization to let pins stabilize Stephan Gerhold
2021-07-14 20:39 ` Ramon Fried
2021-07-15 6:15 ` Stephan Gerhold
2021-07-24 20:40 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210724204049.GY9379@bill-the-cat \
--to=trini@konsulko.com \
--cc=nicolas.dechesne@linaro.org \
--cc=rfried.dev@gmail.com \
--cc=stephan@gerhold.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox