From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Alexandru Gagniuc <mr.nuke.me@gmail.com>,
Aswath Govindraju <a-govindraju@ti.com>,
Bin Meng <bmeng.cn@gmail.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Jaehoon Chung <jh80.chung@samsung.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>,
Joe Hershberger <joe.hershberger@ni.com>,
Joel Stanley <joel@jms.id.au>, Lokesh Vutla <lokeshvutla@ti.com>,
Marek Vasut <marex@denx.de>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Pavel Herrmann <morpheus.ibis@gmail.com>,
Peng Fan <peng.fan@nxp.com>, Ramon Fried <rfried.dev@gmail.com>,
Tero Kristo <t-kristo@ti.com>
Subject: Re: [PATCH v6 0/5] of-platdata: Avoid building libfdt
Date: Sun, 25 Jul 2021 16:32:31 -0400 [thread overview]
Message-ID: <20210725203231.GG9379@bill-the-cat> (raw)
In-Reply-To: <20210725161347.457937-1-sjg@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 1599 bytes --]
On Sun, Jul 25, 2021 at 10:13:42AM -0600, Simon Glass wrote:
> The original patch of this series was sent in September 2019 but
> unfortunately caused build problems on some boards, since they don't
> comply with the of-platdata rules.
>
> With of-platdata, the idea is to compile the device tree into C structures
> to save space and avoid needing to use libfdt. But some boards use
> of-platdata while also using libfdt in a few areas, thus defeating the
> purpose of of-platdata.
>
> This series includes the original two patches
>
> http://patchwork.ozlabs.org/patch/1167420/
> http://patchwork.ozlabs.org/patch/1167367/
>
> as well as a few other patches to fix the build errors. Overall this
> reduces code size and provides better error messages when unavailable
> functions are used.
>
> Board maintainers should still take a look at the result, adjusting the
> of-platdata support as needed.
>
> Note: This series was resent a year ago but not applied. Since then, some
> boards have ended up using drivers in SPL which require OF_CONTROL, but
> SPL_OF_CONTROL is not enabled. So now we have two problems. This series
> fixes that one also.
>
> The problems will keep getting worse if people are not aware that
> something is wrong. Therefore I think this patch series should be applied
> ASAP.
OK, so I took 5/6 and 6/6 and fired off a build. The only fails-to-link
now are:
am335x_boneblack_vboot am335x_evm am335x_evm_spiboot
So are all of the other problems still present? I'm going to look in to
the am335x failures.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-07-25 20:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-25 16:13 [PATCH v6 0/5] of-platdata: Avoid building libfdt Simon Glass
2021-07-25 16:13 ` [PATCH v6 1/5] omap: mmc: Avoid using libfdt with of-platdata Simon Glass
2021-07-25 16:13 ` [PATCH v6 2/5] net: atheros: Add a check for OF_CONTROL Simon Glass
2021-07-27 4:23 ` Ramon Fried
2021-07-25 16:13 ` [PATCH v6 3/5] spi: Add checks " Simon Glass
2021-07-25 16:13 ` [PATCH v6 4/5] spl: Allow SPL/TPL to use of-platdata without libfdt Simon Glass
2021-07-25 16:13 ` [PATCH v6 5/5] dm: core: Don't include ofnode functions with of-platdata Simon Glass
2021-07-25 20:32 ` Tom Rini [this message]
2021-07-26 3:57 ` [PATCH v6 0/5] of-platdata: Avoid building libfdt Simon Glass
2021-07-26 12:09 ` Tom Rini
2021-07-26 13:45 ` Simon Glass
2021-07-26 14:43 ` Tom Rini
2021-07-31 23:07 ` Simon Glass
2021-07-31 23:11 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210725203231.GG9379@bill-the-cat \
--to=trini@konsulko.com \
--cc=a-govindraju@ti.com \
--cc=bmeng.cn@gmail.com \
--cc=jagan@amarulasolutions.com \
--cc=jagannadh.teki@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=joe.hershberger@ni.com \
--cc=joel@jms.id.au \
--cc=lokeshvutla@ti.com \
--cc=marex@denx.de \
--cc=morpheus.ibis@gmail.com \
--cc=mr.nuke.me@gmail.com \
--cc=patrick.delaunay@foss.st.com \
--cc=peng.fan@nxp.com \
--cc=rfried.dev@gmail.com \
--cc=sjg@chromium.org \
--cc=t-kristo@ti.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox