From: Marek Behun <marek.behun@nic.cz>
To: "Pali Rohár" <pali@kernel.org>
Cc: Stefan Roese <sr@denx.de>,
Konstantin Porotchkin <kostap@marvell.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH 2/2] serial: a37xx: Do not call get_ref_clk() in _debug_uart_init()
Date: Mon, 26 Jul 2021 17:24:26 +0200 [thread overview]
Message-ID: <20210726172426.0f7de52a@thinkpad> (raw)
In-Reply-To: <20210726145804.lktqk73qkxac7mwb@pali>
On Mon, 26 Jul 2021 16:58:04 +0200
Pali Rohár <pali@kernel.org> wrote:
> On Monday 26 July 2021 16:55:22 Marek Behun wrote:
> > On Mon, 26 Jul 2021 14:58:59 +0200
> > Pali Rohár <pali@kernel.org> wrote:
> >
> > > Static inline function _debug_uart_init() should avoid calling external
> > > (non-inline) functions.
> >
> > Why?
>
> Function is called in stage when stack is not fully initialized and
> documentation suggest to avoid stack usage and other functions.
OK, but maybe we should use the macro names for register constants.
Could you move (in a separate patch) the corresponding macros from
arch/arm/mach-mvebu/armada3700/cpu.c to
arch/arm/mach-mvebu/include/mach/soc.h and then in this patch
include <asm/arch/soc.h> in the serial driver and use the constant
names?
Thanks.
Marek
next prev parent reply other threads:[~2021-07-26 15:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 12:58 [PATCH 1/2] serial: a37xx: Use CONFIG_BAUDRATE for initializing early debug UART Pali Rohár
2021-07-26 12:58 ` [PATCH 2/2] serial: a37xx: Do not call get_ref_clk() in _debug_uart_init() Pali Rohár
2021-07-26 14:55 ` Marek Behun
2021-07-26 14:58 ` Pali Rohár
2021-07-26 15:24 ` Marek Behun [this message]
2021-08-11 18:57 ` Pali Rohár
2021-08-16 8:04 ` Stefan Roese
2021-08-16 8:33 ` Pali Rohár
2021-08-16 9:07 ` Stefan Roese
2021-07-31 7:47 ` Stefan Roese
2021-07-31 10:01 ` Stefan Roese
2021-07-26 15:21 ` [PATCH 1/2] serial: a37xx: Use CONFIG_BAUDRATE for initializing early debug UART Marek Behun
2021-07-31 7:45 ` Stefan Roese
2021-07-31 10:01 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210726172426.0f7de52a@thinkpad \
--to=marek.behun@nic.cz \
--cc=kostap@marvell.com \
--cc=pali@kernel.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox