From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29B96C4338F for ; Mon, 26 Jul 2021 15:24:37 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1489760F51 for ; Mon, 26 Jul 2021 15:24:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1489760F51 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nic.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5D5DC8339A; Mon, 26 Jul 2021 17:24:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=nic.cz header.i=@nic.cz header.b="LQvTVOhY"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BD168833A2; Mon, 26 Jul 2021 17:24:30 +0200 (CEST) Received: from mail.nic.cz (mail.nic.cz [IPv6:2001:1488:800:400::400]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9F58A8339D for ; Mon, 26 Jul 2021 17:24:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.behun@nic.cz Received: from thinkpad (unknown [172.20.6.87]) by mail.nic.cz (Postfix) with ESMTPSA id 337B413FB4D; Mon, 26 Jul 2021 17:24:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1627313067; bh=4RQZACoH6zJGbIhUu0y+RvQIHUW7q6RniEZyMOZOJtw=; h=Date:From:To; b=LQvTVOhYCBuMq92Y3Lyw6kDioulZvXSchK+zTXKAOQJgrgq5ADY8CZXrMJnyTQ4w/ WBCHGx1NhcpB/hqSBSbx58PBNCufv0SQP6ExLgAvU5T2f6/CEfRSoKc+9p01R/KjKR B7qvHJRWNM+xfvDHBffZ623F9FzFDKJINUCWgUB8= Date: Mon, 26 Jul 2021 17:24:26 +0200 From: Marek Behun To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Stefan Roese , Konstantin Porotchkin , u-boot@lists.denx.de Subject: Re: [PATCH 2/2] serial: a37xx: Do not call get_ref_clk() in _debug_uart_init() Message-ID: <20210726172426.0f7de52a@thinkpad> In-Reply-To: <20210726145804.lktqk73qkxac7mwb@pali> References: <20210726125859.5588-1-pali@kernel.org> <20210726125859.5588-2-pali@kernel.org> <20210726165522.55a21808@thinkpad> <20210726145804.lktqk73qkxac7mwb@pali> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Mon, 26 Jul 2021 16:58:04 +0200 Pali Roh=C3=A1r wrote: > On Monday 26 July 2021 16:55:22 Marek Behun wrote: > > On Mon, 26 Jul 2021 14:58:59 +0200 > > Pali Roh=C3=A1r wrote: > > =20 > > > Static inline function _debug_uart_init() should avoid calling extern= al > > > (non-inline) functions. =20 > >=20 > > Why? =20 >=20 > Function is called in stage when stack is not fully initialized and > documentation suggest to avoid stack usage and other functions. OK, but maybe we should use the macro names for register constants. Could you move (in a separate patch) the corresponding macros from arch/arm/mach-mvebu/armada3700/cpu.c to arch/arm/mach-mvebu/include/mach/soc.h and then in this patch include in the serial driver and use the constant names? Thanks. Marek