Re: [PATCH 2/2] serial: a37xx: Do not call get_ref_clk() in _debug_uart_init()

Marek Behun
2021-07-26T15:24:37Z

On Mon, 26 Jul 2021 16:58:04 +0200
Pali Rohár <pali@kernel.org> wrote:

> On Monday 26 July 2021 16:55:22 Marek Behun wrote:
> > On Mon, 26 Jul 2021 14:58:59 +0200
> > Pali Rohár <pali@kernel.org> wrote:
> >
> > > Static inline function _debug_uart_init() should avoid calling external
> > > (non-inline) functions.
> >
> > Why?
>
> Function is called in stage when stack is not fully initialized and
> documentation suggest to avoid stack usage and other functions.

OK, but maybe we should use the macro names for register constants.

Could you move (in a separate patch) the corresponding macros from
arch/arm/mach-mvebu/armada3700/cpu.c to
arch/arm/mach-mvebu/include/mach/soc.h and then in this patch
include <asm/arch/soc.h> in the serial driver and use the constant
names?

Thanks.

Marek