From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F280CC4338F for ; Wed, 28 Jul 2021 16:43:20 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3325360EB9 for ; Wed, 28 Jul 2021 16:43:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3325360EB9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7866182D58; Wed, 28 Jul 2021 18:43:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="U5L2QYjO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D580582D50; Wed, 28 Jul 2021 18:43:14 +0200 (CEST) Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1E71D82C54 for ; Wed, 28 Jul 2021 18:43:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82e.google.com with SMTP id m11so1792175qtx.7 for ; Wed, 28 Jul 2021 09:43:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=MWuzKIMrl4anDu51nm2tSJVwPbfhyAh42XhehifWcqQ=; b=U5L2QYjOgIKnhFPYUQP+QFqp3LY/z97RtxOYeJwVEAG7mHrbp5+n0bPRNIuG9leOtq 089Yl+Ywo6XPj/slOI/n19CTT5ILN+wVKDmYMpR1HKaaWH3uXs5ofaGwPrSLyDOWy6jG uMxXpeX6FOdk21e7dQshXVu9HPF3yg9j6gUMk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MWuzKIMrl4anDu51nm2tSJVwPbfhyAh42XhehifWcqQ=; b=XvXq7zyrzFy+iWTJ+yFD5XL8xtwdz8FZwtIo2+amMRci8tKY+vEa0iw4C2ZjgsADkf D0wrWkSpsMLUm5ARp3cCK74+puojJKyOvszdxip1s0fHFuh7fLn1FEFJSwsz7YAHvLEi 0718H/pYgybT32aA4IEGOfTyxCv3+Ar06HOlQvmDWnWrpxpccQ+TK6Ek0CB2EXFGS7yT vGH+ntU37osuIB7b7GklssYughICmoranfP3mFrX9uo6I+Y4QqcHmFOq6Q4ldzOH4ObR oJYTK9M/Fd0BoLdsnUaer5+8PEIZsmL/LojD560r7zcp2J+XqXZ1cKYxbS4uROHGE/eL i9Cw== X-Gm-Message-State: AOAM532VHN/6fEZXa64IRr33FVIkDi0X/V90gD8YCzzECk60ScVFMc8n ZSShO/zsjHuYEUSlxwoMJCeYQw== X-Google-Smtp-Source: ABdhPJzC6TCd58EBGpjVfsLLo6ZMgReHFbSx1trAk3dze3ekrLxx0AXJnxjGTmMsDR1yeS7SrC4vrQ== X-Received: by 2002:a05:622a:1910:: with SMTP id w16mr375745qtc.227.1627490588536; Wed, 28 Jul 2021 09:43:08 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-3037-3a3d-435c-0707.res6.spectrum.com. [2603:6081:7b01:cbda:3037:3a3d:435c:707]) by smtp.gmail.com with ESMTPSA id d192sm256527qkc.51.2021.07.28.09.43.07 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Jul 2021 09:43:07 -0700 (PDT) Date: Wed, 28 Jul 2021 12:43:05 -0400 From: Tom Rini To: Oleksandr G Zhadan Cc: sjg@chromium.org, u-boot-request@lists.denx.de, u-boot@lists.denx.de, "arcsupport@ArcturusNetworks.com" Subject: Re: U-Boot Digest, Vol 158, Issue 63 Message-ID: <20210728164305.GP9379@bill-the-cat> References: <0735982b-277d-9f3d-3ed3-5fc0368c2cac@arcturusnetworks.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SU+pDiHQETgHpG/P" Content-Disposition: inline In-Reply-To: <0735982b-277d-9f3d-3ed3-5fc0368c2cac@arcturusnetworks.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --SU+pDiHQETgHpG/P Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 28, 2021 at 12:22:57PM -0400, Oleksandr G Zhadan wrote: > Hello, >=20 > Please see inline. >=20 > On 7/26/21 9:40 AM, u-boot-request@lists.denx.de wrote: > > Message: 13 > > Date: Mon, 26 Jul 2021 07:34:06 -0600 > > From: Simon Glass > > To: U-Boot Mailing List > > Cc: Tom Rini, Simon Glass, > > Albert Aribaud, Andy Fleming > > , Joe Hershberger, Marek > > Vasut, Mario Six, Oleksandr > > Zhadan and Michael Durrant, Pavel > > Herrmann, Priyanka Jain > > , Rob Herring, Stefan > > Roese, Stefano Babic, Wolfgang Denk > > > > Subject: [PATCH 00/33] pci: Drop all pre-driver model code > > Message-ID:<20210726133440.634682-1-sjg@chromium.org> > >=20 > > The hard work to actually enable DM_PCI everywhere was done recently. T= his > > series attempts to drop most of the code that it no-longer needed now t= hat > > PCI has been converted to driver model. >=20 > > It also drops the UCP1020 board since it has various unique build issue= s. >=20 > What issues are we talking about?Please name it. >=20 > Today's u-boot clone builds and runs fine in our module without any warni= ngs > except: >=20 > > git clone https://source.denx.de/u-boot/u-boot.git u-boot-20210728 >=20 > > cd u-boot-20210728 >=20 > > make UCP1020_defconfig >=20 > > CROSS_COMPILE=3Dpowerpc-linux- make 2>222 >=20 > =A0> cat 222 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D WARNING = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > This board does not use CONFIG_DM. CONFIG_DM will be > compulsory starting with the v2020.01 release. > Failure to update may result in board removal. > See doc/driver-model/migration.rst for more info. > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D WARNING = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > This board does not use CONFIG_DM_ETH (Driver Model > for Ethernet drivers). Please update the board to use > CONFIG_DM_ETH before the v2020.07 release. Failure to > update by the deadline may result in board removal. > See doc/driver-model/migration.rst for more info. > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D >=20 > > It doesn't even support driver model so it seems reasonable to just rem= ove > > it. > 1. Sure it's my fault that I didn't notice the warnings that CONFIG_DM is > the only choice to build and run u-boot. >=20 > 2. Why is CONFIG_DM still present in `make menuconfig` options? >=20 > 3. We only use u-boot as the first stage bootloader to start the kernel. = We > need minimal device controllers support. We don't need anything like PCI, > USB, etc. >=20 > 4. At least you need to add doc/driver-model/migration.rst to the source > tree from https://source.denx.de/u-boot/u-boot.git if you point to it in > your warnings. >=20 > And >=20 > 5. I have seen NO reason to remove ANY support board without REAL reasons= to > do so. So, unfortunately this was the only board that was not triggering the PCI migration warning as well because of how it was using the legacy PCI subsystem. For today, if you want to continue to be in mainline, just removing the PCI and other options that you don't use, and submitting that patch is sufficient. > SUMMARY: >=20 > 1. UCP1020_defconfig does not have any compiler warnings on build (at lea= st > 2021.07.28 clone). >=20 > 2. If now the only choice is CONFIG_DM, then it should be removed as an > option from "make menuconfig", and we will definitely fix the related > warnings/errors. >=20 > 3. IMPO board support can be removed if it breaks when built and/or breaks > any other builds. Note that CONFIG_DM is still an option because it won't be until after the v2022.01 window (when that migration warning you noted above) will have been present for about 3 years. It's still an option as we're down to 15 boards (UCP included) that need migration still. Having just counted that, I'm quite likely to fire off a separate email now and see if there's interest in these boards being updated or not, now that we're down to so few boards. --=20 Tom --SU+pDiHQETgHpG/P Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEBiRkACgkQFHw5/5Y0 tyzWtwwAq82uDyIxAI3UahJPdvhovpFIRQNimTJmpCwiDN8hZHlIUmfFmOzCkIXh 5ZuysoMVogLVPcPfyvx/HsXsi9BhxeuVx3ZXCVn4eQa+dCVWuKG3gCg09WJ3svIH f78cP/6+29t9S43XaJzJakGD7gxG7ulDQY9gRpORYEJADS6gXXfqvTslr7Zp5M1d f4i86SFEWXHvcfB0mryr1rt1AYvH9xNpYT69OSnrBijFw/ko1LfxHXGg0VaXax9v rX1my2cE5H1AfpyHfbD0CVPAlPCHQOqIXTrDHS+8EXbtY6Fc44fB1Ysut7Xq/j9R 147GocOge7ipqAmeWxN3ITP9OSQRdxeGGuOsWMXxoG0vRvcvl+oNvy2q77r1ajoD d0OaeoTQlA6QlB5AVWxSA5DZrZc8aStnPt9I0Sd/x62+YtayH3Z8H/8pgkcueg0F K7JMkyiN9bN0IWVtp6bDpqDs2ZG6PozmTgRO37rIL+EYsrupTp30h8KKb5HM/8t9 Jb8rB2ZY =/g0Y -----END PGP SIGNATURE----- --SU+pDiHQETgHpG/P--