From: Tom Rini <trini@konsulko.com>
To: Simon Glass <sjg@chromium.org>
Cc: "U-Boot Mailing List" <u-boot@lists.denx.de>,
"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
"Pali Rohár" <pali@kernel.org>,
"Mark Kettenis" <mark.kettenis@xs4all.nl>,
"Heinrich Schuchardt" <xypron.glpk@gmx.de>
Subject: Re: [PATCH v2 5/9] Allow efi_loader header to be included always
Date: Wed, 28 Jul 2021 18:56:56 -0400 [thread overview]
Message-ID: <20210728225656.GG9379@bill-the-cat> (raw)
In-Reply-To: <20210702183620.1542680-3-sjg@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
On Fri, Jul 02, 2021 at 12:36:16PM -0600, Simon Glass wrote:
> It is bad practice to put function declarations behind an #ifdef since
> it makes it impossible to use IS_ENABLED() in the C code. The main reason
> for doing this is when an empty static inline function is desired when
> the feature is disabled.
>
> To this end, this header provides two different versions of various
> functions and macros. Collect them together in one place for clarity.
> Allow all the rest of the header to be included, regardless of the
> setting of EFI_LOADER.
>
> With the inclusion of blk.h the 'struct blk_desc' declaration is
> unnecessary. Drop it while we are here.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-07-28 22:58 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-02 18:36 [PATCH v2 0/9] efi: Various tidy-ups and drop the default Simon Glass
2021-07-02 18:36 ` [PATCH v2 1/9] configs: Resync with savedefconfig Simon Glass
2021-07-02 18:36 ` [PATCH v2 2/9] Makefile: Drop include/asm directory as well as symlink Simon Glass
2021-07-28 22:56 ` Tom Rini
2021-07-02 18:36 ` [PATCH v2 3/9] disk: Tidy up #ifdefs in part_efi Simon Glass
2021-07-28 22:56 ` Tom Rini
2021-07-28 23:21 ` Heinrich Schuchardt
2021-07-02 18:36 ` [PATCH v2 4/9] Use LIB_UUID with ACPIGEN and FS_BTRFS Simon Glass
2021-07-28 22:56 ` Tom Rini
2021-07-02 18:36 ` [PATCH v2 5/9] Allow efi_loader header to be included always Simon Glass
2021-07-28 22:56 ` Tom Rini [this message]
2021-07-02 18:36 ` [PATCH v2 6/9] lib: Create a new Kconfig option for charset conversion Simon Glass
2021-07-28 22:57 ` Tom Rini
2021-07-02 18:36 ` [PATCH v2 7/9] Make EFI_LOADER depend on DM and OF_CONTROL Simon Glass
2021-07-26 22:07 ` Tom Rini
2021-07-28 23:45 ` Heinrich Schuchardt
2021-07-28 23:55 ` Tom Rini
2021-07-29 1:44 ` Simon Glass
2021-07-29 13:52 ` Tom Rini
2021-07-30 19:02 ` Simon Glass
2021-07-30 21:33 ` Tom Rini
2021-07-30 21:48 ` Simon Glass
2021-07-30 22:08 ` Tom Rini
2022-03-28 6:35 ` Simon Glass
2022-03-28 14:15 ` Tom Rini
2021-07-02 18:36 ` [PATCH v2 8/9] Add an option for EBBR Simon Glass
2021-07-29 0:12 ` Heinrich Schuchardt
2021-07-29 0:40 ` Tom Rini
2021-07-02 18:36 ` [PATCH v2 9/9] efi: Make EBBR optional Simon Glass
2021-07-02 20:11 ` Tom Rini
2021-07-02 20:38 ` Simon Glass
2021-07-29 0:35 ` Heinrich Schuchardt
2021-07-02 19:50 ` [PATCH v2 0/9] efi: Various tidy-ups and drop the default Mark Kettenis
2021-07-02 20:04 ` Simon Glass
2021-07-02 20:19 ` Tom Rini
2021-07-02 20:50 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210728225656.GG9379@bill-the-cat \
--to=trini@konsulko.com \
--cc=ilias.apalodimas@linaro.org \
--cc=mark.kettenis@xs4all.nl \
--cc=pali@kernel.org \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox