From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9565C4320A for ; Thu, 29 Jul 2021 15:23:20 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E6D1E601FF for ; Thu, 29 Jul 2021 15:23:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E6D1E601FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3D1C382E10; Thu, 29 Jul 2021 17:23:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="aw15J4UQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6DCE482EF1; Thu, 29 Jul 2021 17:23:15 +0200 (CEST) Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B9FB482E02 for ; Thu, 29 Jul 2021 17:23:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf33.google.com with SMTP id f91so3553460qva.9 for ; Thu, 29 Jul 2021 08:23:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=l7Z7+SbXOFo4rLHDKNBPNasJY3yeE+D8mPjGWY1f6Nw=; b=aw15J4UQ3eRylPbC98MhcuZmlKiHoHE1/nGu3lxH6y2F7K+ck0dGINvO3085DMHl0p UX+4qSbKwVky6rgWSxyPxKelE/0i0hrm5zauQliUFEwsRtIh2iKBnA8w2Ihcx4IPm40J k98owGpp8a3D600gbwKkQrg+iRmG5cMrTfp9o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=l7Z7+SbXOFo4rLHDKNBPNasJY3yeE+D8mPjGWY1f6Nw=; b=pG4wxIRI4kEEV3uujNHXLfYQQsclx1lPeDSzgbnU638s2ZMzz4qgNytYACEnuAJCws MXa2wVMpFxVTQ/SQjLHbLeGsQxuS+8/b2JIzbp1R/DLJoVjMVFcMEkueTTZXLjfdsPjX SWgxD1rfyZb6x84bSfCYXcwhXZpCxm1khDAWKN9w7+gnyaCcCKwqJCN86uWM0gBGZhB9 k1hoDwwoqPOAWXbVCmWyIMJiL/URdzQ1PN2IeBWY9b4v1+IGtPojljDMKBhM4uOSaF/L 8muS1HYoi/g/HhCpha79fOUtqGvdgxEwCAqnuyVRER4umVW4HL82J6RudavMNB4K3qCg oigA== X-Gm-Message-State: AOAM533Zo+L/v6YbPzLoAL4nUadK7dblw85JZLYXhY6YkOCrcix4pnHa O+GdMrGU17I0SN0NEGuNOT4qJg== X-Google-Smtp-Source: ABdhPJyUvX99l85DKUezRZLuT7p8S6YJ1J4KkxdHQmU40+Nh60SdyKYi43KbaC4PVBlrqzAVU7J+lw== X-Received: by 2002:a0c:a78a:: with SMTP id v10mr5441184qva.57.1627572190399; Thu, 29 Jul 2021 08:23:10 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-3037-3a3d-435c-0707.res6.spectrum.com. [2603:6081:7b01:cbda:3037:3a3d:435c:707]) by smtp.gmail.com with ESMTPSA id l4sm1902414qkd.77.2021.07.29.08.23.09 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Jul 2021 08:23:09 -0700 (PDT) Date: Thu, 29 Jul 2021 11:23:07 -0400 From: Tom Rini To: Marek Vasut Cc: Jan Kiszka , U-Boot Mailing List , Hai Pham , Simon Goldschmidt , Stephen Warren , Lokesh Vutla Subject: Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64" Message-ID: <20210729152307.GP9379@bill-the-cat> References: <1971775f-28de-83d0-9459-a4e68c744a18@siemens.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Sjd3/ktK2rJiUrYa" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --Sjd3/ktK2rJiUrYa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 29, 2021 at 05:01:09PM +0200, Marek Vasut wrote: > On 7/29/21 9:22 AM, Jan Kiszka wrote: > > From: Jan Kiszka > >=20 > > This reverts commit 2359fa7a87848626bcbd3399e92c657595880cd7. > >=20 > > While the goal is valid and there is surely unused memory in that area, > > we also have a lot of crucial things still located at the top-of-memory > > while running lmb_alloc_base. Such things are the page table (tlb_addr), > > relocated U-Boot and the active stack. Possibly more. So this patch was > > premature, we will need relocations of those things first if we want to > > use the range. > >=20 > > Fixes booting on the IOT2050, but likely also on other boards. It got > > stuck on relocating the FDT - over the relocated U-Boot code. > >=20 > > Signed-off-by: Jan Kiszka > > --- > >=20 > > Practically, > >=20 > > void arch_lmb_reserve(struct lmb *lmb) > > { > > lmb_reserve(lmb, gd->relocaddr, gd->ram_top - gd->relocaddr); > > } >=20 > So this is wrong and breaks a use case on rcar3, where there is more stuff > which should not be reserved until the ram top. > > I suspect the real fix here is to protect only the stack and tlb on arm64, > not just everything from current stack bottom to ram top ? Wait, what? There's never been a U-Boot release that didn't reserve that area so when did rcar3 introduce something there that shouldn't be reserved? And you had phrased this to me on IRC as about reserving spot for ATAGS, and that not being needed of course on arm64. But that's not what's going on. Perhaps the answer is that rcar3 needs to introduce a board_lmb_reserve to free the normal arch one and provide whatever more narrow scope it needs. --=20 Tom --Sjd3/ktK2rJiUrYa Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmECx9QACgkQFHw5/5Y0 tyye+gwAlFcvxMK76FPMIjNtd0IpNl4UrEqMTER/Q20GDqgWRbbqZ9o1Z3b3Xe0y jE5p7zsMkcSnJaCg29fAxbRFSkWPuz1cTbexDmnh8XRcmNp92sdXnwlhCiyg+5gf pklL0AxGp8OM8qlnY6ax0xEfYh8rVoVGR7cl/SHXEJGDHfDdTEy2S6Xl120l2blI ofVABjyvDLwgHg1XCkW5qvX8OUbgXET8OPenhJOrpGW5FWesi+erPC7Q23fN9D9O XACtJyGUeKIDuLvPV1FwnKwUyxmrYxF3TRo2d1rcq2Q4ptwPgD9fWZq34U4bjhB3 tR+Oe76ZWXhlBV/f+XdTDzKy8bvR6Oy7wzHRT8jR6KWTURAL/GYP+vOY0kCsQU4L YJomeFSY/Yeqp2faBF+i/EtL224y2uhRVO/Zc8kloIeAB+nkUlHYz51PIKAMCPxs ccDaEqAtjKTktwYxkOpMym3wzYe7NtrW//Egk77d89prWEpzTFRKjaCGkzGDd5ga UhW57Hl6 =ILoJ -----END PGP SIGNATURE----- --Sjd3/ktK2rJiUrYa--