From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD5BCC4338F for ; Fri, 30 Jul 2021 05:34:01 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFF7760232 for ; Fri, 30 Jul 2021 05:34:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EFF7760232 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9030183200; Fri, 30 Jul 2021 07:33:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="oAbe3rVO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0859B83210; Fri, 30 Jul 2021 07:33:57 +0200 (CEST) Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2834D831C4 for ; Fri, 30 Jul 2021 07:33:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pj1-x1031.google.com with SMTP id b6so13514016pji.4 for ; Thu, 29 Jul 2021 22:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=uhM+WHw2eMmWr8b9GsWT4HuQnxSFyZPiMY643nEWnBU=; b=oAbe3rVOJONk0WqrrZCJZvgvoK0lcxgP5WvCGxV2PgvKTqsPbW0aZxKLnbaerv+7NJ 4tOSKnPU5ZHQBH6Lcmc360vJofcfP5vAFuxngKcFQZ3gcoTff2QWEEXFXTigNEqCvA5n 0rxbzZxncSiyArnc7QiE7zL1Qgb8GB7nePwQh3dfXvCKsn01lT7oD8vE+yCHveXTiJlX UxtLVO8yyWn9Q6Tl8O3hT8L/CE0K2bcb2AcRrocQ8dlwxDjD+qdQOM9OkkX8Ov0pnh/Y AjK31asFYU1WvNgFacyhyIniubbCgDY8gIGX7//xuRFX+oTVU3pWnPDxsJrVufTEd2Pw TeKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=uhM+WHw2eMmWr8b9GsWT4HuQnxSFyZPiMY643nEWnBU=; b=l8hS42DwkAHf300By9oe7Wnx5fxV2R3hqX0iaROODRWd1xwP/obkBI4Z0P7Qikb5Iq YrPOsdB+PUMRzTIMNwh/fFXWYnN42IG62bazx0nD4MxIz9T0EFo+vL56gFjH1+ZxpuE5 Z8yWOgV+6+ZWOP1upj3BtMJLlqxtmJOt+vNq3KOftBk++Hc8DUA+OusMr8jJm+gRjdIo upyPP8uW6FfekvMLzAZQAZrVx/mTTpte1s59BgCIkYdC8ZXmOSi5t/t0ArWprXhqweFs gkTrJi+pwOPlh9N2ExZRXfaJh/6tEAfWIPX5qGjfo5UxovbpaGYxaMfuYA86LAYYn7f+ jGTg== X-Gm-Message-State: AOAM533hw+8BYG1Ni2JMY6E+RZhDLQgbNxawCtV5zAKwnsJnMfISdTY0 CMuNQhIbxm3ZWf5yu57UUyeDrQ== X-Google-Smtp-Source: ABdhPJzN4pRoRfFpSD1IYe4AH4Th20nYegvOjVm9WSRA9Nf3IPOG1vs+YlRiTlA2TNRKz0o75rAa/w== X-Received: by 2002:a17:90a:4417:: with SMTP id s23mr1280971pjg.228.1627623231257; Thu, 29 Jul 2021 22:33:51 -0700 (PDT) Received: from laputa (pdb6272ed.tkyea130.ap.so-net.ne.jp. [219.98.114.237]) by smtp.gmail.com with ESMTPSA id y23sm733032pgf.38.2021.07.29.22.33.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jul 2021 22:33:50 -0700 (PDT) Date: Fri, 30 Jul 2021 14:33:44 +0900 From: AKASHI Takahiro To: Michal Simek Cc: Heinrich Schuchardt , Sughosh Ganu , U-Boot Mailing List , Ilias Apalodimas , Simon Glass , Vincent Stehle Subject: Re: EFI from usb HDD Message-ID: <20210730053344.GB150924@laputa> Mail-Followup-To: AKASHI Takahiro , Michal Simek , Heinrich Schuchardt , Sughosh Ganu , U-Boot Mailing List , Ilias Apalodimas , Simon Glass , Vincent Stehle References: <9c57a3c7-e609-91e8-cf33-5637ce4f9340@xilinx.com> <20210610125915.GA96492@laputa> <6d4a2a7e-a295-f3e1-1ad8-445f40df334e@xilinx.com> <20210730023507.GA150924@laputa> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Fri, Jul 30, 2021 at 06:41:01AM +0200, Michal Simek wrote: > > > On 7/30/21 4:35 AM, AKASHI Takahiro wrote: > > On Thu, Jul 29, 2021 at 04:09:32PM +0200, Michal Simek wrote: > >> Hi, > >> > >> On 6/10/21 2:59 PM, AKASHI Takahiro wrote: > >>> On Thu, Jun 10, 2021 at 02:31:46PM +0200, Michal Simek wrote: > >>>> > >>>> > >>>> On 6/10/21 12:51 PM, Heinrich Schuchardt wrote: > >>>>> On 6/10/21 12:04 PM, Michal Simek wrote: > >>>>>> Hi, > >>>>>> > >>>>>> On 6/10/21 11:47 AM, Heinrich Schuchardt wrote: > >>>>>>> On 6/10/21 10:44 AM, Michal Simek wrote: > >>>>>>>> Hi, > >>>>>>>> > >>>>>>>> I am playing with booting from USB via EFI. And I see very weird > >>>>>>>> behavior. I have burnt image with grub to USB flashdisk and I have > >>>>>>>> tested it on 3 zynqmp boards. zcu102, zcu104 and SOM Kria board. > >>>>>>>> On zcu102 grub is going to boot menu and everything is working fine as > >>>>>>>> expected. > >>>>>>>> On zcu104 and SOM Kria I am able to get grub not to menu. When I list > >>>>>>>> partitions in grub I see that only SDs are listed: > >>>>>>>> grub> ls > >>>>>>>> (hd0) (hd0,msdos1) (hd1) (hd1,msdos1) > >>>>>>> > >>>>>>> Hello Michal, > >>>>>>> > >>>>>>> thanks for sharing your observations. > >>>>>>> > >>>>>>> What devices do hd0 and hd1 relate to? > >>>>>>> > >>>>>>>> > >>>>>>>> On zcu102(working board) I also see usb(gpt) partitions and SD. > >>>>>>>> grub> ls > >>>>>>>> (hd0) (hd0,gpt2) (hd0,gpt1) (hd1) (hd1,msdos1) > >>>>>>>> > >>>>>>> > >>>>>>> GPT and MBR partitioning are independent of the device type. > >>>>>>> > >>>>>>>> > >>>>>>>> On zcu104 I see one more error message > >>>>>>>> "PE image measurement failed" > >>>>>>> > >>>>>>> This is related to CONFIG_EFI_TCG2_PROTOCOL=y. Do you have a TPMv2? This > >>>>>>> will not stop disk enumeration. > >>>>>>> > >>>>>>>> But I can't see it on SOM. > >>>>>>>> > >>>>>>>> U-Boot image is just the same for all boards. I am using generic > >>>>>>>> xilinx_zynqmp_virt_defconfig. > >>>>>>>> > >>>>>>>> When I compare DT description for USB between zcu102 and zcu104 they > >>>>>>>> are > >>>>>>>> the same. SOM doesn't have usb enabled by default (but I enabled it) > >>>>>>>> but > >>>>>>>> grub starts which means that communication with USB is fine. > >>>>>>>> > >>>>>>>> It is based on my latest patches available here. > >>>>>>>> u-boot/custodians/u-boot-microblaze.git (usb-efi-issue branch) > >>>>>>>> > >>>>>>>> Also when I list usb I see all partitions just fine. > >>>>>>>> ZynqMP> part list usb 0 > >>>>>>>> > >>>>>>>> Partition Map for USB device 0  --   Partition Type: EFI > >>>>>>>> > >>>>>>>> Part    Start LBA       End LBA         Name > >>>>>>>>           Attributes > >>>>>>>>           Type GUID > >>>>>>>>           Partition GUID > >>>>>>>>     1     0x00000800      0x001007fe      "Microsoft basic data" > >>>>>>>>           attrs:  0x0000000000000000 > >>>>>>>>           type:   ebd0a0a2-b9e5-4433-87c0-68b6b72699c7 > >>>>>>>>           type:   data > >>>>>>>>           guid:   0e7f8b3d-296b-4720-be9d-c4687d3c4a77 > >>>>>>>>     2     0x00100800      0x001197fe      "Microsoft basic data" > >>>>>>>>           attrs:  0x0000000000000000 > >>>>>>>>           type:   ebd0a0a2-b9e5-4433-87c0-68b6b72699c7 > >>>>>>>>           type:   data > >>>>>>>>           guid:   8892eddc-231a-4e6e-a5e1-c310f4482fb7 > >>>>>>>> > >>>>>>>> > >>>>>>>> Do you have any idea why on one system is working fine to get to menu > >>>>>>>> and on others there is an issue to get all partitions even u-boot is > >>>>>>>> able to see them and can work with them. > >>>>>>>> > >>>>>>>> Thanks, > >>>>>>>> Michal > >>>>>>>> > >>>>>>> > >>>>>>> Where is the GRUB binary? - If it is in EFI/boot/bootaa64.efi, it could > >>>>>>> be that the USB sub-system is simply not initialized yet when the boot > >>>>>>> manager is called by distroboot. > >>>>>>> > >>>>>>> For testing partition detection in the UEFI sub-system it is enough > >>>>>>> to run > >>>>>>> > >>>>>>>      efidebug devices > >>>>>>> > >>>>>>> Until yesterday we had a problem with partition numbers >= 10, cf. > >>>>>>> > >>>>>>> efi_loader: partition numbers are hexadecimal > >>>>>>> https://source.denx.de/u-boot/u-boot/-/commit/3dca77b1dc1b6dbf9c8b51572fe4b0553cef009f > >>>>>>> > >>>>>>> > >>>>>>> > >>>>>>> Block devices are enumerated in efi_disk_register(). Please, try to add > >>>>>>> debug output there to elucidate the problem. > >>>>>> > >>>>>> I found where the problem is. First of all zcu102 didn't use the same > >>>>>> image as others (it wasn't updated properly). > >>>>>> When you have CONFIG_EFI_CAPSULE_ON_DISK_EARLY that efi_disk_register() > >>>>>> is called before usb block devices are detected and registered that's > >>>>>> why grub doesn't see them. > >>>>> > >>>>> The problem is CONFIG_EFI_SETUP_EARLY=y required by > >>>>> CONFIG_EFI_CAPSULE_ON_DISK_EARLY. > >>>>> > >>>>> Why is USB initialized later then MMC? > >>>> > >>>> It is not just usb. SCSI/sata are behaving in the same way too. > >>>> > >>>>> > >>>>> Overall we have a deficiency in the UEFI implementation in that we > >>>>> cannot deal with block devices added or removed after initialization. > >>>>> > >>>>> Here integration with the driver model is missing. > >>>> > >>>> Right. And also there are commands which can create MBR partitions and I > >>>> expect when you write image to SD and then run rescan or so you could > >>>> get other partitions too. > >>>> Maybe hook via part_init()? with removing efi_disk_register. > >>> > >>> For the record, I have proposed my ideas several times[1], [2]. > >>> I'm, however, no longer working on this issue as I have shifted > >>> my focus to UEFI secure boot and capsule update. > >>> > >>> -Takahiro Akashi > >>> > >>> [1] https://lists.denx.de/pipermail/u-boot/2018-November/347491.html > >>> [2] https://lists.denx.de/pipermail/u-boot/2019-February/357923.html > >> > >> I want to continue on this thread. I have disabled > >> EFI_CAPSULE_ON_DISK_EARLY some time ago and trying to workaround that > >> usb/scsi detection by simply calling usb reset and scsi reset as the > >> part of PREBOOT. Then all disks are recorded and visible by grub. > >> > >> But I found another issue which is kind of weird. We are using > >> distroboot with soft of fixed sequence. Important part of sequence is > >> sd, usb, scsi. > >> > >> I have added grub on scsi and when I boot directly via run bootcmd_scsi0 > >> everything is working fine. When I let distroboot to do the job it or > >> run printenv -e before bootcmd_scsi0 I am getting exception. > >> From debug it is visible that it is exception called from > >> efi_disk_read_blocks. > >> > >> 0 0x7ff5d188 hang()+20: include/bootstage.h, line 389 > >> 1 0x7ff5f908 __assert_fail(): lib/panic.c, line 25 > >> 2 0x7fe976a8 do_irq(): arch/arm/lib/interrupts_64.c, line 123 > >> 3 0x7fe96a0c _restore_regs()+124: arch/arm/cpu/armv8/exceptions.S, > >> line 141 > >> 4 0x7ff43740 efi_disk_read_blocks()+160: lib/efi_loader/efi_disk.c, > >> line 102 > > > > How and when did you get this stack trace? > > When Abort happened I connected Xilinx debugger via jtag and look at cpu > backtrace. OK, but we are already in grub here and such a trace (in U-Boot) doesn't make sense. Right? -Takahiro Akashi > Thanks, > Michal >