From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02FFDC4338F for ; Sat, 31 Jul 2021 08:46:55 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 58BB56023F for ; Sat, 31 Jul 2021 08:46:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 58BB56023F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 680228328E; Sat, 31 Jul 2021 10:46:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="oKzVy85R"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E998683255; Sat, 31 Jul 2021 10:45:54 +0200 (CEST) Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EAE1483268 for ; Sat, 31 Jul 2021 10:45:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bmeng.cn@gmail.com Received: by mail-pl1-x636.google.com with SMTP id e5so13884776pld.6 for ; Sat, 31 Jul 2021 01:45:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Is5LN98ivnt7zAc0GtdPEL0BSZOIdTlpD+WB8UESHw4=; b=oKzVy85Rxl4nf+Lp8buKSKaYNQBUzlMcWdzOm59ZgtjkST0C1SDy1UJAxCY9jy/J9M sGSTsRZVgymttU1ypQRmdq2eslG4nnFq93ZEjLmw7f82XHw04xGAmeD3KojvslCDwTE1 TR9xjmW9sVFz80YuBnLLdTyN8p41jV4z8rfA6Gddz9Nt8D0ZHCkInYrWWrjzPrj2de+f is0lpV3CvQIvh8fSRyCWCT6esbYBfTzUHIZxQIPTIOVw1AJr6EWjOCvrablDNG8oKMQW uVtxc+rRQT/FcRWr0hXYnOEEOf8vzP3g7HFkkBMhQemPBpYuaZQtATNKl4YlPA08mjNG GLKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Is5LN98ivnt7zAc0GtdPEL0BSZOIdTlpD+WB8UESHw4=; b=dlehsi/9FyTifohOpuxYi230bhMe5psAivlKyPU/V5H7r2qK/GvXefIcBRHmZtW81E YE0XnN7WsGCbzOwm4HjgCzZbY9LICUrXYbfAty2SygwAUT4eYBOWhCwUTxfCqp957F/L HxKZ09wtgjYuy0WY9dRfHK6Ixep8v2lc2DVbw/sUHaGd6BopGLGuLo/uuABGchhVp2X8 iwTZvLuQjbCAXLw5jIwZqWTR1jdJ207xC+h8gZnlNqRjnru861wfXExDBfKY887mk9/q gKUOUAbgxNt9ideu4cbg/gBqScyrZiMLHgiRWtgWafRXV738/5vPM76hsH1shJ2H8Zuz WZyA== X-Gm-Message-State: AOAM533YSvRh+JkPvOxQKY8TNgrDjoV9116nd6z2NvuwvOP+qqM250su mql4rpZIUHnaGNltTiMlsD0= X-Google-Smtp-Source: ABdhPJySHQRBI3fmPfYPJomHlsGX6Cug9nwydtY7TTfJyGWwwM4iLbLTD30wKodu+1NwWGdFEHtzcw== X-Received: by 2002:a17:90b:4016:: with SMTP id ie22mr7468220pjb.68.1627721148265; Sat, 31 Jul 2021 01:45:48 -0700 (PDT) Received: from i9-aorus-gtx1080.localdomain (144.168.56.201.16clouds.com. [144.168.56.201]) by smtp.gmail.com with ESMTPSA id h6sm688355pfv.155.2021.07.31.01.45.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Jul 2021 01:45:48 -0700 (PDT) From: Bin Meng To: Simon Glass , u-boot@lists.denx.de Cc: Bin Meng Subject: [PATCH 5/7] x86: cmd: hob: Fix the command usage and help messages Date: Sat, 31 Jul 2021 16:45:27 +0800 Message-Id: <20210731084529.7524-6-bmeng.cn@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210731084529.7524-1-bmeng.cn@gmail.com> References: <20210731084529.7524-1-bmeng.cn@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean At present the hob command usage and help messages are messed up in a single line. They should be separated. This was a regression introduced when [seq] and [-v] were added to the command. Fixes: d11544dfa9f4 ("x86: hob: Add way to show a single hob entry") Fixes: 51af144eb7a0 ("x86: Allow showing details about a HOB entry") Signed-off-by: Bin Meng --- cmd/x86/hob.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/cmd/x86/hob.c b/cmd/x86/hob.c index 01db93eb3e..71e7fcbd65 100644 --- a/cmd/x86/hob.c +++ b/cmd/x86/hob.c @@ -158,8 +158,7 @@ static int do_hob(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) } U_BOOT_CMD(hob, 3, 1, do_hob, - "[-v] [seq] Print Hand-Off Block (HOB) information" - " -v - Show detailed HOB information where available" - " seq - Record # to show (all by default)", - "" + "[-v] [seq] Print Hand-Off Block (HOB) information", + " -v - Show detailed HOB information where available\n" + " seq - Record # to show (all by default)" ); -- 2.25.1