From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2D3AC4338F for ; Sat, 31 Jul 2021 23:11:39 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B2B460C3F for ; Sat, 31 Jul 2021 23:11:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0B2B460C3F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9F08A8319C; Sun, 1 Aug 2021 01:11:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="nKvVfMqB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 289F183244; Sun, 1 Aug 2021 01:11:35 +0200 (CEST) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3B1018319C for ; Sun, 1 Aug 2021 01:11:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x734.google.com with SMTP id o13so13171350qkk.9 for ; Sat, 31 Jul 2021 16:11:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NVjwYO4pKGuRlcv6PN0MYp2kT5jyEtbAc+NDcPaYMe0=; b=nKvVfMqBMn+CD/RRtta9VJc2Wo8ZSd9Q0tA0usohaZNQcbUZ+AZMW8OmmU+jpk2LPU P3tOAPCSS1K8np0MUu9KoPppNVixvuNqNOc3gO+t8jUH+7qWZoVvOJ4if6r6dVPKLmkL KkUTPGYK8GqxRd0YpkbmAmmQalPCH/CBptN5Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NVjwYO4pKGuRlcv6PN0MYp2kT5jyEtbAc+NDcPaYMe0=; b=WR2/+CbdrMBOIXOWRxaddTx2B89raBNvNM1A5wgntEhfRM4cCYoGtFtpKC1cTrsptA vppY22c51VGprY4vBhiAQAYfizVxuWG1jnYT7uO3huekuswXbj/Xq28wAc+5yqP+WGZ3 vEopQiEflTDEuy8C5I54ecxHshcuLtPAcJeizcHnmPdmKimfkp6mQRmHJNnIhrG/LZIJ Ixe8Ve6W20BbxvQhuMgcy+Vgxn7NFfXOAwZaJCUhxyCnNwwPn7GUMkrQl/PH2hfLJOqU yP1PnFD8Y54dcQdwbfz0F0gBgiKl7TmPi9FdMTUPNcwj9CHfP261MgAcoG0HI+P0xykr B1lw== X-Gm-Message-State: AOAM530R3Lx467ge2ieHnKAbJOxo1VVN92zo4buvFvMhELX1/GO/UEdu liEF50ne6TwgjFm0LSu0JMXHbw== X-Google-Smtp-Source: ABdhPJyALV7UxwY8Kzq96TqIhJzKGGd4DHk3wum2nBF5Op6dACegoZgB3xFI8CGNBY9WzZQN5CYmHQ== X-Received: by 2002:a05:620a:149c:: with SMTP id w28mr8895086qkj.127.1627773088910; Sat, 31 Jul 2021 16:11:28 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-fdcd-676f-f898-928d.res6.spectrum.com. [2603:6081:7b01:cbda:fdcd:676f:f898:928d]) by smtp.gmail.com with ESMTPSA id d79sm3357150qke.45.2021.07.31.16.11.27 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 31 Jul 2021 16:11:28 -0700 (PDT) Date: Sat, 31 Jul 2021 19:11:25 -0400 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Alexandru Gagniuc , Aswath Govindraju , Bin Meng , Heinrich Schuchardt , Jaehoon Chung , Jagan Teki , Jagannadha Sutradharudu Teki , Joe Hershberger , Joel Stanley , Lokesh Vutla , Marek Vasut , Patrick Delaunay , Pavel Herrmann , Peng Fan , Ramon Fried , Tero Kristo Subject: Re: [PATCH v6 0/5] of-platdata: Avoid building libfdt Message-ID: <20210731231125.GH9379@bill-the-cat> References: <20210725161347.457937-1-sjg@chromium.org> <20210725203231.GG9379@bill-the-cat> <20210726120933.GJ9379@bill-the-cat> <20210726144337.GV9379@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="TA910QTX7AD8TylE" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --TA910QTX7AD8TylE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 31, 2021 at 05:07:41PM -0600, Simon Glass wrote: > Hi Tom, >=20 > On Mon, 26 Jul 2021 at 08:43, Tom Rini wrote: > > > > On Mon, Jul 26, 2021 at 07:45:27AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 26 Jul 2021 at 06:09, Tom Rini wrote: > > > > > > > > On Sun, Jul 25, 2021 at 09:57:25PM -0600, Simon Glass wrote: > > > > > Hi Tom, > > > > > > > > > > On Sun, 25 Jul 2021 at 14:32, Tom Rini wrote: > > > > > > > > > > > > On Sun, Jul 25, 2021 at 10:13:42AM -0600, Simon Glass wrote: > > > > > > > > > > > > > The original patch of this series was sent in September 2019 = but > > > > > > > unfortunately caused build problems on some boards, since the= y don't > > > > > > > comply with the of-platdata rules. > > > > > > > > > > > > > > With of-platdata, the idea is to compile the device tree into= C structures > > > > > > > to save space and avoid needing to use libfdt. But some board= s use > > > > > > > of-platdata while also using libfdt in a few areas, thus defe= ating the > > > > > > > purpose of of-platdata. > > > > > > > > > > > > > > This series includes the original two patches > > > > > > > > > > > > > > http://patchwork.ozlabs.org/patch/1167420/ > > > > > > > http://patchwork.ozlabs.org/patch/1167367/ > > > > > > > > > > > > > > as well as a few other patches to fix the build errors. Overa= ll this > > > > > > > reduces code size and provides better error messages when una= vailable > > > > > > > functions are used. > > > > > > > > > > > > > > Board maintainers should still take a look at the result, adj= usting the > > > > > > > of-platdata support as needed. > > > > > > > > > > > > > > Note: This series was resent a year ago but not applied. Sinc= e then, some > > > > > > > boards have ended up using drivers in SPL which require OF_CO= NTROL, but > > > > > > > SPL_OF_CONTROL is not enabled. So now we have two problems. T= his series > > > > > > > fixes that one also. > > > > > > > > > > > > > > The problems will keep getting worse if people are not aware = that > > > > > > > something is wrong. Therefore I think this patch series shoul= d be applied > > > > > > > ASAP. > > > > > > > > > > > > OK, so I took 5/6 and 6/6 and fired off a build. The only fail= s-to-link > > > > > > now are: > > > > > > am335x_boneblack_vboot am335x_evm am335x_evm_spiboot > > > > > > > > > > > > So are all of the other problems still present? I'm going to l= ook in to > > > > > > the am335x failures. > > > > > > > > > > I got a passing build here: > > > > > > > > > > https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/83= 98 > > > > > > > > > > I am wondering if I did something wrong when sending? > > > > > > > > I didn't include patches 1-4, in order to get build failures and see > > > > what platforms need fixing. > > > > > > OK, I see. Yes I believe all the problems are still present. If you > > > like i can add the errors/warnings I saw here. > > > > Please. https://source.denx.de/u-boot/u-boot/-/jobs/298139 are the only > > errors I saw at build time when not using the patches to turn build time > > in to run time problems. >=20 > Yes I see the same thing now. >=20 > I suspect I didn't have the latest master when I started and some > boards have been removed. >=20 > Do you want to just take the patches that make sense from this series? It gets back to figuring out something to do for am335x_evm. I need to post the fixes for the other two defconfigs as well. --=20 Tom --TA910QTX7AD8TylE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEF2JoACgkQFHw5/5Y0 tyxnuwv+PeNx/Bonh16d/2Zag7BSNPk2QGw4V7+KqgklmDehNPe7UTKKIdBOv+/4 7DQl47PtlzRE0Le6M2bMuiyP6nyljfzih1hfa0JzFHCpbZkubYVBp3knytbIWPZI Clm3Ycw9qFubY8juyMA7Dm1KufOz0UY81bcgZr+yiveZ00ccBgO83JyRMNvJEg01 jqurPpNwHdpraPR85W9dDuSgqpRBCqxiTVVesF7hFcOUSNRCObYaaAtqr6gXSaz3 yXxAdjwEEUXgi+oHcbZl+sGIg8KYebbba2ODU7g2vciXI5RJ73+t7UgvcwYlcaOh vWFABeKtnSKlaOTmcjtc0b7xib8LW29PnEauzNgMGxfao11w4SNMlA//y37Gm64+ P8CSagXUiFNk6S8iGB81kpVZwES2LzZkv0VXSARZI3/P+SQ2hTyyRqSYoXhby6xW 8jPMHeaMrlBVWoXf0EAlCe/C782YKH5LJEfAQcc6fbZzb4vbkRtj5gXIZ211HVid kKKag81q =9EGT -----END PGP SIGNATURE----- --TA910QTX7AD8TylE--