From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DF6FC4338F for ; Sun, 1 Aug 2021 04:29:52 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F05160F13 for ; Sun, 1 Aug 2021 04:29:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5F05160F13 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 120F382C24; Sun, 1 Aug 2021 06:29:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="pDc4/jPA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C55C982DD3; Sun, 1 Aug 2021 06:29:47 +0200 (CEST) Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 53A9F80C7E for ; Sun, 1 Aug 2021 06:29:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pj1-x1034.google.com with SMTP id u9-20020a17090a1f09b029017554809f35so26706650pja.5 for ; Sat, 31 Jul 2021 21:29:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=Q7zEoTmBhQiptUTWUhmbU3meY9EmhgWcMwSBe/UMb+4=; b=pDc4/jPAbAgQoqHIb7Fo2FwTE7M5OIPROckaSrv5gGUg9kRYOXGVxWAUMoGtcP8qL1 WIDubkXpV++zdQf12v29xc0PlZA8A3Maptfe1R7FBwkyjODN7BBV76YGILTRYF3jxm+h lW76OtcPEnZpNmGqjd/2BXpnGE8LJoFv8/8bamIW/AhTI1wnaGljhqAwWTNwSo20dyBv k1kcjUMmnwS0gCjD+zc0RLHm6JXbm6TN28eKyb1InSpzAstVeU3Dyf4Da47lnibUfVph iIr57kqULCi5eoyA4sExMk8zldQrmodzo8A+YA3nUAJ9El9+hOyHZa95p8odMHpidnog UWXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=Q7zEoTmBhQiptUTWUhmbU3meY9EmhgWcMwSBe/UMb+4=; b=XmvoYMLFcnv84TYhjQtnl07Li1AKstPk/ea9+4pOya2gtT4O59CyRiSYjPDbKrhu+U jQbSeUYmyWcu21Bdt7Fp+zxE5YHkaBXMyeGIHhJQodAHp0P54+Sr9uBK+IsyFSVuSKjn qIyTJ9YQ6SFd6s0MLR/YEbmytnOL0hhCnKveCz1ruWYkAEdLwgQloHQ0JMNCNwL445qC igWbgvebOFlLC+C1LCM7t2YsvGP6hhNaRLFql6e5zBFo7mXkzDQOH+hLeoQ3Up+aZBA0 XfeE9JmMusCxG3KVEJWl7ZYo57u0AcARFAm4hZfHPP8bpYb0D++cpDHKhUxF3whG3/Wf bgpQ== X-Gm-Message-State: AOAM532hSYFm8h72EUupL1YGTXKuFm9qQgDErf5IYLFVPX9HmCMqAyz8 GQ/PoRnaVjBbiWV5dvRDFX3fBQ== X-Google-Smtp-Source: ABdhPJxFw4RyWbJS75LroMkF2rnZmXxaoSpFiw+S4Bxk4lXRx0cH1e7VddHw4w8C2L2DAFwfq+Ax9g== X-Received: by 2002:a62:54c5:0:b029:3a9:d3d9:4fe8 with SMTP id i188-20020a6254c50000b02903a9d3d94fe8mr10468642pfb.36.1627792177523; Sat, 31 Jul 2021 21:29:37 -0700 (PDT) Received: from laputa (pdb6272ed.tkyea130.ap.so-net.ne.jp. [219.98.114.237]) by smtp.gmail.com with ESMTPSA id n8sm7350016pfd.100.2021.07.31.21.29.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Jul 2021 21:29:37 -0700 (PDT) Date: Sun, 1 Aug 2021 13:29:32 +0900 From: AKASHI Takahiro To: Simon Glass Cc: Heinrich Schuchardt , Alex Graf , Tom Rini , Ilias Apalodimas , Sughosh Ganu , Masami Hiramatsu , U-Boot Mailing List Subject: Re: [PATCH v2 6/9] sandbox: add config for efi capsule authentication test Message-ID: <20210801042932.GA53902@laputa> Mail-Followup-To: AKASHI Takahiro , Simon Glass , Heinrich Schuchardt , Alex Graf , Tom Rini , Ilias Apalodimas , Sughosh Ganu , Masami Hiramatsu , U-Boot Mailing List References: <20210727091054.512050-1-takahiro.akashi@linaro.org> <20210727091054.512050-7-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Simon, On Sat, Jul 31, 2021 at 10:59:32AM -0600, Simon Glass wrote: > Hi Takahiro, > > On Tue, 27 Jul 2021 at 03:12, AKASHI Takahiro > wrote: > > > > This new configuration, which was derived from sandbox_defconfig, will be > > used solely to run efi capsule authentication test as the test requires > > a public key (esl file) to be embedded in U-Boot binary. > > > > Signed-off-by: AKASHI Takahiro > > --- > > configs/sandbox_capsule_auth_defconfig | 307 +++++++++++++++++++++++++ > > 1 file changed, 307 insertions(+) > > create mode 100644 configs/sandbox_capsule_auth_defconfig > > NAK. > > Please just add it to sandbox_defconfig. We sometimes have to create Unfortunately, I can't. Look, we now have two tests, test_capsule_firmware.py and test_capsule_firmware_signed.py, and we need U-Boot binaries, respectively, without a key and with a key. A single configuration cannot satisfy both. > new variants when dealing with actual build variations (e.g. SPL, > building without OF_LIVE), but here we should just enable the feature > in sandbox_defconfig. > > We already covered embedding key in the binary on another thread. > Please don't do that. After that debacle I sent a patch explaining > this: > > http://patchwork.ozlabs.org/project/uboot/patch/20210725164400.468319-3-sjg@chromium.org/ Please discuss and make an agreement with Heinrich. The patch for embedding a key has already been merged in -rc1. In my personal opinion, neither approaches won't apply to production any way. -Takahiro Akashi > Regards, > Simon