From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56289C4338F for ; Mon, 2 Aug 2021 04:50:50 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3234460FC1 for ; Mon, 2 Aug 2021 04:50:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3234460FC1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F1D9A83311; Mon, 2 Aug 2021 06:50:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="ng9bF5+9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0516A83304; Mon, 2 Aug 2021 06:50:46 +0200 (CEST) Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 28F9583304 for ; Mon, 2 Aug 2021 06:50:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pl1-x636.google.com with SMTP id d1so18353542pll.1 for ; Sun, 01 Aug 2021 21:50:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=Ckc9U6iTPuicbW/vaNnWGG/DiR0h5jIzu16lpp8IgoY=; b=ng9bF5+9zhPEGq32ZwPNWHJq73vtrCdsBUz+8eQ7zrj9Dfl9ji1wTdItBxYtGCcxA8 SZ8KTBuUx/ZDPraElUOiuXbu20cU0HfMtLkDoegra6yaQiC5fqY1mODw4jjwjg7C0Mja hV250ugsjiGrnLh+2xFhtIs7nmbj4yrSeS//p0yLKt7dM/sqtTQzH9niAum/3VPDvs80 Qi4yTOjqN8YnrB+WpMZWPL0XVUTZFftT5zo63AyxcB927JHfi5wGSjU5DGT5E+/qTFXL lPAwZTsjyvbipxUBmNhWYowApWyd5ZenbJqmed6rDpJ1WBJetPUPAPDkcR5FV5yNxyo1 UczA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=Ckc9U6iTPuicbW/vaNnWGG/DiR0h5jIzu16lpp8IgoY=; b=msIi0N2BDKH73uhG+YbGBPn93bNR+m2SXGXz+BT0ISIntmD14KONSl3IgTGOSY4Rgg io7GNuFJ0VPzmFWBPq9BS06/bz62XfIZ7n6pkH/e6q3OjfRsYYxqw1/2NsApDxmnkR78 mOgJIVlmJTpy04kFMt1Y8qdTGYk+MZLy240NmjdpIuyZErvD23b80jxyjtCUc7CBrCLl 1ebftkafLf1fB99UHRuKnaSxM2PG1qTb7f7fdObx8BqHotm6bjeYqn7lZ7a9Tty0HB73 mzWeVpZ9TA9uS/BaE6qsoB9vbuMx6KQq5o4GCV4AZh4Mg/oLLv+7HIfcETafC0cvtZbj zVlQ== X-Gm-Message-State: AOAM53181kujnbUU87bvzO6B7SpiyCclAcf8OMupokWhuH2t7buNBUGP fBXywIh+Q2VLgpUV2b4xnzjoSw== X-Google-Smtp-Source: ABdhPJy3b8IRJzb/lEsX1sJ8oaS3+Ym6n+tdAJiDv84Sc4bSAQYq0TASyPaUspjqzg8UIGGNtMg8Pw== X-Received: by 2002:a63:b950:: with SMTP id v16mr506737pgo.328.1627879841361; Sun, 01 Aug 2021 21:50:41 -0700 (PDT) Received: from laputa (pdb6272b1.tkyea130.ap.so-net.ne.jp. [219.98.114.177]) by smtp.gmail.com with ESMTPSA id h10sm2771569pfi.64.2021.08.01.21.50.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Aug 2021 21:50:40 -0700 (PDT) Date: Mon, 2 Aug 2021 13:50:24 +0900 From: AKASHI Takahiro To: Heinrich Schuchardt Cc: agraf@csgraf.de, trini@konsulko.com, sjg@chromium.org, ilias.apalodimas@linaro.org, sughosh.ganu@linaro.org, masami.hiramatsu@linaro.org, u-boot@lists.denx.de Subject: Re: [PATCH v2 4/9] efi_loader: ease the file path check for public key Message-ID: <20210802045024.GD7965@laputa> Mail-Followup-To: AKASHI Takahiro , Heinrich Schuchardt , agraf@csgraf.de, trini@konsulko.com, sjg@chromium.org, ilias.apalodimas@linaro.org, sughosh.ganu@linaro.org, masami.hiramatsu@linaro.org, u-boot@lists.denx.de References: <20210727091054.512050-1-takahiro.akashi@linaro.org> <20210727091054.512050-5-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sun, Aug 01, 2021 at 11:35:15AM +0200, Heinrich Schuchardt wrote: > On 7/27/21 11:10 AM, AKASHI Takahiro wrote: > > The check for CONFIG_EFI_CAPSULE_KEY_PATH: > > ifeq ("$(wildcard $(EFI_CAPSULE_KEY_PATH))","") > > does not allow users to specify a relative path for including a public > > key binary. This is fine for most of all cases, but it will make it > > difficult to add pytest test cases as pre-created keys/certificates > > are placed in "test" directory. > > > > So just ease the check, still causing an error if the specified file > > does not exist at compiling efi_capsule_key.S. > > > > Signed-off-by: AKASHI Takahiro > > --- > > lib/efi_loader/Makefile | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/lib/efi_loader/Makefile b/lib/efi_loader/Makefile > > index 9b369430e258..fca0da4d131e 100644 > > --- a/lib/efi_loader/Makefile > > +++ b/lib/efi_loader/Makefile > > @@ -21,8 +21,9 @@ targets += helloworld.o > > endif > > > > ifeq ($(CONFIG_EFI_CAPSULE_AUTHENTICATE),y) > > -EFI_CAPSULE_KEY_PATH := $(subst $\",,$(CONFIG_EFI_CAPSULE_KEY_PATH)) > > -ifeq ("$(wildcard $(EFI_CAPSULE_KEY_PATH))","") > > +#EFI_CAPSULE_KEY_PATH := $(subst $\",,$(CONFIG_EFI_CAPSULE_KEY_PATH)) > > +#ifeq ("$(wildcard $(EFI_CAPSULE_KEY_PATH))","") > > Please, remove these two comment lines. I forgot to do so. > > +ifeq ($(CONFIG_EFI_CAPSULE_KEY_PATH),"") > > $(error .esl cerificate not found. Configure your CONFIG_EFI_CAPSULE_KEY_PATH) > > %s/cerificate/certificate/ This misspelling does exist in the original. I won't fix it. -Takahiro Akashi > Best regards > > Heinrich > > > endif > > endif > > >